)]}'
{"tempest/hacking/checks.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b8f787d3911ee3fbb559bc45deddc4b591a2f594","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    yield (0, msg)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"def no_direct_unicode_type(logical_line):"},{"line_number":261,"context_line":"    \"\"\"Check that tests don\u0027t use the `unicode` type directly."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    The `unicode` type doesn\u0027t exist in Python3."}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_46040f49","line":260,"updated":"2016-05-10 16:33:01.000000000","message":"Looks like you need to add \u0027tokens\u0027 named arg, which looks like an array of 5 items (NOTE: this used in pep8 for token_type, text, start, end, line in tokens )\n\nI assume the text section will contain exactly the \u0027unicode\u0027 in case of T115 violation.","commit_id":"7cdda8b78e694895a6541fa65073f402ff5ac471"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"deb80f8e9de23db18c40cb4052027423562ca1b0","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    \"\"\"Check that tests don\u0027t use the `unicode` type directly."},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    The `unicode` type doesn\u0027t exist in Python3."},{"line_number":264,"context_line":"    T115"},{"line_number":265,"context_line":"    \"\"\""},{"line_number":266,"context_line":"    unicode_regex \u003d re.compile(r\u0027\\bunicode\\b\u0027)"},{"line_number":267,"context_line":"    msg \u003d \"The `unicode` type don\u0027t exist in Py3. Use `six.text_type` instead.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_31980378","line":264,"range":{"start_line":264,"start_character":4,"end_line":264,"end_character":8},"updated":"2016-05-17 08:59:55.000000000","message":"The biggest number is T113 now, why don\u0027t you use T114?\nIn addition, we need to write a new rule on HACKING.rst.","commit_id":"7cdda8b78e694895a6541fa65073f402ff5ac471"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7d7ac369d9c2a9a05fa08e08c06e46c560856141","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    The `unicode` type doesn\u0027t exist in Python3."},{"line_number":264,"context_line":"    T115"},{"line_number":265,"context_line":"    \"\"\""},{"line_number":266,"context_line":"    unicode_regex \u003d re.compile(r\u0027\\bunicode\\b\u0027)"},{"line_number":267,"context_line":"    msg \u003d \"The `unicode` type don\u0027t exist in Py3. Use `six.text_type` instead.\""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    end \u003d logical_line.find(\"#\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4e8664dc","line":266,"updated":"2016-05-02 09:43:02.000000000","message":"pep8 expected to have the text tokenized already, the solution here  is likely not the `nicest` best solution, but it is simple...","commit_id":"7cdda8b78e694895a6541fa65073f402ff5ac471"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7941714fb9da2a1d5af46aacc4934ffbdbaac244","unresolved":false,"context_lines":[{"line_number":263,"context_line":"    The `unicode` type doesn\u0027t exist in Python3."},{"line_number":264,"context_line":"    T115"},{"line_number":265,"context_line":"    \"\"\""},{"line_number":266,"context_line":"    unicode_regex \u003d re.compile(r\u0027\\bunicode\\b\u0027)"},{"line_number":267,"context_line":"    msg \u003d \"The `unicode` type don\u0027t exist in Py3. Use `six.text_type` instead.\""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    end \u003d logical_line.find(\"#\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_1d589f89","line":266,"in_reply_to":"1a122d0e_4e8664dc","updated":"2016-05-10 14:35:03.000000000","message":"Agreed. But that simple regex didn\"t produce any false positive over the entire Tempest code base. So I am not sure it\u0027s worth overthinking thing. And changing this, if needs be, would be quick and easy.","commit_id":"7cdda8b78e694895a6541fa65073f402ff5ac471"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"deb80f8e9de23db18c40cb4052027423562ca1b0","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    T115"},{"line_number":265,"context_line":"    \"\"\""},{"line_number":266,"context_line":"    unicode_regex \u003d re.compile(r\u0027\\bunicode\\b\u0027)"},{"line_number":267,"context_line":"    msg \u003d \"The `unicode` type don\u0027t exist in Py3. Use `six.text_type` instead.\""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    end \u003d logical_line.find(\"#\")"},{"line_number":270,"context_line":"    if end \u003e\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_d19a5761","line":267,"range":{"start_line":267,"start_character":10,"end_line":267,"end_character":40},"updated":"2016-05-17 08:59:55.000000000","message":"It is necessary to include the number(T114) like the other rules to know what is wrong on the pep8 checking.","commit_id":"7cdda8b78e694895a6541fa65073f402ff5ac471"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"ce20ba649ab69faa492ea3f74dc2922dc0d7b22b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    T115"},{"line_number":265,"context_line":"    \"\"\""},{"line_number":266,"context_line":"    unicode_regex \u003d re.compile(r\u0027\\bunicode\\b\u0027)"},{"line_number":267,"context_line":"    msg \u003d \"The `unicode` type don\u0027t exist in Py3. Use `six.text_type` instead.\""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    end \u003d logical_line.find(\"#\")"},{"line_number":270,"context_line":"    if end \u003e\u003d 0:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_720a9f8b","line":267,"updated":"2016-04-26 21:26:09.000000000","message":"s/don\u0027t/doesn\u0027t","commit_id":"7cdda8b78e694895a6541fa65073f402ff5ac471"}]}