)]}'
{"tempest/api/volume/test_create_volume_from.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93031b24c3bf2b1f728809eb6b7bb43f8d756a3b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_create_from_volume(self):"},{"line_number":30,"context_line":"        # Creates a volume from another volume passing a size different from"},{"line_number":31,"context_line":"        # the source volume."},{"line_number":32,"context_line":"        self.src_size \u003d 2"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dself.src_size)"},{"line_number":35,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_38381da0","line":32,"updated":"2016-04-26 08:45:42.000000000","message":"Don\u0027t make this an instance variable. A local/regular variable is enough.","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"cf447efd69cad33550b7b212fe2cf4a68c05824a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def test_create_from_volume(self):"},{"line_number":30,"context_line":"        # Creates a volume from another volume passing a size different from"},{"line_number":31,"context_line":"        # the source volume."},{"line_number":32,"context_line":"        self.src_size \u003d 2"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dself.src_size)"},{"line_number":35,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_d4f46ef3","line":32,"in_reply_to":"1a122d0e_38381da0","updated":"2016-05-09 15:13:06.000000000","message":"Done","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93031b24c3bf2b1f728809eb6b7bb43f8d756a3b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.src_size \u003d 2"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dself.src_size)"},{"line_number":35,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.src_vol[\u0027id\u0027],"},{"line_number":36,"context_line":"                                       \u0027available\u0027)"},{"line_number":37,"context_line":"        # Destination volume bigger than source"},{"line_number":38,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_785575c0","line":35,"updated":"2016-04-26 08:45:42.000000000","message":"You don\"t need this. create_volume() in api/volume/base.py does this for you already.","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"cf447efd69cad33550b7b212fe2cf4a68c05824a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.src_size \u003d 2"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dself.src_size)"},{"line_number":35,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.src_vol[\u0027id\u0027],"},{"line_number":36,"context_line":"                                       \u0027available\u0027)"},{"line_number":37,"context_line":"        # Destination volume bigger than source"},{"line_number":38,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_b4f72af4","line":35,"in_reply_to":"1a122d0e_785575c0","updated":"2016-05-09 15:13:06.000000000","message":"Done","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93031b24c3bf2b1f728809eb6b7bb43f8d756a3b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Destination volume bigger than source"},{"line_number":38,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"},{"line_number":39,"context_line":"                                          size\u003dself.src_size + 1)"},{"line_number":40,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.dst_vol[\u0027id\u0027],"},{"line_number":41,"context_line":"                                       \u0027available\u0027)"},{"line_number":42,"context_line":"        volume \u003d self.volumes_client.show_volume(self.dst_vol[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":43,"context_line":"        # Should allow"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_98705174","line":40,"updated":"2016-04-26 08:45:42.000000000","message":"same","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"cf447efd69cad33550b7b212fe2cf4a68c05824a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Destination volume bigger than source"},{"line_number":38,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"},{"line_number":39,"context_line":"                                          size\u003dself.src_size + 1)"},{"line_number":40,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.dst_vol[\u0027id\u0027],"},{"line_number":41,"context_line":"                                       \u0027available\u0027)"},{"line_number":42,"context_line":"        volume \u003d self.volumes_client.show_volume(self.dst_vol[\u0027id\u0027])[\u0027volume\u0027]"},{"line_number":43,"context_line":"        # Should allow"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_14df166a","line":40,"in_reply_to":"1a122d0e_98705174","updated":"2016-05-09 15:13:06.000000000","message":"Done","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"93031b24c3bf2b1f728809eb6b7bb43f8d756a3b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @test.idempotent_id(\u00279a3678ee-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":54,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":55,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":56,"context_line":"        self.src_size \u003d 2"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dself.src_size)"},{"line_number":59,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d86649ba","line":56,"updated":"2016-04-26 08:45:42.000000000","message":"same","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"cf447efd69cad33550b7b212fe2cf4a68c05824a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    @test.idempotent_id(\u00279a3678ee-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":54,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":55,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":56,"context_line":"        self.src_size \u003d 2"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dself.src_size)"},{"line_number":59,"context_line":"        waiters.wait_for_volume_status(self.volumes_client, self.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_34e4da39","line":56,"in_reply_to":"1a122d0e_d86649ba","updated":"2016-05-09 15:13:06.000000000","message":"Done","commit_id":"3ee1be480e50546f8a8f61860f9e44797c04cfff"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e966e6f55e635e7831767dcb5291ea6f053a7a30","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # the source volume."},{"line_number":31,"context_line":"        src_size \u003d 2"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Destination volume bigger than source"},{"line_number":36,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_79bc72dc","line":33,"updated":"2016-05-10 08:38:50.000000000","message":"Why is this an instance variable ?","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"0d505f0ca27d388aaadc466c2594ed7f2b5afaa0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # the source volume."},{"line_number":31,"context_line":"        src_size \u003d 2"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Destination volume bigger than source"},{"line_number":36,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4ec4345e","line":33,"in_reply_to":"dab17558_79bc72dc","updated":"2016-05-10 12:59:06.000000000","message":"I checked some others tempest test, and the instance variable is not necessary, as you mentioned before. Done!","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e966e6f55e635e7831767dcb5291ea6f053a7a30","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Destination volume bigger than source"},{"line_number":36,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"},{"line_number":37,"context_line":"                                          size\u003dsrc_size + 1)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        volume \u003d self.volumes_client.show_volume(self.dst_vol[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_59c1ae53","line":36,"updated":"2016-05-10 08:38:50.000000000","message":"same","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"0d505f0ca27d388aaadc466c2594ed7f2b5afaa0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        # Destination volume bigger than source"},{"line_number":36,"context_line":"        self.dst_vol \u003d self.create_volume(source_volid\u003dself.src_vol[\u0027id\u0027],"},{"line_number":37,"context_line":"                                          size\u003dsrc_size + 1)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        volume \u003d self.volumes_client.show_volume(self.dst_vol[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_eea9a891","line":36,"in_reply_to":"dab17558_59c1ae53","updated":"2016-05-10 12:59:06.000000000","message":"Done","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e966e6f55e635e7831767dcb5291ea6f053a7a30","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":53,"context_line":"        src_size \u003d 2"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.src_snap \u003d self.create_snapshot(self.src_vol[\u0027id\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_99b796f4","line":55,"updated":"2016-05-10 08:38:50.000000000","message":"same","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"0d505f0ca27d388aaadc466c2594ed7f2b5afaa0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":53,"context_line":"        src_size \u003d 2"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.src_snap \u003d self.create_snapshot(self.src_vol[\u0027id\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2e98d077","line":55,"in_reply_to":"dab17558_99b796f4","updated":"2016-05-10 12:59:06.000000000","message":"Done","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e966e6f55e635e7831767dcb5291ea6f053a7a30","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.src_snap \u003d self.create_snapshot(self.src_vol[\u0027id\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Destination volume bigger than source snapshot"},{"line_number":60,"context_line":"        self.dst_vol \u003d self.create_volume(snapshot_id\u003dself.src_snap[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_f9d06221","line":57,"updated":"2016-05-10 08:38:50.000000000","message":"same","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"0d505f0ca27d388aaadc466c2594ed7f2b5afaa0","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        self.src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.src_snap \u003d self.create_snapshot(self.src_vol[\u0027id\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Destination volume bigger than source snapshot"},{"line_number":60,"context_line":"        self.dst_vol \u003d self.create_volume(snapshot_id\u003dself.src_snap[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_0e950c3e","line":57,"in_reply_to":"dab17558_f9d06221","updated":"2016-05-10 12:59:06.000000000","message":"Done","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e966e6f55e635e7831767dcb5291ea6f053a7a30","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.src_snap \u003d self.create_snapshot(self.src_vol[\u0027id\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Destination volume bigger than source snapshot"},{"line_number":60,"context_line":"        self.dst_vol \u003d self.create_volume(snapshot_id\u003dself.src_snap[\u0027id\u0027],"},{"line_number":61,"context_line":"                                          size\u003dsrc_size + 1)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        volume \u003d self.volumes_client.show_volume(self.dst_vol[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_39c78a65","line":60,"updated":"2016-05-10 08:38:50.000000000","message":"same","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":11751,"name":"Marcus V R Nascimento","email":"marcusvrn@gmail.com","username":"marcusvrn"},"change_message_id":"0d505f0ca27d388aaadc466c2594ed7f2b5afaa0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.src_snap \u003d self.create_snapshot(self.src_vol[\u0027id\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        # Destination volume bigger than source snapshot"},{"line_number":60,"context_line":"        self.dst_vol \u003d self.create_volume(snapshot_id\u003dself.src_snap[\u0027id\u0027],"},{"line_number":61,"context_line":"                                          size\u003dsrc_size + 1)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        volume \u003d self.volumes_client.show_volume(self.dst_vol[\u0027id\u0027])[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_6e9e5864","line":60,"in_reply_to":"dab17558_39c78a65","updated":"2016-05-10 12:59:06.000000000","message":"Done","commit_id":"242cf01590612dd347020bd288ef997fd6a303bc"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"fdf298f9448caba9dc5ed74f50f8ebe1786a75f4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumesCreateFromTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00279adae371-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":28,"context_line":"    def test_create_from_volume(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_952756b5","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":49},"updated":"2016-05-16 09:53:58.000000000","message":"Hi , \nMaybe you can choose differnet name from class \nmeaningfull name.\n\nPlease check if we can add these tests to existing tests file.","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"89514af1e0e0a686228e623a61e775117bdce14f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumesCreateFromTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00279adae371-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":28,"context_line":"    def test_create_from_volume(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_b9537815","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":49},"in_reply_to":"dab17558_952756b5","updated":"2016-06-17 12:58:42.000000000","message":"Do you have any suggestion? This looks a meaningful name to me.\nCan you point out the file?","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"5a8d892ecc0d74c2cc239b4f9272535c3595c00e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @test.idempotent_id(\u00279a3678ee-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d 2"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_91bc4fbc","line":50,"updated":"2016-05-11 10:28:20.000000000","message":"We have already a test called \"test_volume_from_snapshot\". Yours is way better. I think we should delete the \"test_volume_from_snapshot\" test. What do you think ?","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"4ffefdadd3bb1c723886cace32c9fc78a0644bea","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @test.idempotent_id(\u00279a3678ee-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d 2"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_228a9dbf","line":50,"in_reply_to":"7aa08908_79ff5001","updated":"2016-06-17 18:44:12.000000000","message":"I think we should better leave that test. There are some CIs that filter for specific tests. If we add this and remove that, they can end up running no test at all.","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"89514af1e0e0a686228e623a61e775117bdce14f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @test.idempotent_id(\u00279a3678ee-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d 2"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_79ff5001","line":50,"in_reply_to":"dab17558_91bc4fbc","updated":"2016-06-17 12:58:42.000000000","message":"I\u0027ll look for this test to check.","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"fdf298f9448caba9dc5ed74f50f8ebe1786a75f4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d 2"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":55,"context_line":"        src_snap \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":56,"context_line":"        # Destination volume bigger than source snapshot"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_f22358bb","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":0},"updated":"2016-05-16 09:53:58.000000000","message":"Hi , why the src_size is hardcoded here ?\nPlease take the size from :\n# Default size in GB for volumes created by volumes tests (integer\n# value)\n#volume_size \u003d 1","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"89514af1e0e0a686228e623a61e775117bdce14f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d 2"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":55,"context_line":"        src_snap \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":56,"context_line":"        # Destination volume bigger than source snapshot"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f9afc0e0","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":0},"in_reply_to":"bab6814e_a25f400d","updated":"2016-06-17 12:58:42.000000000","message":"I\u0027ll follow this idea. CONF.volume_size + 1 will solve the problem.","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"be67436fe4719ae6676273f939b5990f2a159ac1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d 2"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":55,"context_line":"        src_snap \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":56,"context_line":"        # Destination volume bigger than source snapshot"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_a25f400d","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":0},"in_reply_to":"dab17558_f22358bb","updated":"2016-05-18 09:23:17.000000000","message":"That won\u0027t work because -1 - 1 \u003d 0...\n\nMaybe CONF.volume_size + 1 would work.","commit_id":"d5f78f439c880bd8aa8773884ddda4dc398da9cb"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fbf248ffcb04f124eb3dee76ba584826e8420ad9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumesCreateFromVolSnapSrcTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00279adae371-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":28,"context_line":"    def test_create_from_volume(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_af939ff9","line":25,"updated":"2016-06-20 09:04:40.000000000","message":"What does the \"SnapSrc\" part means ? In the first test test_create_from_volume you don\"t create any snapshot.","commit_id":"c178e5822dcf9fafb73948f2f1127503a7d90366"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a2764f2405e6632709fcbbeae7be592a81e4768f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"CONF \u003d config.CONF"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class VolumesCreateFromVolSnapSrcTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00279adae371-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":28,"context_line":"    def test_create_from_volume(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_7837bae3","line":25,"in_reply_to":"5a9d85d2_af939ff9","updated":"2016-06-20 11:45:49.000000000","message":"I was trying to make the name more meaningful. It should point that it also tests from a snapshot source. But never mind. I added the snapshot test inside the snapshot as you suggested. Also, re-named the \u0027create from test\u0027 to \u0027clone\u0027. I think is better this way.","commit_id":"c178e5822dcf9fafb73948f2f1127503a7d90366"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"fbf248ffcb04f124eb3dee76ba584826e8420ad9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @test.idempotent_id(\u00279a3678ee-a257-43a5-9555-dc7c88e66e0e\u0027)"},{"line_number":50,"context_line":"    def test_create_from_snapshot(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_4fff9b34","line":50,"updated":"2016-06-20 09:04:40.000000000","message":"We already have a \u0027test_volume_from_snapshot\u0027 test. We can\u0027t have duplicate tests in Tempest, especially when the tests are expensive.\n\nYou could remove the original \u0027test_volume_from_snapshot\u0027 and use that one instead, keeping the same name AND the same idempotent id.","commit_id":"c178e5822dcf9fafb73948f2f1127503a7d90366"}],"tempest/api/volume/test_volumes_clone.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"86c0325aaec7e2e63bf006eb7ec0d4678f68c456","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_create_from_volume(self):"},{"line_number":29,"context_line":"        # Creates a volume from another volume passing a size different from"},{"line_number":30,"context_line":"        # the source volume."},{"line_number":31,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":"        # Destination volume bigger than source"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_279ee8b8","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":46},"updated":"2016-06-26 07:29:56.000000000","message":"Hi. What happens if the source volume is bigger than the cluster allows? It doesn\u0027t know if the original size is on the edge. The volume\u0027ll be created anyway with a \u0027status:error\u0027 and the new volume\u0027ll be created with size+1 (COW). I\u0027m curious what your thoughts are.","commit_id":"87e13a3944a6e37369e94d450db1e4ab79d06ed1"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5b72a7f866b1b3582b63a4cf9054ff4986caca34","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_create_from_volume(self):"},{"line_number":29,"context_line":"        # Creates a volume from another volume passing a size different from"},{"line_number":30,"context_line":"        # the source volume."},{"line_number":31,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":"        # Destination volume bigger than source"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_8a198e24","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":46},"in_reply_to":"3aaa91ec_279ee8b8","updated":"2016-06-27 10:35:47.000000000","message":"Hi Sofia, volume_size is an adjustable parameter, by default it\u0027s 1GB. This can be achieved by the majority of Cinder backends. If its not possible, then the user will have to adjust CONF.volume.volume_size to what is possible to work in that backend.","commit_id":"87e13a3944a6e37369e94d450db1e4ab79d06ed1"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c915d1721c81bffb14bed9b30e97807e75a8bdec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_create_from_volume(self):"},{"line_number":29,"context_line":"        # Creates a volume from another volume passing a size different from"},{"line_number":30,"context_line":"        # the source volume."},{"line_number":31,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":34,"context_line":"        # Destination volume bigger than source"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_ad028bb2","line":31,"range":{"start_line":31,"start_character":8,"end_line":31,"end_character":46},"in_reply_to":"3aaa91ec_8a198e24","updated":"2016-06-27 19:17:33.000000000","message":"Done","commit_id":"87e13a3944a6e37369e94d450db1e4ab79d06ed1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"554521471685d2b0fe644935b58565d2a92819e5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.assertEqual(int(volume[\u0027size\u0027]), src_size + 1)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        # Destination volume smaller than source"},{"line_number":44,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":45,"context_line":"                          self.volumes_client.create_volume,"},{"line_number":46,"context_line":"                          size\u003dsrc_size - 1,"},{"line_number":47,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_018ff523","line":44,"updated":"2016-06-28 14:16:23.000000000","message":"This should be a separate negative test case","commit_id":"87e13a3944a6e37369e94d450db1e4ab79d06ed1"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0808bb9afbd8e9e78513fd34732b7e76c0a505ff","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Should allow"},{"line_number":39,"context_line":"        self.assertEqual(volume[\u0027source_volid\u0027], src_vol[\u0027id\u0027])"},{"line_number":40,"context_line":"        self.assertEqual(int(volume[\u0027size\u0027]), src_size + 1)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class VolumesV1CloneTest(VolumesCloneTest):"},{"line_number":44,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_4146b27b","line":41,"updated":"2016-06-30 10:05:40.000000000","message":"Why you don\u0027t create cleanup for you resource?","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"875e7dd1d8d251cde38357b14bb0f369ceeb852a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        # Should allow"},{"line_number":39,"context_line":"        self.assertEqual(volume[\u0027source_volid\u0027], src_vol[\u0027id\u0027])"},{"line_number":40,"context_line":"        self.assertEqual(int(volume[\u0027size\u0027]), src_size + 1)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class VolumesV1CloneTest(VolumesCloneTest):"},{"line_number":44,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_0d197888","line":41,"in_reply_to":"3aaa91ec_4146b27b","updated":"2016-06-30 12:02:22.000000000","message":"self.create_volume() adds the created volume to a list and that is cleaned up by the base.BaseVolumeTest.teardown() method.","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"}],"tempest/api/volume/test_volumes_clone_negative.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dfb0a7c02333232c0b391d939e41d8684079ba32","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class VolumesCloneTest(base.BaseVolumeTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    @test.idempotent_id(\u00279adae371-a257-43a5-459a-dc7c88e66e0e\u0027)"},{"line_number":28,"context_line":"    def test_create_from_volume_negative(self):"},{"line_number":29,"context_line":"        # Creates a volume from another volume passing a size different from"},{"line_number":30,"context_line":"        # the source volume."},{"line_number":31,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_6d2e2044","line":28,"updated":"2016-06-30 19:52:25.000000000","message":"this really isn\u0027t a descriptive name. Something like:\n\ntest_create_from_volume_shrink\n\nwould be a bit better. If for some reason we were to add another negative test about volume cloning this could be an issue","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0808bb9afbd8e9e78513fd34732b7e76c0a505ff","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                          self.volumes_client.create_volume,"},{"line_number":37,"context_line":"                          size\u003dsrc_size - 1,"},{"line_number":38,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumesV1CloneTest(VolumesCloneTest):"},{"line_number":42,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_c129029d","line":39,"updated":"2016-06-30 10:05:40.000000000","message":"the same","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"875e7dd1d8d251cde38357b14bb0f369ceeb852a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                          self.volumes_client.create_volume,"},{"line_number":37,"context_line":"                          size\u003dsrc_size - 1,"},{"line_number":38,"context_line":"                          source_volid\u003dsrc_vol[\u0027id\u0027])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class VolumesV1CloneTest(VolumesCloneTest):"},{"line_number":42,"context_line":"    _api_version \u003d 1"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_2d14344b","line":39,"in_reply_to":"3aaa91ec_c129029d","updated":"2016-06-30 12:02:22.000000000","message":"self.create_volume() adds the created volume to a list and that is cleaned up by the base.BaseVolumeTest.teardown() method.","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"}],"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"554521471685d2b0fe644935b58565d2a92819e5","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        self.assertEqual(int(volume[\u0027size\u0027]), src_size + 1)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        # Destination volume smaller than source"},{"line_number":197,"context_line":"        self.assertRaises(exceptions.BadRequest,"},{"line_number":198,"context_line":"                          self.volumes_client.create_volume,"},{"line_number":199,"context_line":"                          size\u003dsrc_size - 1,"},{"line_number":200,"context_line":"                          snapshot_id\u003dsrc_snap[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_a149c1b9","line":197,"updated":"2016-06-28 14:16:23.000000000","message":"This should be a separate negative test case","commit_id":"87e13a3944a6e37369e94d450db1e4ab79d06ed1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dfb0a7c02333232c0b391d939e41d8684079ba32","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":180,"context_line":"    def test_volume_from_snapshot(self):"},{"line_number":181,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":182,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":185,"context_line":"        src_snap \u003d self.create_snapshot(src_vol[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_adc808a9","line":182,"updated":"2016-06-30 19:52:25.000000000","message":"fwiw, you don\u0027t need to do this anymore since you\u0027re not shrinking in this test anymore.","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0808bb9afbd8e9e78513fd34732b7e76c0a505ff","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # Should allow"},{"line_number":192,"context_line":"        self.assertEqual(volume[\u0027snapshot_id\u0027], src_snap[\u0027id\u0027])"},{"line_number":193,"context_line":"        self.assertEqual(int(volume[\u0027size\u0027]), src_size + 1)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @test.idempotent_id(\u0027db4d8e0a-7a2e-41cc-a712-961f6844e896\u0027)"},{"line_number":196,"context_line":"    def test_snapshot_list_param_limit(self):"},{"line_number":197,"context_line":"        # List returns limited elements"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_2c00bd00","line":194,"updated":"2016-06-30 10:05:40.000000000","message":"the same","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"875e7dd1d8d251cde38357b14bb0f369ceeb852a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        # Should allow"},{"line_number":192,"context_line":"        self.assertEqual(volume[\u0027snapshot_id\u0027], src_snap[\u0027id\u0027])"},{"line_number":193,"context_line":"        self.assertEqual(int(volume[\u0027size\u0027]), src_size + 1)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    @test.idempotent_id(\u0027db4d8e0a-7a2e-41cc-a712-961f6844e896\u0027)"},{"line_number":196,"context_line":"    def test_snapshot_list_param_limit(self):"},{"line_number":197,"context_line":"        # List returns limited elements"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_88143644","line":194,"in_reply_to":"3aaa91ec_2c00bd00","updated":"2016-06-30 12:02:22.000000000","message":"self.create_volume() adds the created volume to a list and that is cleaned up by the base.BaseVolumeTest.teardown() method.","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"}],"tempest/api/volume/test_volumes_snapshots_negative.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"dfb0a7c02333232c0b391d939e41d8684079ba32","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                          volume_id\u003dNone, display_name\u003ds_name)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @test.idempotent_id(\u0027677863d1-34f9-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":50,"context_line":"    def test_volume_from_snapshot_negative(self):"},{"line_number":51,"context_line":"        # Creates a volume a snapshot passing a size different from the source"},{"line_number":52,"context_line":"        src_size \u003d CONF.volume.volume_size + 1"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_2dc7f864","line":50,"updated":"2016-06-30 19:52:25.000000000","message":"This also is not a descriptive name, this should be \n\ntest_volume_from_snapshot_shrink\n\nor something describing what the test is actually doing","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0808bb9afbd8e9e78513fd34732b7e76c0a505ff","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":55,"context_line":"        src_snap \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Destination volume smaller than source"},{"line_number":58,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":59,"context_line":"                          self.volumes_client.create_volume,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_6c06451d","line":56,"updated":"2016-06-30 10:05:40.000000000","message":"the same","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"875e7dd1d8d251cde38357b14bb0f369ceeb852a","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        src_vol \u003d self.create_volume(size\u003dsrc_size)"},{"line_number":55,"context_line":"        src_snap \u003d self.create_snapshot(src_vol[\u0027id\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Destination volume smaller than source"},{"line_number":58,"context_line":"        self.assertRaises(lib_exc.BadRequest,"},{"line_number":59,"context_line":"                          self.volumes_client.create_volume,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_a8177243","line":56,"in_reply_to":"3aaa91ec_6c06451d","updated":"2016-06-30 12:02:22.000000000","message":"self.create_volume() adds the created volume to a list and that is cleaned up by the base.BaseVolumeTest.teardown() method.","commit_id":"24255c1d1768963302de22fad6eae8e3e6bd8a3b"}]}