)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ba2bd73514c383d1f2b597eae30bb47ec3ecfa5a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-05-05 10:17:03 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding documentation to the following functions:"},{"line_number":8,"context_line":"_create_network_resources and setup_credentials"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id0f0043007175155c5c4eae3795b9439d980fdeb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dab17558_da4cf478","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":47},"updated":"2016-05-06 00:44:25.000000000","message":"a blank line is necessary after the title as the guideline.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\"Insert a single blank line after the first line.\"","commit_id":"cdcc9b54c7648053f0edd1473145ef0a2edb054d"}],"tempest/common/dynamic_creds.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cc4adb6ee8f52818e7bc7388217892cab4b4cb35","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _create_network_resources(self, tenant_id):"},{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        The function checks if network_resources class memeber is empty, in case it is,"},{"line_number":159,"context_line":"        it will create a network, subnet and router for the given tenant."},{"line_number":160,"context_line":"        otherwise it will create a specific resource that is given with the True value"},{"line_number":161,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d8e69baf","line":158,"updated":"2016-05-03 09:14:28.000000000","message":"member","commit_id":"e73e3512733c0da6dab6e4a44bba59b20f92442f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cc4adb6ee8f52818e7bc7388217892cab4b4cb35","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \"\"\""},{"line_number":158,"context_line":"        The function checks if network_resources class memeber is empty, in case it is,"},{"line_number":159,"context_line":"        it will create a network, subnet and router for the given tenant."},{"line_number":160,"context_line":"        otherwise it will create a specific resource that is given with the True value"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        :param tenant_id : The tenant id to create resources for."},{"line_number":163,"context_line":"        :type tenant_id: str"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_38f86f49","line":160,"updated":"2016-05-03 09:14:28.000000000","message":"capital o\n\nAlso I am not sure I understand the last line. \"a specific resource that is given with the True value\". The only thing that can be given to the function is a tenant_id.","commit_id":"e73e3512733c0da6dab6e4a44bba59b20f92442f"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3d3eec15eb3cadfd0c62bbe6eaf0a1c0751e3014","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def _create_network_resources(self, tenant_id):"},{"line_number":157,"context_line":"        \"\"\"The function checks if network_resources class member is empty."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        In case it is, it will create a network, subnet and router for"},{"line_number":160,"context_line":"        the tenant according to the given tenant id parameter."},{"line_number":161,"context_line":"        Otherwise it will create a specific network resource that"},{"line_number":162,"context_line":"        is given with the True value from network_resources dict."}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_890de037","line":159,"range":{"start_line":159,"start_character":49,"end_line":159,"end_character":66},"updated":"2016-05-03 21:00:35.000000000","message":"a subnet and a router","commit_id":"0bfda614fdfa91f284801b2839f40dba4a599b75"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3d3eec15eb3cadfd0c62bbe6eaf0a1c0751e3014","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        In case it is, it will create a network, subnet and router for"},{"line_number":160,"context_line":"        the tenant according to the given tenant id parameter."},{"line_number":161,"context_line":"        Otherwise it will create a specific network resource that"},{"line_number":162,"context_line":"        is given with the True value from network_resources dict."},{"line_number":163,"context_line":"        :param tenant_id : The tenant id to create resources for."},{"line_number":164,"context_line":"        :type tenant_id: str"},{"line_number":165,"context_line":"        :raises: InvalidConfiguration, Exception"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_094f106b","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":36},"updated":"2016-05-03 21:00:35.000000000","message":"The meaning is not clear.","commit_id":"0bfda614fdfa91f284801b2839f40dba4a599b75"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3d3eec15eb3cadfd0c62bbe6eaf0a1c0751e3014","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        the tenant according to the given tenant id parameter."},{"line_number":161,"context_line":"        Otherwise it will create a specific network resource that"},{"line_number":162,"context_line":"        is given with the True value from network_resources dict."},{"line_number":163,"context_line":"        :param tenant_id : The tenant id to create resources for."},{"line_number":164,"context_line":"        :type tenant_id: str"},{"line_number":165,"context_line":"        :raises: InvalidConfiguration, Exception"},{"line_number":166,"context_line":"        :returns: network resources(network,subnet,router)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_ee80da8d","line":163,"range":{"start_line":163,"start_character":24,"end_line":163,"end_character":25},"updated":"2016-05-03 21:00:35.000000000","message":"space?","commit_id":"0bfda614fdfa91f284801b2839f40dba4a599b75"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ba2bd73514c383d1f2b597eae30bb47ec3ecfa5a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        return cred_provider.TestResources(creds)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def _create_network_resources(self, tenant_id):"},{"line_number":157,"context_line":"        \"\"\"The function checks if network_resources class member is empty."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        In case it is, it will create a network, a subnet and a router for"},{"line_number":160,"context_line":"        the tenant according to the given tenant id parameter."}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_a6675c24","line":157,"range":{"start_line":157,"start_character":11,"end_line":157,"end_character":74},"updated":"2016-05-06 00:44:25.000000000","message":"This is not main purpose of this method.\n\nThis method creates network resources(network, subnet, router) as the method name.","commit_id":"cdcc9b54c7648053f0edd1473145ef0a2edb054d"}],"tempest/test.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"cc4adb6ee8f52818e7bc7388217892cab4b4cb35","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @classmethod"},{"line_number":352,"context_line":"    def setup_credentials(cls):"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        For every element of credentials class member creates"},{"line_number":355,"context_line":"        tenant and/or user role."},{"line_number":356,"context_line":"        For network related tests need to set network resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d8421b68","line":353,"updated":"2016-05-03 09:14:28.000000000","message":"I am not sure this wording is better than the previous one. I don\"t think you should change that docstring.","commit_id":"e73e3512733c0da6dab6e4a44bba59b20f92442f"},{"author":{"_account_id":21082,"name":"Eyal Dannon","email":"edannon@redhat.com","username":"edannon"},"change_message_id":"06cf0459aac175312f40a13f8554cee87034e754","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @classmethod"},{"line_number":352,"context_line":"    def setup_credentials(cls):"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        For every element of credentials class member creates"},{"line_number":355,"context_line":"        tenant and/or user role."},{"line_number":356,"context_line":"        For network related tests need to set network resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_e3fc8c74","line":353,"in_reply_to":"1a122d0e_d8421b68","updated":"2016-05-03 09:52:03.000000000","message":"What is written is not 100% correct, when function runs tenants and users for the tenants are created, and we didn\u0027t understand from the given description that this is what going to happen, that\u0027s why we edit.\nthanks","commit_id":"e73e3512733c0da6dab6e4a44bba59b20f92442f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"685ebb14962609c00f460743fa535e9717156d8b","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    @classmethod"},{"line_number":352,"context_line":"    def setup_credentials(cls):"},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        For every element of credentials class member creates"},{"line_number":355,"context_line":"        tenant and/or user role."},{"line_number":356,"context_line":"        For network related tests need to set network resource"},{"line_number":357,"context_line":"        values to False before calling this function"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_12f8efc3","line":354,"updated":"2016-05-03 11:06:56.000000000","message":"You should not start a doc string with new line.","commit_id":"b0510677b9bfedfb22cd6e765b5b15b3a5a4dfb4"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"8f65f474eb79d7e5a5735a84e9ee0ec716c9212d","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        \"\"\"Allocate credentials and create the client managers from them."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        For every element of credentials param function creates tenant/user"},{"line_number":356,"context_line":"        Then it creates client manager for that credential"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        For network related tests need to set network resource"},{"line_number":359,"context_line":"        values to False before calling this function"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_49ad889a","line":356,"updated":"2016-05-03 21:06:25.000000000","message":"Adding this paragraph makes sense as it is related to the purpose of the function. But I don\u0027t think the later paragraph has better explanation than old one.","commit_id":"0bfda614fdfa91f284801b2839f40dba4a599b75"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3d3eec15eb3cadfd0c62bbe6eaf0a1c0751e3014","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        \"\"\"Allocate credentials and create the client managers from them."},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        For every element of credentials param function creates tenant/user"},{"line_number":356,"context_line":"        Then it creates client manager for that credential"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        For network related tests need to set network resource"},{"line_number":359,"context_line":"        values to False before calling this function"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_e9bd7403","line":356,"range":{"start_line":356,"start_character":48,"end_line":356,"end_character":58},"updated":"2016-05-03 21:00:35.000000000","message":"tenant maybe?","commit_id":"0bfda614fdfa91f284801b2839f40dba4a599b75"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"3d3eec15eb3cadfd0c62bbe6eaf0a1c0751e3014","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        For every element of credentials param function creates tenant/user"},{"line_number":356,"context_line":"        Then it creates client manager for that credential"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        For network related tests need to set network resource"},{"line_number":359,"context_line":"        values to False before calling this function"},{"line_number":360,"context_line":"        because network resources are created in a later step."},{"line_number":361,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_295dacec","line":358,"range":{"start_line":358,"start_character":8,"end_line":358,"end_character":62},"updated":"2016-05-03 21:00:35.000000000","message":"Network related tests need","commit_id":"0bfda614fdfa91f284801b2839f40dba4a599b75"}]}