)]}'
{"tempest/services/network/json/routers_client.py":[{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"c4e61afa274d3c031c437e1136ca515ae712e55b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        uri \u003d \u0027/routers\u0027"},{"line_number":26,"context_line":"        return self.create_resource(uri, post_body)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _update_router(self, router_id, set_enable_snat, **kwargs):"},{"line_number":29,"context_line":"        uri \u003d \u0027/routers/%s\u0027 % router_id"},{"line_number":30,"context_line":"        body \u003d self.show_resource(uri)"},{"line_number":31,"context_line":"        update_body \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1566c2ba","side":"PARENT","line":28,"updated":"2016-05-05 04:59:22.000000000","message":"_update_router is also used in \nhttps://github.com/openstack/tempest/blob/master/tempest/cmd/javelin.py#L883","commit_id":"0e8d73f482e2aab14d75edad8dcd6358a5ae8e27"},{"author":{"_account_id":12024,"name":"Tong Liu","email":"tongl@vmware.com","username":"tong101"},"change_message_id":"c4e61afa274d3c031c437e1136ca515ae712e55b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        uri \u003d \u0027/routers\u0027"},{"line_number":26,"context_line":"        return self.create_resource(uri, post_body)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def update_router(self, router_id, **kwargs):"},{"line_number":29,"context_line":"        uri \u003d \u0027/routers/%s\u0027 % router_id"},{"line_number":30,"context_line":"        update_body \u003d {\u0027router\u0027: kwargs}"},{"line_number":31,"context_line":"        return self.update_resource(uri, update_body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_b5ac2e89","line":28,"updated":"2016-05-05 04:59:22.000000000","message":"The update behavior may not be as desired as old version. Previously, it explicitly set enable_snat to False if not set.","commit_id":"a9921c241d5d29054b872810c9f7e3a6f6d07a41"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"513a852d6c4be2da83d4e152c801ed66c50e10d2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        uri \u003d \u0027/routers\u0027"},{"line_number":26,"context_line":"        return self.create_resource(uri, post_body)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def update_router(self, router_id, **kwargs):"},{"line_number":29,"context_line":"        uri \u003d \u0027/routers/%s\u0027 % router_id"},{"line_number":30,"context_line":"        update_body \u003d {\u0027router\u0027: kwargs}"},{"line_number":31,"context_line":"        return self.update_resource(uri, update_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_0356c25b","line":28,"updated":"2016-05-30 15:13:40.000000000","message":"There\u0027s a fair amount of logic which is removed here. That\u0027s geat because the code is now much simplet. Question is: won\u0027t this break the world ?","commit_id":"8d8824a2af8200f39af2acdf01c80ebfd8d50c64"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2623fd0bcb80852fc35737398de5df20a1c5b6ec","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        uri \u003d \u0027/routers\u0027"},{"line_number":26,"context_line":"        return self.create_resource(uri, post_body)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def update_router(self, router_id, **kwargs):"},{"line_number":29,"context_line":"        uri \u003d \u0027/routers/%s\u0027 % router_id"},{"line_number":30,"context_line":"        update_body \u003d {\u0027router\u0027: kwargs}"},{"line_number":31,"context_line":"        return self.update_resource(uri, update_body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_f77374e5","line":28,"in_reply_to":"9abb7d3a_0356c25b","updated":"2016-05-30 16:42:18.000000000","message":"Hehe, nice point.\n\nTBH, I guess current patch would break the gate.\nHowever, this patch can be passed the gate as we see.\n\nIn addition, this routers_client module is not under tempest.lib, that means not stable interface.\nSo even if some projects are using this module as stable interface and this patch breaks them, that is not a matter.","commit_id":"8d8824a2af8200f39af2acdf01c80ebfd8d50c64"}]}