)]}'
{"tempest/services/identity/v3/json/projects_client.py":[{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"1fe8109fedaeb95cfd2a4632ca86b174179ddd6d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, None)"},{"line_number":28,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, True)"},{"line_number":29,"context_line":"        domain_id \u003d kwargs.get(\u0027domain_id\u0027, \u0027default\u0027)"},{"line_number":30,"context_line":"        parent_id \u003d kwargs.get(\u0027parent_id\u0027, None)"},{"line_number":31,"context_line":"        post_body \u003d {"},{"line_number":32,"context_line":"            \u0027description\u0027: description,"},{"line_number":33,"context_line":"            \u0027domain_id\u0027: domain_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_c06035a7","line":30,"updated":"2016-05-13 15:17:21.000000000","message":"don\u0027t really need the 2nd parameter - get will return None if the key doesn\u0027t exist","commit_id":"df4b86d4bf00f2c2611ad64bc2f4785368ec775e"},{"author":{"_account_id":9234,"name":"Steve Heyman","email":"steve@heyman.com","username":"hockeynut"},"change_message_id":"868d82782ec5a1ac1748e1f1f0ef2803d51baacb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, None)"},{"line_number":28,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, True)"},{"line_number":29,"context_line":"        domain_id \u003d kwargs.get(\u0027domain_id\u0027, \u0027default\u0027)"},{"line_number":30,"context_line":"        parent_id \u003d kwargs.get(\u0027parent_id\u0027, None)"},{"line_number":31,"context_line":"        post_body \u003d {"},{"line_number":32,"context_line":"            \u0027description\u0027: description,"},{"line_number":33,"context_line":"            \u0027domain_id\u0027: domain_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_83ec77f4","line":30,"in_reply_to":"dab17558_c06035a7","updated":"2016-05-13 15:34:19.000000000","message":"If we ever refactor here then we can fix this.","commit_id":"df4b86d4bf00f2c2611ad64bc2f4785368ec775e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a1976a87635ffe3c29a2e37e0dfb480c4282dcd5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_project(self, name, **kwargs):"},{"line_number":26,"context_line":"        \"\"\"Creates a project.\"\"\""},{"line_number":27,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, None)"},{"line_number":28,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, True)"},{"line_number":29,"context_line":"        domain_id \u003d kwargs.get(\u0027domain_id\u0027, \u0027default\u0027)"},{"line_number":30,"context_line":"        parent_id \u003d kwargs.get(\u0027parent_id\u0027, None)"},{"line_number":31,"context_line":"        post_body \u003d {"},{"line_number":32,"context_line":"            \u0027description\u0027: description,"},{"line_number":33,"context_line":"            \u0027domain_id\u0027: domain_id,"},{"line_number":34,"context_line":"            \u0027enabled\u0027: en,"},{"line_number":35,"context_line":"            \u0027name\u0027: name,"},{"line_number":36,"context_line":"            \u0027parent_id\u0027: parent_id"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":"        post_body \u003d json.dumps({\u0027project\u0027: post_body})"},{"line_number":39,"context_line":"        resp, body \u003d self.post(\u0027projects\u0027, post_body)"},{"line_number":40,"context_line":"        self.expected_success(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_76ac418c","line":37,"range":{"start_line":27,"start_character":0,"end_line":37,"end_character":9},"updated":"2016-05-17 08:46:09.000000000","message":"How about passing kwargs directly like\n\n post_body \u003d json.dumps({\u0027project\u0027: kwargs})\n\n?\nThe other service clients are doing this to avoid this kind of change on service client side.","commit_id":"df4b86d4bf00f2c2611ad64bc2f4785368ec775e"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"1c1b89fdca6076f49250ae8d8174d3c9689715d4","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def create_project(self, name, **kwargs):"},{"line_number":26,"context_line":"        \"\"\"Creates a project.\"\"\""},{"line_number":27,"context_line":"        description \u003d kwargs.get(\u0027description\u0027, None)"},{"line_number":28,"context_line":"        en \u003d kwargs.get(\u0027enabled\u0027, True)"},{"line_number":29,"context_line":"        domain_id \u003d kwargs.get(\u0027domain_id\u0027, \u0027default\u0027)"},{"line_number":30,"context_line":"        parent_id \u003d kwargs.get(\u0027parent_id\u0027, None)"},{"line_number":31,"context_line":"        post_body \u003d {"},{"line_number":32,"context_line":"            \u0027description\u0027: description,"},{"line_number":33,"context_line":"            \u0027domain_id\u0027: domain_id,"},{"line_number":34,"context_line":"            \u0027enabled\u0027: en,"},{"line_number":35,"context_line":"            \u0027name\u0027: name,"},{"line_number":36,"context_line":"            \u0027parent_id\u0027: parent_id"},{"line_number":37,"context_line":"        }"},{"line_number":38,"context_line":"        post_body \u003d json.dumps({\u0027project\u0027: post_body})"},{"line_number":39,"context_line":"        resp, body \u003d self.post(\u0027projects\u0027, post_body)"},{"line_number":40,"context_line":"        self.expected_success(201, resp.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_08b1e68f","line":37,"range":{"start_line":27,"start_character":0,"end_line":37,"end_character":9},"in_reply_to":"dab17558_76ac418c","updated":"2016-05-18 20:24:36.000000000","message":"That is a good idea Kenichi. I have reviewed the API documentation http://developer.openstack.org/api-ref-identity-v3.html#createProject and looks like the values that are being set up here in the post_body are the default values in the API anyway, so there is no benefit on manually assigning them here. I will fix it in a new patch.","commit_id":"df4b86d4bf00f2c2611ad64bc2f4785368ec775e"},{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"45016ae5546cc9000091ca41358938fba890ec40","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        # Include the project name to the kwargs parameters"},{"line_number":33,"context_line":"        kwargs[\u0027name\u0027] \u003d name"},{"line_number":34,"context_line":"        post_body \u003d json.dumps({\u0027project\u0027: kwargs})"},{"line_number":35,"context_line":"        resp, body \u003d self.post(\u0027projects\u0027, post_body)"},{"line_number":36,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":37,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_225b1a30","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":51},"updated":"2016-05-19 04:11:21.000000000","message":"Although they are optional will the response (created project) have any issues since default values for some of the parameters will not be provided?","commit_id":"43cee11d9b7a5b99f3769e34bb64a5101fd635e4"},{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"908d759bcbedd3693188ad211547b0b8e403d145","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        # Include the project name to the kwargs parameters"},{"line_number":33,"context_line":"        kwargs[\u0027name\u0027] \u003d name"},{"line_number":34,"context_line":"        post_body \u003d json.dumps({\u0027project\u0027: kwargs})"},{"line_number":35,"context_line":"        resp, body \u003d self.post(\u0027projects\u0027, post_body)"},{"line_number":36,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":37,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_d9582335","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":51},"in_reply_to":"bab6814e_225b1a30","updated":"2016-05-19 14:45:33.000000000","message":"No, new projects will have the values not provided filled up with the default values. You can see what are the default values here:  http://developer.openstack.org/api-ref-identity-v3.html#createProject","commit_id":"43cee11d9b7a5b99f3769e34bb64a5101fd635e4"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"9273e9373b0c034f4a2e77c0dbea205a9c7dbdce","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"\"\""},{"line_number":32,"context_line":"        # Include the project name to the kwargs parameters"},{"line_number":33,"context_line":"        kwargs[\u0027name\u0027] \u003d name"},{"line_number":34,"context_line":"        post_body \u003d json.dumps({\u0027project\u0027: kwargs})"},{"line_number":35,"context_line":"        resp, body \u003d self.post(\u0027projects\u0027, post_body)"},{"line_number":36,"context_line":"        self.expected_success(201, resp.status)"},{"line_number":37,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_f5472e49","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":51},"in_reply_to":"bab6814e_d9582335","updated":"2016-05-24 11:35:00.000000000","message":"This is a change in behaviour for the domain. It use to default to \u0027default\u0027 if not provided, now it defaults to the API default, which is \"the domain to which your token is scoped\".\n\nIt\u0027s a good change to have, but one worth noting.","commit_id":"43cee11d9b7a5b99f3769e34bb64a5101fd635e4"}]}