)]}'
{"tempest/api/volume/admin/test_multi_backend_migrate.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"16ec9fb7e6c7989ef7438370aa9e059071c71e81","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    @classmethod"},{"line_number":67,"context_line":"    def _verify_backend_name(cls, backend_name):"},{"line_number":68,"context_line":"        \"\"\"To verify that backend name exists in tempest.conf \"\"\""},{"line_number":69,"context_line":"        if backend_name not in cls.backend_names:"},{"line_number":70,"context_line":"            raise cls.skipException("},{"line_number":71,"context_line":"                \"Backend name does not exist in CONF.volume.backend_names\")"},{"line_number":72,"context_line":"        return backend_name"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_types_for_backend(cls):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_5881ff8e","line":72,"range":{"start_line":69,"start_character":0,"end_line":72,"end_character":27},"updated":"2016-05-24 16:14:48.000000000","message":"I guess it would be fine to skip backend which don\u0027t exist in CONF.volume.backend_names instead of the test is skipped because testers would run tests for several backends only sometimes.","commit_id":"e7b916da95e12d46073a347341163f662dfbac30"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"925aff4faca078ad1003ceaa20ee5085196e8102","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_types_for_backend(cls):"},{"line_number":76,"context_line":"        \"\"\"Types creation for each cinder backend. \"\"\""},{"line_number":77,"context_line":"        for volume_info in cls.volumes_info:"},{"line_number":78,"context_line":"            vol_type \u003d cls.volume_types_client.create_volume_type("},{"line_number":79,"context_line":"                name\u003dvolume_info[\u0027volume_type_name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_a9942e44","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":8},"updated":"2016-05-24 13:24:01.000000000","message":"Please use list comprehension:\n\ncls.volume_type_list \u003d [\n            cls.volume_types_client.create_volume_type(\n                name\u003dvolume_info[\u0027volume_type_name\u0027],\n                extra_specs\u003d{\n                    \"volume_backend_name\": volume_info[\u0027backend_name\u0027]\n                })[\u0027volume_type\u0027][\u0027id\u0027]\n            for volume_info in cls.volumes_info\n            ]","commit_id":"e7b916da95e12d46073a347341163f662dfbac30"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"1b3ad24e5421b784ce966efe83ec0d02e1193cf1","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @classmethod"},{"line_number":75,"context_line":"    def _create_types_for_backend(cls):"},{"line_number":76,"context_line":"        \"\"\"Types creation for each cinder backend. \"\"\""},{"line_number":77,"context_line":"        for volume_info in cls.volumes_info:"},{"line_number":78,"context_line":"            vol_type \u003d cls.volume_types_client.create_volume_type("},{"line_number":79,"context_line":"                name\u003dvolume_info[\u0027volume_type_name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_644ee4c2","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":8},"in_reply_to":"bab6814e_a9942e44","updated":"2016-05-24 15:19:32.000000000","message":"Hi Liron , \nthe cls.volume_type_list is already initialized in resource_setup , we dont need to initialize it again , probably use append on existing object.","commit_id":"e7b916da95e12d46073a347341163f662dfbac30"}]}