)]}'
{"tempest/api/volume/admin/test_volume_services.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b02dd5c05f45297586dec0f1add7f09a1be55af","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @test.idempotent_id(\u00274847a171-6b1c-43f4-8abd-c51139a86e7f\u0027)"},{"line_number":87,"context_line":"    def test_disable_enable_cinder_volumes_service(self):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        services \u003d [service for service in"},{"line_number":90,"context_line":"                    self.admin_volume_services_client."},{"line_number":91,"context_line":"                    list_services(binary\u003d\u0027cinder-volume\u0027)[\u0027services\u0027]"},{"line_number":92,"context_line":"                    if service[\u0027state\u0027] \u003d\u003d \u0027up\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_7d25dc5a","line":89,"updated":"2016-05-24 14:13:53.000000000","message":"Why do you have to perform a disable/enable service on every volume services ? Why not just the first one ?\n\nThis test is going to take some time on a production cloud with 10s of cinder-volumes.","commit_id":"76c1dcf1615b2aa977ba94a587b211341b52acc4"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"eb08efb79747caade869d3bf99ff9e4b620e46b9","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    @test.idempotent_id(\u00274847a171-6b1c-43f4-8abd-c51139a86e7f\u0027)"},{"line_number":87,"context_line":"    def test_disable_enable_cinder_volumes_service(self):"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        services \u003d [service for service in"},{"line_number":90,"context_line":"                    self.admin_volume_services_client."},{"line_number":91,"context_line":"                    list_services(binary\u003d\u0027cinder-volume\u0027)[\u0027services\u0027]"},{"line_number":92,"context_line":"                    if service[\u0027state\u0027] \u003d\u003d \u0027up\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_beb45bd1","line":89,"in_reply_to":"bab6814e_7d25dc5a","updated":"2016-05-24 14:43:10.000000000","message":"ok , will fix it  \nBenny","commit_id":"76c1dcf1615b2aa977ba94a587b211341b52acc4"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b8c5e8142c30f3232ea836c8c2c012e688b3b018","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @test.idempotent_id(\u00274847a171-6b1c-43f4-8abd-c51139a86e7f\u0027)"},{"line_number":88,"context_line":"    def test_disable_enable_cinder_volumes_service(self):"},{"line_number":89,"context_line":"        # handle parallel running , to lock the test"},{"line_number":90,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027cinder_volumes_service_disable\u0027))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        services \u003d [service for service in"},{"line_number":93,"context_line":"                    self.admin_volume_services_client."}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_e3c0de7e","line":90,"updated":"2016-05-30 15:06:10.000000000","message":"Will this lock prevent any test that operates on cinder volume to run at the same time as this test ?\n\nOr will this just prevent only this test to be run in twice at the same time ?","commit_id":"725dc27a12f40d631fa2702ee3be3c5456e2c2c9"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"fc3243fa25549455b34252b8ec99b5dea234c765","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @test.idempotent_id(\u00274847a171-6b1c-43f4-8abd-c51139a86e7f\u0027)"},{"line_number":88,"context_line":"    def test_disable_enable_cinder_volumes_service(self):"},{"line_number":89,"context_line":"        # handle parallel running , to lock the test"},{"line_number":90,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027cinder_volumes_service_disable\u0027))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        services \u003d [service for service in"},{"line_number":93,"context_line":"                    self.admin_volume_services_client."}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_72f00968","line":90,"in_reply_to":"9abb7d3a_a65c24ee","updated":"2016-05-31 12:45:45.000000000","message":"This kind of test would be safe to run only if we would do aquire the lock in all cinder related test (or in all tempest test). We do not want to do this.","commit_id":"725dc27a12f40d631fa2702ee3be3c5456e2c2c9"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"7ad18e2cef0e72685795f8408b4317b02044f278","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @test.idempotent_id(\u00274847a171-6b1c-43f4-8abd-c51139a86e7f\u0027)"},{"line_number":88,"context_line":"    def test_disable_enable_cinder_volumes_service(self):"},{"line_number":89,"context_line":"        # handle parallel running , to lock the test"},{"line_number":90,"context_line":"        self.useFixture(fixtures.LockFixture(\u0027cinder_volumes_service_disable\u0027))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        services \u003d [service for service in"},{"line_number":93,"context_line":"                    self.admin_volume_services_client."}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_a65c24ee","line":90,"in_reply_to":"9abb7d3a_e3c0de7e","updated":"2016-05-30 15:24:28.000000000","message":"Hi Jordon , \nI am not running parallel testings , i took an example from here :\nhttp://docs.openstack.org/developer/oslo.concurrency/api/fixture.lockutils.html","commit_id":"725dc27a12f40d631fa2702ee3be3c5456e2c2c9"}],"tempest/services/volume/base/admin/base_services_client.py":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"ef558e1e4e8423d488ec624ca3b6866387f0d974","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def enable_service(self, **kwargs):"},{"line_number":35,"context_line":"        # Enable cinder service on a host."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        post_body \u003d json.dumps(kwargs)"},{"line_number":38,"context_line":"        resp, body \u003d self.put(\u0027os-services/enable\u0027, post_body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c4fbac77","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":42},"updated":"2016-05-23 07:42:16.000000000","message":"Could you please change the docstring as recommended in here?\n\nhttp://docs.openstack.org/developer/hacking/#docstrings","commit_id":"407462faae37b2f4d4a0930b636748457668aa26"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"ef558e1e4e8423d488ec624ca3b6866387f0d974","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def disable_service(self, **kwargs):"},{"line_number":43,"context_line":"        # Disable service on a host."},{"line_number":44,"context_line":"        post_body \u003d json.dumps(kwargs)"},{"line_number":45,"context_line":"        resp, body \u003d self.put(\u0027os-services/disable\u0027, post_body)"},{"line_number":46,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_8434044a","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":36},"updated":"2016-05-23 07:42:16.000000000","message":"Ditto, plus also the blank space in between. Would you mind making this consistent on the two methods? Thanks!","commit_id":"407462faae37b2f4d4a0930b636748457668aa26"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"804e8d92ec74319ce6b0e74267faab015a3bb98f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \"\"\"Enable cinder service on a host.\"\"\""},{"line_number":36,"context_line":"        post_body \u003d json.dumps(kwargs)"},{"line_number":37,"context_line":"        resp, body \u003d self.put(\u0027os-services/enable\u0027, post_body)"},{"line_number":38,"context_line":"        body \u003d json.loads(body)"},{"line_number":39,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def disable_service(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_f3c61448","line":38,"updated":"2016-05-24 16:22:59.000000000","message":"You should check the status code with self.expected_success(XX)","commit_id":"887876ee60d66dc712544b26904023f6377da2e5"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"804e8d92ec74319ce6b0e74267faab015a3bb98f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        body \u003d json.loads(body)"},{"line_number":39,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def disable_service(self, **kwargs):"},{"line_number":42,"context_line":"        \"\"\"Disable cinder service on a host.\"\"\""},{"line_number":43,"context_line":"        post_body \u003d json.dumps(kwargs)"},{"line_number":44,"context_line":"        resp, body \u003d self.put(\u0027os-services/disable\u0027, post_body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_33c1bc2f","line":41,"updated":"2016-05-24 16:22:59.000000000","message":"same","commit_id":"887876ee60d66dc712544b26904023f6377da2e5"}]}