)]}'
{"tempest/scenario/test_network_advanced_server_ops.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f648694c5d7d30ae62c1983cb960fac28cf33fb7","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def _setup_network_and_servers(self):"},{"line_number":54,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":55,"context_line":"        security_group \u003d None"},{"line_number":56,"context_line":"        if test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027):"},{"line_number":57,"context_line":"            security_group \u003d self._create_security_group()"},{"line_number":58,"context_line":"        security_groups \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_c634644b","line":55,"updated":"2016-06-01 10:41:57.000000000","message":"I suggest:\n\nsecurity_groups \u003d []\nif test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027):\n  security_group \u003d self._create_security_group()\n  security_groups \u003d [{\u0027name\u0027: security_group[\u0027name\u0027]}]\n\n\nI.e you don\"t need to create the \"security_group\" variable in the outer scope. It leads to scope creep.","commit_id":"73746ef3ce7fa3c76236a9c7d813cdded1baa842"}]}