)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d948cbe05a5a0509825ecdccbeb0097431956349","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_32946389","line":25,"updated":"2016-09-08 18:34:10.000000000","message":"If you do that, the DVR job will fail. The test is designed in a way that it does not assume the router to be bound, and that must be revised too.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"5544699cf825de7413aa531f1c86040c66179f3f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_b78d0a7e","line":25,"in_reply_to":"9a89bdaa_0c497660","updated":"2016-09-13 11:25:02.000000000","message":"Ok, I will check it. If it is indeed Mitaka, so I think we should skip the test until Liberty is EOL(2016-11-17 https://releases.openstack.org/) and after that fix the test.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4034f7fe06c1c686a35294f42cf318e027564a09","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_0c497660","line":25,"in_reply_to":"9a89bdaa_1b8b6e69","updated":"2016-09-12 17:17:39.000000000","message":"iirc it changed in Mitaka","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"afec405e72c17b4a8c3fdd1b3416be91a3c8d8db","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_e883ec00","line":25,"in_reply_to":"9a89bdaa_32946389","updated":"2016-09-08 20:32:17.000000000","message":"...unless the DVR logic changed over time.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"9393a17d142f4b9d68a219af19d2be22de991468","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_1b8b6e69","line":25,"in_reply_to":"9a89bdaa_84a1e448","updated":"2016-09-12 16:22:21.000000000","message":"So we need a neutron expert who would tell us when the DVR logic was changed (which release). Maybe the logic was changed in older releases that are EOL.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3effeaee4cbbe2f2ad2ea49b56b417fee526d8a9","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_84a1e448","line":25,"in_reply_to":"9a89bdaa_929f8102","updated":"2016-09-12 16:01:33.000000000","message":"That\u0027s because we only run the DVR job on master.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"8632a245ecf9e8cfa6e425a876865853d1936fcc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a8ec9b2_96825251","line":25,"in_reply_to":"9a89bdaa_b78d0a7e","updated":"2016-09-14 13:04:47.000000000","message":"Armando, you are right. The behaviour was changed since the Mitaka release. I had two envs with Liberty and Mitaka.\n\nLiberty - http://paste.openstack.org/show/574456/\nMitaka - http://paste.openstack.org/show/574455/\n\nSo, let\u0027s skip the test until Liberty is EOL. Guys, what do you think about it?","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"fd35461cdf8fbbfcce660c5df97e93cbbdb86d10","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The full log can be find here http://paste.openstack.org/show/508686/"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"So this patch deletes the code block that makes the router schedule to"},{"line_number":25,"context_line":"the L3 agent to avoid such conflicts."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-Bug: #1590049"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a89bdaa_929f8102","line":25,"in_reply_to":"9a89bdaa_e883ec00","updated":"2016-09-12 09:10:22.000000000","message":"It looks like the DVR logic was changed because the DVR job is green.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"88a54ce056990e1271ddbcf7cb73b90785d77629","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set default value of \u0027dvr_extra_resources\u0027 option to False"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The default value of the option was set to True to support Liberty"},{"line_number":10,"context_line":"which is not supported anymore. So let\u0027s set the default value of"},{"line_number":11,"context_line":"the option to False."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1590049"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"bff0334d_3d87a8da","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":19},"updated":"2017-04-05 16:22:25.000000000","message":"This should be written on a new reno as \"upgrade\".","commit_id":"61d42c7615e08422cbd8ca68c64f2f5ff14916a2"}],"tempest/api/network/admin/test_l3_agent_scheduler.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"4cc6e7891bec45700100463da07ead1640e97600","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        body \u003d self.admin_agents_client.delete_router_from_l3_agent("},{"line_number":141,"context_line":"            self.agent[\u0027id\u0027],"},{"line_number":142,"context_line":"            self.router[\u0027id\u0027])"},{"line_number":143,"context_line":"        # NOTE(afazekas): The deletion not asserted, because neutron"},{"line_number":144,"context_line":"        # is not forbidden to reschedule the router to the same agent"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_678608bb","line":143,"updated":"2016-05-27 12:54:44.000000000","message":"What about this note ?\n\nAfter your call to delete_router_from_l3_agent could Neutron reschedule the router to the same agent ?","commit_id":"5669d3563d6bafdbe50aec97eb45164c957987d2"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"cdce71488a9790db9214b000a09b9b26980b24ee","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    def test_list_routers_on_l3_agent(self):"},{"line_number":73,"context_line":"        self.admin_agents_client.list_routers_on_l3_agent(self.agent[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.idempotent_id(\u00279464e5e7-8625-49c3-8fd1-89c52be59d66\u0027)"},{"line_number":76,"context_line":"    def test_add_list_remove_router_on_l3_agent(self):"},{"line_number":77,"context_line":"        l3_agent_ids \u003d list()"},{"line_number":78,"context_line":"        self.admin_agents_client.create_router_on_l3_agent("}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_6b017f39","line":75,"updated":"2016-09-09 08:02:06.000000000","message":"We should consider removing this test.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ba1258a3f6baf4afb23fd6b169dcf37489204d15","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.admin_agents_client.list_routers_on_l3_agent(self.agent[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.idempotent_id(\u00279464e5e7-8625-49c3-8fd1-89c52be59d66\u0027)"},{"line_number":76,"context_line":"    def test_add_list_remove_router_on_l3_agent(self):"},{"line_number":77,"context_line":"        l3_agent_ids \u003d list()"},{"line_number":78,"context_line":"        self.admin_agents_client.create_router_on_l3_agent("},{"line_number":79,"context_line":"            self.agent[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_d27a5776","line":76,"updated":"2016-09-08 18:33:11.000000000","message":"Rather than removing this setup (which would break the DVR job I suspect) have you considered changing the logic of this test such that you do:\n\n - list\n - remove (if agents not None)\n - add\n - remove (if agent was None)\n\nThis way we get to test what happens  during removal for an unbound router, which adds extra coverage","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"091142039d9723acdb1c9585823b89d6fc487ea3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.admin_agents_client.list_routers_on_l3_agent(self.agent[\u0027id\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @test.idempotent_id(\u00279464e5e7-8625-49c3-8fd1-89c52be59d66\u0027)"},{"line_number":76,"context_line":"    def test_add_list_remove_router_on_l3_agent(self):"},{"line_number":77,"context_line":"        l3_agent_ids \u003d list()"},{"line_number":78,"context_line":"        self.admin_agents_client.create_router_on_l3_agent("},{"line_number":79,"context_line":"            self.agent[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_f221adfd","line":76,"in_reply_to":"9a89bdaa_d27a5776","updated":"2016-09-12 09:08:57.000000000","message":"As far as I understand if auto-scheduling for routers is enabled, it will not help us, because the router will schedule to another L3 agent.","commit_id":"4ae183a18b796cf8864404ad6e96ed2e968574a2"}]}