)]}'
{"tempest/hacking/checks.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"741657e1158afa190f0d60bb215ff86a8276cd01","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    if \u0027tempest/lib/\u0027 not in filename:"},{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if (\u0027tempest.config\u0027 in logical_line"},{"line_number":270,"context_line":"        or \u0027from tempest import config\u0027 in logical_line"},{"line_number":271,"context_line":"        or \u0027oslo_config\u0027 in logical_line):"},{"line_number":272,"context_line":"        msg \u003d (\u0027T114: tempest.lib can not have any dependency on tempest\u0027"},{"line_number":273,"context_line":"               \u0027config.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_16018705","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":55},"updated":"2016-06-01 05:31:07.000000000","message":"These 2 already covered by T112. Or you want to have config one explicitly too ?\n\nHaving here through T112 and T114 both.","commit_id":"1213e58b066478f222c401739a2fc3be83acebde"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a933db033882abd91ac4d9b2fe6287ac2b6e9b61","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    if \u0027tempest/lib/\u0027 not in filename:"},{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if (\u0027tempest.config\u0027 in logical_line"},{"line_number":270,"context_line":"        or \u0027from tempest import config\u0027 in logical_line"},{"line_number":271,"context_line":"        or \u0027oslo_config\u0027 in logical_line):"},{"line_number":272,"context_line":"        msg \u003d (\u0027T114: tempest.lib can not have any dependency on tempest\u0027"},{"line_number":273,"context_line":"               \u0027config.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_880b7423","line":270,"range":{"start_line":269,"start_character":8,"end_line":270,"end_character":55},"in_reply_to":"9abb7d3a_16018705","updated":"2016-06-01 15:33:59.000000000","message":"I think having an explicit config rule is better. Yeah, there is overlap between the this rule and T112, but I think that\u0027s ok. Not using config is part of being the self contained but is really a separate rule.","commit_id":"1213e58b066478f222c401739a2fc3be83acebde"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"741657e1158afa190f0d60bb215ff86a8276cd01","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    register(no_hyphen_at_end_of_rand_name)"},{"line_number":284,"context_line":"    register(no_mutable_default_args)"},{"line_number":285,"context_line":"    register(no_testtools_skip_decorator)"},{"line_number":286,"context_line":"    register(get_resources_on_service_clients)"},{"line_number":287,"context_line":"    register(delete_resources_on_service_clients)"},{"line_number":288,"context_line":"    register(dont_import_local_tempest_into_lib)"},{"line_number":289,"context_line":"    register(use_rand_uuid_instead_of_uuid4)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_d68edf77","line":286,"range":{"start_line":286,"start_character":45,"end_line":286,"end_character":46},"updated":"2016-06-01 05:31:07.000000000","message":"Need to register new T114 here.","commit_id":"1213e58b066478f222c401739a2fc3be83acebde"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"a933db033882abd91ac4d9b2fe6287ac2b6e9b61","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    register(no_hyphen_at_end_of_rand_name)"},{"line_number":284,"context_line":"    register(no_mutable_default_args)"},{"line_number":285,"context_line":"    register(no_testtools_skip_decorator)"},{"line_number":286,"context_line":"    register(get_resources_on_service_clients)"},{"line_number":287,"context_line":"    register(delete_resources_on_service_clients)"},{"line_number":288,"context_line":"    register(dont_import_local_tempest_into_lib)"},{"line_number":289,"context_line":"    register(use_rand_uuid_instead_of_uuid4)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_35aaa119","line":286,"range":{"start_line":286,"start_character":45,"end_line":286,"end_character":46},"in_reply_to":"9abb7d3a_d68edf77","updated":"2016-06-01 15:33:59.000000000","message":"oops, yep. Done","commit_id":"1213e58b066478f222c401739a2fc3be83acebde"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bb0f5d7ec0f5683d9f7b644a7e9ddf291d902c6c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    if \u0027tempest/lib/\u0027 not in filename:"},{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if (\u0027tempest.config\u0027 in logical_line"},{"line_number":270,"context_line":"        or \u0027from tempest import config\u0027 in logical_line"},{"line_number":271,"context_line":"        or \u0027oslo_config\u0027 in logical_line):"},{"line_number":272,"context_line":"        msg \u003d (\u0027T114: tempest.lib can not have any dependency on tempest\u0027"},{"line_number":273,"context_line":"               \u0027config.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_425cc07c","line":270,"range":{"start_line":269,"start_character":0,"end_line":270,"end_character":55},"updated":"2016-06-01 18:53:42.000000000","message":"just comment: These lines can be covered with the existing rule 112, but fine to contain these lines for clear meaning.","commit_id":"d5830bd30a01641a1e31f71a4c93f4b9f9f90188"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"60b030b3b4dfba2e479ba4a6a0d916697a4685e2","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    if \u0027tempest/lib/\u0027 not in filename:"},{"line_number":267,"context_line":"        return"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    if (\u0027tempest.config\u0027 in logical_line"},{"line_number":270,"context_line":"        or \u0027from tempest import config\u0027 in logical_line"},{"line_number":271,"context_line":"        or \u0027oslo_config\u0027 in logical_line):"},{"line_number":272,"context_line":"        msg \u003d (\u0027T114: tempest.lib can not have any dependency on tempest\u0027"},{"line_number":273,"context_line":"               \u0027config.\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_2d152d9b","line":270,"range":{"start_line":269,"start_character":0,"end_line":270,"end_character":55},"in_reply_to":"9abb7d3a_425cc07c","updated":"2016-06-01 19:04:05.000000000","message":"gmann made the same comment on rev 1","commit_id":"d5830bd30a01641a1e31f71a4c93f4b9f9f90188"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bb0f5d7ec0f5683d9f7b644a7e9ddf291d902c6c","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    if (\u0027tempest.config\u0027 in logical_line"},{"line_number":270,"context_line":"        or \u0027from tempest import config\u0027 in logical_line"},{"line_number":271,"context_line":"        or \u0027oslo_config\u0027 in logical_line):"},{"line_number":272,"context_line":"        msg \u003d (\u0027T114: tempest.lib can not have any dependency on tempest\u0027"},{"line_number":273,"context_line":"               \u0027config.\u0027)"},{"line_number":274,"context_line":"        yield(0, msg)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_a2d48ceb","line":272,"range":{"start_line":272,"start_character":65,"end_line":272,"end_character":72},"updated":"2016-06-01 18:53:42.000000000","message":"need a space after \"tempest\"","commit_id":"d5830bd30a01641a1e31f71a4c93f4b9f9f90188"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"60b030b3b4dfba2e479ba4a6a0d916697a4685e2","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    if (\u0027tempest.config\u0027 in logical_line"},{"line_number":270,"context_line":"        or \u0027from tempest import config\u0027 in logical_line"},{"line_number":271,"context_line":"        or \u0027oslo_config\u0027 in logical_line):"},{"line_number":272,"context_line":"        msg \u003d (\u0027T114: tempest.lib can not have any dependency on tempest\u0027"},{"line_number":273,"context_line":"               \u0027config.\u0027)"},{"line_number":274,"context_line":"        yield(0, msg)"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_ad42bdab","line":272,"range":{"start_line":272,"start_character":65,"end_line":272,"end_character":72},"in_reply_to":"9abb7d3a_a2d48ceb","updated":"2016-06-01 19:04:05.000000000","message":"Done","commit_id":"d5830bd30a01641a1e31f71a4c93f4b9f9f90188"}]}