)]}'
{"tempest/common/preprov_creds.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b6197a9c07a025ce4c73bebcec7c32ead6a41ecc","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        return self.get_creds_by_roles([self.admin_role])"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def is_role_available(self, role):"},{"line_number":332,"context_line":"        if self.use_default_creds:"},{"line_number":333,"context_line":"            return False"},{"line_number":334,"context_line":"        else:"},{"line_number":335,"context_line":"            if self.hash_dict[\u0027roles\u0027].get(role):"},{"line_number":336,"context_line":"                return True"},{"line_number":337,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_d0da3516","side":"PARENT","line":334,"range":{"start_line":332,"start_character":0,"end_line":334,"end_character":13},"updated":"2016-06-09 00:04:47.000000000","message":"This logic is different from the above 2 changes, but here is fine because this removed False is used at\n\nhttps://github.com/openstack/tempest/blob/master/tempest/common/credentials_factory.py#L110\n\n 106     elif CONF.auth.test_accounts_file:\n 107         check_accounts \u003d preprov_creds.PreProvisionedCredentialProvider(\n 108             identity_version\u003didentity_version, name\u003d\u0027check_admin\u0027,\n 109             **get_preprov_provider_params())\n 110         if not check_accounts.admin_available():\n 111             is_admin \u003d False\n\nonly, and that means this worked only when using test_accounts_file option.\n\nBut the line 87 means here should not be test_accounts_file.\nSo LGTM.","commit_id":"b05766ba7a82986182ce05cb4353ae9414ba57be"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b6197a9c07a025ce4c73bebcec7c32ead6a41ecc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            identity_version\u003didentity_version, name\u003dname,"},{"line_number":85,"context_line":"            admin_role\u003dadmin_role, credentials_domain\u003dcredentials_domain)"},{"line_number":86,"context_line":"        self.test_accounts_file \u003d test_accounts_file"},{"line_number":87,"context_line":"        if test_accounts_file:"},{"line_number":88,"context_line":"            accounts \u003d read_accounts_yaml(self.test_accounts_file)"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            raise lib_exc.InvalidCredentials(\"No accounts file specified\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_102e7dfa","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":29},"updated":"2016-06-09 00:04:47.000000000","message":"here","commit_id":"ee5d56b7070d0f91240c232fc1f6fc560a02966f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b6197a9c07a025ce4c73bebcec7c32ead6a41ecc","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            identity_version\u003didentity_version, name\u003dname,"},{"line_number":85,"context_line":"            admin_role\u003dadmin_role, credentials_domain\u003dcredentials_domain)"},{"line_number":86,"context_line":"        self.test_accounts_file \u003d test_accounts_file"},{"line_number":87,"context_line":"        if test_accounts_file:"},{"line_number":88,"context_line":"            accounts \u003d read_accounts_yaml(self.test_accounts_file)"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            raise lib_exc.InvalidCredentials(\"No accounts file specified\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_b0ecc9bb","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":29},"updated":"2016-06-09 00:04:47.000000000","message":"here","commit_id":"ee5d56b7070d0f91240c232fc1f6fc560a02966f"}]}