)]}'
{"tempest/api/compute/keypairs/base.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"8e8e60eb7b7e76e4654fcd7a7b235fe176852846","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        cls.client \u003d cls.keypairs_client"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_keypair(self, keypair_name, **params):"},{"line_number":28,"context_line":"        client \u003d params.get(\"client\", None)"},{"line_number":29,"context_line":"        if not client:"},{"line_number":30,"context_line":"            self.client.delete_keypair(keypair_name, **params)"},{"line_number":31,"context_line":"        else:"},{"line_number":32,"context_line":"            client.delete_keypair(keypair_name, **params)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _create_keypair(self, keypair_name,"},{"line_number":35,"context_line":"                        pub_key\u003dNone, keypair_type\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_58422e3f","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":5},"updated":"2016-06-13 19:14:08.000000000","message":"The other part is good for me, but this file change seems different from the other part and the commit message doesn\u0027t mention about it. Can we separate this part from this patch?","commit_id":"299bb22599ff30bc548552240b07333568cc606e"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"25f664ef65249e87157491bc49b4640d015df10f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        cls.client \u003d cls.keypairs_client"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_keypair(self, keypair_name, **params):"},{"line_number":28,"context_line":"        client \u003d params.get(\"client\", None)"},{"line_number":29,"context_line":"        if not client:"},{"line_number":30,"context_line":"            self.client.delete_keypair(keypair_name, **params)"},{"line_number":31,"context_line":"        else:"},{"line_number":32,"context_line":"            client.delete_keypair(keypair_name, **params)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _create_keypair(self, keypair_name,"},{"line_number":35,"context_line":"                        pub_key\u003dNone, keypair_type\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_e66369af","line":32,"range":{"start_line":28,"start_character":0,"end_line":32,"end_character":5},"in_reply_to":"7aa08908_58422e3f","updated":"2016-06-14 05:15:08.000000000","message":"Hi , \nI tried to run it without this change but a test fails , the root cause is self.client belongs to admin and to non-admin .\n\nunder test_keypairs_v210.py , in testcase there is a function \nadmin_keypair \u003d self._create_keypair(admin_k_name, keypair_type\u003d\u0027ssh\u0027)\n\nIt was working because self.client was admin and it passed to  function. once i have changed it to admin_client it was calling to parent client which is non-admin .\n\nInside _create_keypair(..) they run self.client and since the name is changed it finds different client (non-admin) .\n\nI think its better to pass the client as argument to allow admin and not admin use these functions .\n\nBenny","commit_id":"299bb22599ff30bc548552240b07333568cc606e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"be8386c4cda8e7be292ef6fb6b4cf92aed8d7c9b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        if client:"},{"line_number":47,"context_line":"            delete_params.update({\u0027client\u0027: client})"},{"line_number":48,"context_line":"        # in case non-admin client"},{"line_number":49,"context_line":"        if not client:"},{"line_number":50,"context_line":"            body \u003d self.client.create_keypair(**kwargs)[\u0027keypair\u0027]"},{"line_number":51,"context_line":"            self.addCleanup(self._delete_keypair, keypair_name,"},{"line_number":52,"context_line":"                            **delete_params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_7d778e08","line":49,"updated":"2016-06-16 06:49:40.000000000","message":"else ?","commit_id":"299bb22599ff30bc548552240b07333568cc606e"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"be8386c4cda8e7be292ef6fb6b4cf92aed8d7c9b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            body \u003d self.client.create_keypair(**kwargs)[\u0027keypair\u0027]"},{"line_number":51,"context_line":"            self.addCleanup(self._delete_keypair, keypair_name,"},{"line_number":52,"context_line":"                            **delete_params)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            body \u003d client.create_keypair(**kwargs)[\u0027keypair\u0027]"},{"line_number":55,"context_line":"            self.addCleanup(self._delete_keypair, keypair_name,"},{"line_number":56,"context_line":"                            **delete_params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_7d5e6e7a","line":53,"updated":"2016-06-16 06:49:40.000000000","message":"move to the 1th block ? (if client: )","commit_id":"299bb22599ff30bc548552240b07333568cc606e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f733829812a01acfd2002cb56e83fab402323f89","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        if user_id:"},{"line_number":44,"context_line":"            kwargs.update({\u0027user_id\u0027: user_id})"},{"line_number":45,"context_line":"            delete_params[\u0027user_id\u0027] \u003d user_id"},{"line_number":46,"context_line":"        if client:"},{"line_number":47,"context_line":"            delete_params.update({\u0027client\u0027: client})"},{"line_number":48,"context_line":"        # in case non-admin client"},{"line_number":49,"context_line":"        if not client:"},{"line_number":50,"context_line":"            body \u003d self.client.create_keypair(**kwargs)[\u0027keypair\u0027]"},{"line_number":51,"context_line":"            self.addCleanup(self._delete_keypair, keypair_name,"},{"line_number":52,"context_line":"                            **delete_params)"},{"line_number":53,"context_line":"        else:"},{"line_number":54,"context_line":"            body \u003d client.create_keypair(**kwargs)[\u0027keypair\u0027]"},{"line_number":55,"context_line":"            self.addCleanup(self._delete_keypair, keypair_name,"},{"line_number":56,"context_line":"                            **delete_params)"},{"line_number":57,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_e06ce3d1","line":56,"range":{"start_line":46,"start_character":0,"end_line":56,"end_character":44},"updated":"2016-06-14 10:01:51.000000000","message":"this becoming less debug-able/redable now, i prefer to not to change these and we can keep the admin tests also same as it is.\n\nAs service client variable going to be more standardized way in client refactor work","commit_id":"299bb22599ff30bc548552240b07333568cc606e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f29e5ea4b4f46b9a603410e483b974e8d534d906","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        super(BaseKeypairTest, cls).setup_clients()"},{"line_number":25,"context_line":"        cls.client \u003d cls.keypairs_client"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_keypair(self, keypair_name, **params):"},{"line_number":28,"context_line":"        self.client.delete_keypair(keypair_name, **params)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def _create_keypair(self, keypair_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_55ac4eed","side":"PARENT","line":27,"updated":"2016-06-20 09:41:41.000000000","message":"This wrapper/alias should not have existed on the first place.","commit_id":"0a6dceb0bf1835508196519ffad6c954748b1b0f"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f29e5ea4b4f46b9a603410e483b974e8d534d906","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        super(BaseKeypairTest, cls).setup_clients()"},{"line_number":25,"context_line":"        cls.client \u003d cls.keypairs_client"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def _delete_keypair(self, keypair_name, **params):"},{"line_number":28,"context_line":"        client \u003d params.get(\"client\", None)"},{"line_number":29,"context_line":"        if not client:"},{"line_number":30,"context_line":"            self.client.delete_keypair(keypair_name, **params)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_b53492de","line":27,"updated":"2016-06-20 09:41:41.000000000","message":"We should remove that method. it\u0027s only called once in \"_create_keypair\"","commit_id":"b9fa85f539b1cf0d2c507531a8dc7afac9ce753e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f29e5ea4b4f46b9a603410e483b974e8d534d906","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            client \u003d self.client"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        body \u003d client.create_keypair(**kwargs)[\u0027keypair\u0027]"},{"line_number":54,"context_line":"        self.addCleanup(self._delete_keypair, keypair_name,"},{"line_number":55,"context_line":"                        **delete_params)"},{"line_number":56,"context_line":"        return body"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a9d85d2_35a54204","line":54,"updated":"2016-06-20 09:41:41.000000000","message":"Use \n  self.addCleanup(client.delete_keypair, keypair_name, **delete_params)\n\ninstead. This would solve the concerns of the reviewers and kill some useless code.","commit_id":"b9fa85f539b1cf0d2c507531a8dc7afac9ce753e"}]}