)]}'
{"tempest/api/identity/admin/v2/test_endpoints.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f0cfcddd780d49ef7ee63fe579f332536a835700","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                         \u0027type\u0027: s_type,"},{"line_number":32,"context_line":"                         \u0027description\u0027: s_description}"},{"line_number":33,"context_line":"        cls.service_data \u003d cls.services_client.create_service("},{"line_number":34,"context_line":"            **service_param)[\u0027OS-KSADM:service\u0027]"},{"line_number":35,"context_line":"        cls.service_id \u003d cls.service_data[\u0027id\u0027]"},{"line_number":36,"context_line":"        cls.service_ids.append(cls.service_id)"},{"line_number":37,"context_line":"        # Create endpoints so as to use for LIST and GET test cases"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_14fef5ad","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":27},"updated":"2016-06-16 20:43:21.000000000","message":"Why don\u0027t you change here like\n\n cls.service_data \u003d cls.services_client.create_service(\n     name\u003ds_name, type\u003ds_type, description\u003ds_description)\n\nwithout a dict?","commit_id":"843dbf778a40b35bc8f781b6daf7caef09368c68"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e57895ef8b690c248398fa9961fe61d22238009","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                         \u0027type\u0027: s_type,"},{"line_number":32,"context_line":"                         \u0027description\u0027: s_description}"},{"line_number":33,"context_line":"        cls.service_data \u003d cls.services_client.create_service("},{"line_number":34,"context_line":"            **service_param)[\u0027OS-KSADM:service\u0027]"},{"line_number":35,"context_line":"        cls.service_id \u003d cls.service_data[\u0027id\u0027]"},{"line_number":36,"context_line":"        cls.service_ids.append(cls.service_id)"},{"line_number":37,"context_line":"        # Create endpoints so as to use for LIST and GET test cases"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_58254bac","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":27},"in_reply_to":"7aa08908_14fef5ad","updated":"2016-06-17 00:04:49.000000000","message":"yes we can do that way also.","commit_id":"843dbf778a40b35bc8f781b6daf7caef09368c68"}],"tempest/api/identity/admin/v2/test_services.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f0cfcddd780d49ef7ee63fe579f332536a835700","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                         \u0027type\u0027: s_type,"},{"line_number":42,"context_line":"                         \u0027description\u0027: description}"},{"line_number":43,"context_line":"        service_data \u003d self.services_client.create_service("},{"line_number":44,"context_line":"            **service_param)[\u0027OS-KSADM:service\u0027]"},{"line_number":45,"context_line":"        self.assertFalse(service_data[\u0027id\u0027] is None)"},{"line_number":46,"context_line":"        self.addCleanup(self._del_service, service_data[\u0027id\u0027])"},{"line_number":47,"context_line":"        # Verifying response body of create service"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f41fe906","line":44,"range":{"start_line":44,"start_character":12,"end_line":44,"end_character":27},"updated":"2016-06-16 20:43:21.000000000","message":"ditto","commit_id":"843dbf778a40b35bc8f781b6daf7caef09368c68"}],"tempest/services/identity/v2/json/services_client.py":[{"author":{"_account_id":19587,"name":"Joshua White","email":"joshua.l.white@intel.com","username":"jwhite"},"change_message_id":"84358474aade754fdea608d2e5402be5eb615460","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        body \u003d json.loads(body)"},{"line_number":30,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def show_service(self, service_id):"},{"line_number":33,"context_line":"        \"\"\"Get Service.\"\"\""},{"line_number":34,"context_line":"        url \u003d \u0027/OS-KSADM/services/%s\u0027 % service_id"},{"line_number":35,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_9e1fb4b6","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":38},"updated":"2016-06-16 15:49:43.000000000","message":"I am not that familiar with the outcome of what was discussed in the link.  The link seems as if it is sort of lobbying for defining the variables.  But in this case I\u0027m guessing it was decided to use kwargs.  However, here kwargs is not used and the required parameter is defined.  For consistency, does this need to be in kwargs as well? Or do the required parameters need to be defined for other functions as well, create_service \u0026 list_service.","commit_id":"843dbf778a40b35bc8f781b6daf7caef09368c68"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6e57895ef8b690c248398fa9961fe61d22238009","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        body \u003d json.loads(body)"},{"line_number":30,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def show_service(self, service_id):"},{"line_number":33,"context_line":"        \"\"\"Get Service.\"\"\""},{"line_number":34,"context_line":"        url \u003d \u0027/OS-KSADM/services/%s\u0027 % service_id"},{"line_number":35,"context_line":"        resp, body \u003d self.get(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d658ed59","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":38},"in_reply_to":"7aa08908_9e1fb4b6","updated":"2016-06-17 00:04:49.000000000","message":"Thanks Joshua for review.\n\nActually GET(SHOW only) APIs take resource id in url and there will not be any request body. So we do not need kwargs here just required param used in url can be taken as args. \n\n\nIn POST/PUT(create/update), request body is being passed to API which is built by kwargs. Which allow to have fuzzy testing, by passing random kwargs in service client and and check the API behavior. \n\nSame with List APIs which accept many query params in url depends on that API filtering scope.","commit_id":"843dbf778a40b35bc8f781b6daf7caef09368c68"}]}