)]}'
{"tempest/common/validation_resources.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e23519873062920a07464822f1af94de77da5769","unresolved":false,"context_lines":[{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _create_ipv6_sec_groups(os, add_rule\u003dFalse):"},{"line_number":26,"context_line":"    sec_groups_client \u003d os.security_groups_client"},{"line_number":27,"context_line":"    sec_group_rules_client \u003d os.security_group_rules_client"},{"line_number":28,"context_line":"    sg_name \u003d data_utils.rand_name(\u0027securitygroup-\u0027)"},{"line_number":29,"context_line":"    sec_group \u003d sec_groups_client.create_security_group("},{"line_number":30,"context_line":"        name\u003dsg_name)[\u0027security_group\u0027]"},{"line_number":31,"context_line":"    if add_rule:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_65018104","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":52},"updated":"2016-06-16 21:41:16.000000000","message":"Do we really need an extra SG and an extra helper for this? I thought we could just add more rules to the existing SG.","commit_id":"fff95ea6cc6b10bbadb425146d8ba5fdf0d7a897"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e23519873062920a07464822f1af94de77da5769","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    sec_group \u003d sec_groups_client.create_security_group("},{"line_number":30,"context_line":"        name\u003dsg_name)[\u0027security_group\u0027]"},{"line_number":31,"context_line":"    if add_rule:"},{"line_number":32,"context_line":"        for direction in [\u0027ingress\u0027, \u0027egress\u0027]:"},{"line_number":33,"context_line":"            sec_group_rules_client.create_security_group_rule("},{"line_number":34,"context_line":"                security_group_id\u003dsec_group[\u0027id\u0027],"},{"line_number":35,"context_line":"                protocol\u003d\u0027tcp\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_ea76e0d6","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":44},"updated":"2016-06-16 21:41:16.000000000","message":"egress groups are probably not needed, see discussion on Ic3dd248b6b4217ff16852b70978aba718b2adec6 - it depends if we want to enforce in the tests the fact that they are not needed or not.","commit_id":"fff95ea6cc6b10bbadb425146d8ba5fdf0d7a897"}]}
