)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8388762571307ba61c61a879ab42793d9226b4b8","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def delete_volume(cls, client, volume_id):"},{"line_number":139,"context_line":"        \"\"\"Delete volume by the given client\"\"\""},{"line_number":140,"context_line":"        client.delete_volume(volume_id)"},{"line_number":141,"context_line":"        client.wait_for_resource_deletion(volume_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @classmethod"},{"line_number":144,"context_line":"    def clear_volumes(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_76e241a1","line":141,"range":{"start_line":141,"start_character":15,"end_line":141,"end_character":41},"updated":"2016-06-19 16:30:46.000000000","message":"Hi Liron , \nI think wait_for_resouce should be a flag , Not all cinder tests must wait for deletion .\nPlease see if we can skip wait in some cases.\nBenny","commit_id":"9bf9fac1d4b3500fc9e5ee04e2a2bf286d0d496e"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4fae0d2273060c027e9a18d0c60c2bfd76c87fc9","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def delete_volume(cls, client, volume_id):"},{"line_number":139,"context_line":"        \"\"\"Delete volume by the given client\"\"\""},{"line_number":140,"context_line":"        client.delete_volume(volume_id)"},{"line_number":141,"context_line":"        client.wait_for_resource_deletion(volume_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @classmethod"},{"line_number":144,"context_line":"    def clear_volumes(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_cc73a2b3","line":141,"range":{"start_line":141,"start_character":15,"end_line":141,"end_character":41},"in_reply_to":"5a9d85d2_76e241a1","updated":"2016-06-19 19:46:50.000000000","message":"Hi Benny,\nThis is all the purpose of the method to delete and wait in order to prevent race condition, it\u0027s redundant to add a flag for this.\nTests that should not wait until deletion will be completed, can call directly to delete volume client.","commit_id":"9bf9fac1d4b3500fc9e5ee04e2a2bf286d0d496e"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"1b649f36698024fd58d2f37ec55a047474b8588d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    def delete_volume(cls, client, volume_id):"},{"line_number":139,"context_line":"        \"\"\"Delete volume by the given client\"\"\""},{"line_number":140,"context_line":"        client.delete_volume(volume_id)"},{"line_number":141,"context_line":"        client.wait_for_resource_deletion(volume_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    @classmethod"},{"line_number":144,"context_line":"    def clear_volumes(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_af2f1fa0","line":141,"range":{"start_line":141,"start_character":15,"end_line":141,"end_character":41},"in_reply_to":"5a9d85d2_cc73a2b3","updated":"2016-06-20 09:08:36.000000000","message":"I am not going to make a big deal but then method could have been named \"delete_volume_and_wait\" then.","commit_id":"9bf9fac1d4b3500fc9e5ee04e2a2bf286d0d496e"}]}