)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"de35c45d45736dba48925b4c9b29658f70bb2554","unresolved":false,"context_lines":[{"line_number":11,"context_line":"_update_port_with_address method. The proposed solution is to assert"},{"line_number":12,"context_line":"on the items in the allowed address pairs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closed-Bug: 1594633"},{"line_number":15,"context_line":"Change-Id: Ibada9d24c0d018163cad575067def1c2ed20333f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_6b596b5a","line":14,"updated":"2016-06-22 22:28:02.000000000","message":"s/Closed-Bug/Closes-Bug/","commit_id":"da5c9c167a19240a60d07b0a2faec2c931211e1b"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"de35c45d45736dba48925b4c9b29658f70bb2554","unresolved":false,"context_lines":[{"line_number":12,"context_line":"on the items in the allowed address pairs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closed-Bug: 1594633"},{"line_number":15,"context_line":"Change-Id: Ibada9d24c0d018163cad575067def1c2ed20333f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3aaa91ec_cb15ff49","line":15,"updated":"2016-06-22 22:28:02.000000000","message":"In the future please do not change the Change-Id field, this is how Gerrit identifies patches. Don\u0027t change this back now, but in the future retain this line. Duplicate patch: https://review.openstack.org/331825","commit_id":"da5c9c167a19240a60d07b0a2faec2c931211e1b"}],"tempest/api/network/test_allowed_address_pair.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a1bc62b651141cffda874207e834e5fb1e29dda1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        body \u003d self.ports_client.update_port("},{"line_number":91,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":92,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":93,"context_line":"        self.assertItemsEqual(allowed_address_pair, allowed_address_pairs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"},{"line_number":96,"context_line":"    def test_update_port_with_address_pair(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_47e3c433","line":93,"range":{"start_line":93,"start_character":13,"end_line":93,"end_character":29},"updated":"2016-06-21 10:35:04.000000000","message":"this is not present in py3, how about assertEqual-\nassertEqual(sorted(allowed_address_pair), sorted(allowed_address_pairs))","commit_id":"6d5497666d60b20503bbe212ee2ef88cef9871c6"},{"author":{"_account_id":21451,"name":"Sunny Verma","email":"sunnyverma1992@gmail.com","username":"sunnyve"},"change_message_id":"11673c724a7e3f1a176c729e6cd906c9663f02cb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        body \u003d self.ports_client.update_port("},{"line_number":91,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":92,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":93,"context_line":"        self.assertItemsEqual(allowed_address_pair, allowed_address_pairs)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"},{"line_number":96,"context_line":"    def test_update_port_with_address_pair(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_99a99f7e","line":93,"range":{"start_line":93,"start_character":13,"end_line":93,"end_character":29},"in_reply_to":"5a9d85d2_47e3c433","updated":"2016-06-22 16:25:49.000000000","message":"Thanks for mentioning it. Don\u0027t suspect that this could be a problem. But we don\u0027t need to sort lists, we can use six to deal with renamed methods.\nhttps://pythonhosted.org/six/#unittest-assertions\n six.assertCountEqual()\n Alias for assertCountEqual() on Python 3 and assertItemsEqual() on Python 2.","commit_id":"6d5497666d60b20503bbe212ee2ef88cef9871c6"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"056b4bba9c816e490e6e9e8a7a67de4bf9686fe5","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        body \u003d self.ports_client.update_port("},{"line_number":92,"context_line":"            port_id, allowed_address_pairs\u003dallowed_address_pairs)"},{"line_number":93,"context_line":"        allowed_address_pair \u003d body[\u0027port\u0027][\u0027allowed_address_pairs\u0027]"},{"line_number":94,"context_line":"        six.assertCountEqual(self, allowed_address_pair,"},{"line_number":95,"context_line":"                             allowed_address_pairs)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @test.idempotent_id(\u00279599b337-272c-47fd-b3cf-509414414ac4\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_5e700f0b","line":94,"range":{"start_line":94,"start_character":12,"end_line":94,"end_character":28},"updated":"2016-06-27 08:26:43.000000000","message":"That\u0027s a nice one, I didn\u0027t know about it :)\nYou could use assertEqual(Counter(list(first)), Counter(list(second))) and avoid using six, but at the end it\u0027s more readable the way it is.","commit_id":"08ce3f0dd99e6df1c305587b729358d57cbce325"}]}
