)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e44576ca409d8dca7dbc28778d738628fb4efa7b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- attach the root volume"},{"line_number":20,"context_line":"- verify that the unshelve of the instance works correctly."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Please note that this change also adds a schema change introduced in"},{"line_number":23,"context_line":"nova with the 2.26 microversion. The schema change adds a new field"},{"line_number":24,"context_line":"coming back for GET and LIST operations on nova servers."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"7a77a97e_125c8f4a","line":22,"updated":"2016-11-15 19:32:53.000000000","message":"This should also be removed","commit_id":"1b89d065b02a4dc4cf296eeb38216942c27cdeb0"}],"tempest/api/compute/volumes/test_attach_volume.py":[{"author":{"_account_id":9152,"name":"Castulo J. Martinez","email":"castulo.martinez@intel.com","username":"cas"},"change_message_id":"b7072751a01e701ad7f8a33669fc466e41e1da91","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        super(DetachAttachBootVolumeShelveTestJSON, cls).resource_setup()"},{"line_number":280,"context_line":"        cls.device \u003d CONF.compute.volume_device_name"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _shelve_server(self):"},{"line_number":283,"context_line":"        compute.shelve_server(self.servers_client,"},{"line_number":284,"context_line":"                              self.server[\u0027id\u0027],"},{"line_number":285,"context_line":"                              force_shelve_offload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_7763f81a","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":22},"updated":"2016-11-15 17:48:49.000000000","message":"Does it really provide value to have a _shelve_server function that has only one operation on it and it is used only once?","commit_id":"1b89d065b02a4dc4cf296eeb38216942c27cdeb0"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e44576ca409d8dca7dbc28778d738628fb4efa7b","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        super(DetachAttachBootVolumeShelveTestJSON, cls).resource_setup()"},{"line_number":280,"context_line":"        cls.device \u003d CONF.compute.volume_device_name"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def _shelve_server(self):"},{"line_number":283,"context_line":"        compute.shelve_server(self.servers_client,"},{"line_number":284,"context_line":"                              self.server[\u0027id\u0027],"},{"line_number":285,"context_line":"                              force_shelve_offload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a77a97e_f2547355","line":282,"range":{"start_line":282,"start_character":8,"end_line":282,"end_character":22},"in_reply_to":"7a77a97e_7763f81a","updated":"2016-11-15 19:32:53.000000000","message":"Yeah, please remove that function. It\u0027s doesn\u0027t do enough to warrant a new function, and it\u0027s not reusable.","commit_id":"1b89d065b02a4dc4cf296eeb38216942c27cdeb0"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"ac15333e8f27db73590715a24d449569d128a2d7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":11,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a77a97e_320df23e","line":13,"updated":"2016-11-16 09:42:22.000000000","message":"seems we need this line otherwise pep8 fails","commit_id":"875490f574a35f0f08826265abf7d22a77c64f3c"},{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"5902510b56097346422da039f7347ab429c69762","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest.common.utils.linux import remote_client"},{"line_number":21,"context_line":"from tempest.common import waiters"},{"line_number":22,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":23,"context_line":"from tempest import config"},{"line_number":24,"context_line":"from tempest import test"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_35b07c43","line":23,"updated":"2016-11-16 09:44:07.000000000","message":"wrong order","commit_id":"679eb1c126a0a275f484344f74c2f87e10191bc0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"92c3196946397a119b6b629a5369673999036d39","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        bdms \u003d [{"},{"line_number":477,"context_line":"            \u0027source_type\u0027: \u0027image\u0027,"},{"line_number":478,"context_line":"            \u0027destination_type\u0027: \u0027volume\u0027,"},{"line_number":479,"context_line":"            \u0027uuid\u0027: CONF.compute.image_ref,"},{"line_number":480,"context_line":"            \u0027boot_index\u0027: 0,"},{"line_number":481,"context_line":"            \u0027delete_on_termination\u0027: False,"},{"line_number":482,"context_line":"            \u0027tag\u0027: \u0027root\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"9fdfeff1_5e029974","line":479,"updated":"2019-03-02 00:27:20.000000000","message":"Hmm, this fails:\n\nhttp://logs.openstack.org/50/332050/18/check/tempest-full/f146d24/controller/logs/screen-n-api.txt.gz#_Mar_01_21_57_53_623712\n\nMar 01 21:57:53.623712 ubuntu-bionic-rax-dfw-0003242602 devstack@n-api.service[3071]: INFO nova.api.openstack.wsgi [None req-3ba6b743-aa11-468f-a524-dc19ceb16b4e tempest-DetachAttachBootVolumeShelveTestJSON-1339257189 tempest-DetachAttachBootVolumeShelveTestJSON-1339257189] HTTP exception thrown: Images with destination_type \u0027volume\u0027 need to have a non-zero size specified\n\nThis is failing here:\n\nhttps://github.com/openstack/nova/blob/5a09c81af3b438ecbcf27fa653095ff55abb3ed4/nova/compute/api.py#L1461\n\nI guess we have to specify volume_size. This should be in the nova API reference.","commit_id":"8f690ceed2e643478bfd3e6bab33f267e85840fd"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"347a0fe026dd0944c9b7acd0be5a5d89b625a428","unresolved":false,"context_lines":[{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        # Detach root volume and wait that the volume is detached"},{"line_number":503,"context_line":"        self.servers_client.detach_volume(server[\u0027id\u0027], volume_id)"},{"line_number":504,"context_line":"        waiters.wait_for_volume_status("},{"line_number":505,"context_line":"            self.volumes_client, volume_id, \u0027available\u0027)"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        # The volume attachment in the compute API should no longer have"},{"line_number":508,"context_line":"        # a volumeId but the tag should still be set."}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_01859aad","line":505,"range":{"start_line":504,"start_character":7,"end_line":505,"end_character":56},"updated":"2019-03-05 20:58:22.000000000","message":"http://logs.openstack.org/50/332050/23/check/tempest-full/ba42c78/job-output.txt.gz#_2019-03-04_20_21_23_678174\n\nAttributeError: \u0027module\u0027 object has no attribute \u0027wait_for_volume_status\u0027","commit_id":"9101250dc58d53de63c1d94c51816fe8f10b2042"}]}