)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"d4193c3146fa30d9ff557b74a6e931398e62b06e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move snapshot creating from resource setup"},{"line_number":10,"context_line":"to tests."},{"line_number":11,"context_line":"Closes-bug: #1593278"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1cff2bd62a40659f291ec7b78dbe080686149e34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_6244cd1a","line":11,"updated":"2016-07-11 14:53:47.000000000","message":"nit: add blank before this one","commit_id":"090003384491291b529ccff19e94da8c96d69a7e"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"12d1cdb850ab72932a87dfcb27286ea231848b5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     obutenko \u003cobutenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 13:41:35 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Resource setup for test_snapshot_list_param_* tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_snapshot_list_param_* tests require two volume snapshots."},{"line_number":10,"context_line":"Move this tests to new file."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9ad45d7e_cead7cea","line":7,"updated":"2016-08-11 17:14:56.000000000","message":"Please update commit message to match the changes","commit_id":"135cd056ca6aa87d3df7ee032b575d934adad664"}],"tempest/api/volume/test_volumes_snapshots.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b45315e612a690407acfff4d3850f799dd26d840","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Delete the snapshot"},{"line_number":122,"context_line":"        self.cleanup_snapshot(snapshot)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @test.idempotent_id(\u002759f41f43-aebf-48a9-ab5d-d76340fab32b\u0027)"},{"line_number":125,"context_line":"    def test_snapshots_list_with_params(self):"},{"line_number":126,"context_line":"        \"\"\"list snapshots with params.\"\"\""},{"line_number":127,"context_line":"        # Create a snapshot"},{"line_number":128,"context_line":"        display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":129,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":130,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":131,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Verify list snapshots by display_name filter"},{"line_number":134,"context_line":"        params \u003d {self.name_field: snapshot[self.name_field]}"},{"line_number":135,"context_line":"        self._list_by_param_values_and_assert(**params)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Verify list snapshots by status filter"},{"line_number":138,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":139,"context_line":"        self._list_by_param_values_and_assert(**params)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Verify list snapshots by status and display name filter"},{"line_number":142,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027,"},{"line_number":143,"context_line":"                  self.name_field: snapshot[self.name_field]}"},{"line_number":144,"context_line":"        self._list_by_param_values_and_assert(**params)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @test.idempotent_id(\u0027220a1022-1fcd-4a74-a7bd-6b859156cda2\u0027)"},{"line_number":147,"context_line":"    def test_snapshots_list_details_with_params(self):"},{"line_number":148,"context_line":"        \"\"\"list snapshot details with params.\"\"\""},{"line_number":149,"context_line":"        # Create a snapshot"},{"line_number":150,"context_line":"        display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":151,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":152,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":153,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Verify list snapshot details by display_name filter"},{"line_number":156,"context_line":"        params \u003d {self.name_field: snapshot[self.name_field]}"},{"line_number":157,"context_line":"        self._list_by_param_values_and_assert(with_detail\u003dTrue, **params)"},{"line_number":158,"context_line":"        # Verify list snapshot details by status filter"},{"line_number":159,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":160,"context_line":"        self._list_by_param_values_and_assert(with_detail\u003dTrue, **params)"},{"line_number":161,"context_line":"        # Verify list snapshot details by status and display name filter"},{"line_number":162,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027,"},{"line_number":163,"context_line":"                  self.name_field: snapshot[self.name_field]}"},{"line_number":164,"context_line":"        self._list_by_param_values_and_assert(with_detail\u003dTrue, **params)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":167,"context_line":"    def test_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_d9cb551d","line":164,"range":{"start_line":124,"start_character":0,"end_line":164,"end_character":73},"updated":"2016-08-15 05:47:42.000000000","message":"we can move these 2 tests also in new file.\n\nlet\u0027s create snapshot with  params \u003d {self.name_field: display_name} in resource_setup and in these tests we do not need to create new snapshot just list with filters.","commit_id":"971fbe261b8299c20e1faca6937b344436d10503"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"f523954dfafe7ca5683203acef94d8ea1cb4d1ec","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        # Delete the snapshot"},{"line_number":122,"context_line":"        self.cleanup_snapshot(snapshot)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @test.idempotent_id(\u002759f41f43-aebf-48a9-ab5d-d76340fab32b\u0027)"},{"line_number":125,"context_line":"    def test_snapshots_list_with_params(self):"},{"line_number":126,"context_line":"        \"\"\"list snapshots with params.\"\"\""},{"line_number":127,"context_line":"        # Create a snapshot"},{"line_number":128,"context_line":"        display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":129,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":130,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":131,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Verify list snapshots by display_name filter"},{"line_number":134,"context_line":"        params \u003d {self.name_field: snapshot[self.name_field]}"},{"line_number":135,"context_line":"        self._list_by_param_values_and_assert(**params)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # Verify list snapshots by status filter"},{"line_number":138,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":139,"context_line":"        self._list_by_param_values_and_assert(**params)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        # Verify list snapshots by status and display name filter"},{"line_number":142,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027,"},{"line_number":143,"context_line":"                  self.name_field: snapshot[self.name_field]}"},{"line_number":144,"context_line":"        self._list_by_param_values_and_assert(**params)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @test.idempotent_id(\u0027220a1022-1fcd-4a74-a7bd-6b859156cda2\u0027)"},{"line_number":147,"context_line":"    def test_snapshots_list_details_with_params(self):"},{"line_number":148,"context_line":"        \"\"\"list snapshot details with params.\"\"\""},{"line_number":149,"context_line":"        # Create a snapshot"},{"line_number":150,"context_line":"        display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":151,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":152,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":153,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        # Verify list snapshot details by display_name filter"},{"line_number":156,"context_line":"        params \u003d {self.name_field: snapshot[self.name_field]}"},{"line_number":157,"context_line":"        self._list_by_param_values_and_assert(with_detail\u003dTrue, **params)"},{"line_number":158,"context_line":"        # Verify list snapshot details by status filter"},{"line_number":159,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027}"},{"line_number":160,"context_line":"        self._list_by_param_values_and_assert(with_detail\u003dTrue, **params)"},{"line_number":161,"context_line":"        # Verify list snapshot details by status and display name filter"},{"line_number":162,"context_line":"        params \u003d {\u0027status\u0027: \u0027available\u0027,"},{"line_number":163,"context_line":"                  self.name_field: snapshot[self.name_field]}"},{"line_number":164,"context_line":"        self._list_by_param_values_and_assert(with_detail\u003dTrue, **params)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    @test.idempotent_id(\u0027677863d1-3142-456d-b6ac-9924f667a7f4\u0027)"},{"line_number":167,"context_line":"    def test_volume_from_snapshot(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ac371cc_10465a23","line":164,"range":{"start_line":124,"start_character":0,"end_line":164,"end_character":73},"in_reply_to":"3ac371cc_d9cb551d","updated":"2016-08-15 08:09:42.000000000","message":"Done","commit_id":"971fbe261b8299c20e1faca6937b344436d10503"}],"tempest/api/volume/test_volumes_snapshots_list.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a882a4f6fd87a01b4fa5aff08e0d50436911c8c7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(VolumesV2SnapshotListTestJSON, cls).resource_setup()"},{"line_number":33,"context_line":"        cls.volume_origin \u003d cls.create_volume()"},{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":37,"context_line":"        params \u003d {cls.name_field: display_name}"},{"line_number":38,"context_line":"        for _ in range(2):"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_09ef2688","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":47},"updated":"2016-08-16 05:16:14.000000000","message":"these should be inside for loop to create both snapshot with different dispaly_name","commit_id":"bad91b9718f6da32cae2a3b4e45c030ae80b4ad5"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"d66ae5c92213a28851b39d60bd032a45838049e1","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(VolumesV2SnapshotListTestJSON, cls).resource_setup()"},{"line_number":33,"context_line":"        cls.volume_origin \u003d cls.create_volume()"},{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":37,"context_line":"        params \u003d {cls.name_field: display_name}"},{"line_number":38,"context_line":"        for _ in range(2):"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ac371cc_a5e511dd","line":37,"range":{"start_line":35,"start_character":0,"end_line":37,"end_character":47},"in_reply_to":"3ac371cc_09ef2688","updated":"2016-08-17 07:35:31.000000000","message":"Done","commit_id":"bad91b9718f6da32cae2a3b4e45c030ae80b4ad5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1e3d5edf37a723da92a067307b63212ae3d09d4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        for _ in range(2):"},{"line_number":37,"context_line":"            display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":38,"context_line":"            params \u003d {cls.name_field: display_name}"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_6692e34d","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":54},"updated":"2016-09-08 02:25:17.000000000","message":"you can have self.d_name1 and self.d_name2 and create snapshot with those and use those in below tests.","commit_id":"3b7525e838ac9b7ea67229a8c60e0ed5904242e5"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0fb62194c9b29e45ff83804585d0801ca020bf09","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        for _ in range(2):"},{"line_number":37,"context_line":"            display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":38,"context_line":"            params \u003d {cls.name_field: display_name}"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_0cf2fa05","line":37,"range":{"start_line":37,"start_character":11,"end_line":37,"end_character":54},"in_reply_to":"9a89bdaa_6692e34d","updated":"2016-09-09 10:31:37.000000000","message":"Done","commit_id":"3b7525e838ac9b7ea67229a8c60e0ed5904242e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1e3d5edf37a723da92a067307b63212ae3d09d4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # Create a snapshot"},{"line_number":71,"context_line":"        display_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-snap\u0027)"},{"line_number":72,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":73,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":74,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Verify list snapshots by display_name filter"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_0694b740","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":75},"updated":"2016-09-08 02:25:17.000000000","message":"why we need to create new snapshot here, we should use the one created in resource_setup.\n\nI think that was the main motive of moving these tests into separate file.","commit_id":"3b7525e838ac9b7ea67229a8c60e0ed5904242e5"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0fb62194c9b29e45ff83804585d0801ca020bf09","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        # Create a snapshot"},{"line_number":71,"context_line":"        display_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-snap\u0027)"},{"line_number":72,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":73,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":74,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        # Verify list snapshots by display_name filter"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_6cdb867c","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":75},"in_reply_to":"9a89bdaa_0694b740","updated":"2016-09-09 10:31:37.000000000","message":"Done","commit_id":"3b7525e838ac9b7ea67229a8c60e0ed5904242e5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b1e3d5edf37a723da92a067307b63212ae3d09d4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # Create a snapshot"},{"line_number":93,"context_line":"        display_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-snap\u0027)"},{"line_number":94,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":95,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":96,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Verify list snapshot details by display_name filter"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_668bc31f","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":75},"updated":"2016-09-08 02:25:17.000000000","message":"ditto","commit_id":"3b7525e838ac9b7ea67229a8c60e0ed5904242e5"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"0fb62194c9b29e45ff83804585d0801ca020bf09","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        # Create a snapshot"},{"line_number":93,"context_line":"        display_name \u003d data_utils.rand_name(self.__class__.__name__ + \u0027-snap\u0027)"},{"line_number":94,"context_line":"        params \u003d {self.name_field: display_name}"},{"line_number":95,"context_line":"        snapshot \u003d self.create_snapshot(self.volume_origin[\u0027id\u0027], **params)"},{"line_number":96,"context_line":"        self.addCleanup(self.cleanup_snapshot, snapshot)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        # Verify list snapshot details by display_name filter"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_ace10e2c","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":75},"in_reply_to":"9a89bdaa_668bc31f","updated":"2016-09-09 10:31:37.000000000","message":"Done","commit_id":"3b7525e838ac9b7ea67229a8c60e0ed5904242e5"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7bca8fb5cdaf1a42421a764e8b0c093de65fdd7e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        for _ in range(2):"},{"line_number":37,"context_line":"            display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":38,"context_line":"            params \u003d {cls.name_field: display_name}"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":26,"id":"7a8ec9b2_1ef8f77b","line":37,"updated":"2016-09-20 16:38:17.000000000","message":"I don\u0027t exactly see why you introduced L37 and L38. They were not in the original file.","commit_id":"054f8ab37aa91a13e97ef55b23815d02f39ba41d"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8788bfdca73738a0e065e2e4f8bf6a33253c89bb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        for _ in range(2):"},{"line_number":37,"context_line":"            display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":38,"context_line":"            params \u003d {cls.name_field: display_name}"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a8bc5a2_e52a18e7","line":37,"in_reply_to":"5a8bc5a2_5fdb9ded","updated":"2016-09-22 12:32:58.000000000","message":"Try it by your self: Remove l37 and l38, run the tests. If they pass, you now have a patch with less code, less problem, easier to review and debug. Give it a try :)","commit_id":"054f8ab37aa91a13e97ef55b23815d02f39ba41d"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"2b573712b357e65fc42d2cb79efeee1bf4394716","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        for _ in range(2):"},{"line_number":37,"context_line":"            display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":38,"context_line":"            params \u003d {cls.name_field: display_name}"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a8bc5a2_f82b832e","line":37,"in_reply_to":"5a8bc5a2_e52a18e7","updated":"2016-09-22 20:02:55.000000000","message":"I agree , my mistake))","commit_id":"054f8ab37aa91a13e97ef55b23815d02f39ba41d"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"cf5a0d75a367932c9b5db15263aef87fd6177b19","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        cls.name_field \u003d cls.special_fields[\u0027name_field\u0027]"},{"line_number":35,"context_line":"        # Create snapshots with params"},{"line_number":36,"context_line":"        for _ in range(2):"},{"line_number":37,"context_line":"            display_name \u003d data_utils.rand_name(\u0027snap\u0027)"},{"line_number":38,"context_line":"            params \u003d {cls.name_field: display_name}"},{"line_number":39,"context_line":"            cls.snapshot \u003d cls.create_snapshot("},{"line_number":40,"context_line":"                cls.volume_origin[\u0027id\u0027], **params)"}],"source_content_type":"text/x-python","patch_set":26,"id":"5a8bc5a2_5fdb9ded","line":37,"in_reply_to":"7a8ec9b2_1ef8f77b","updated":"2016-09-22 12:03:50.000000000","message":"I added this after comment Ghanshyam Mann:\n\"let\u0027s create snapshot with  params \u003d {self.name_field: display_name} in resource_setup and in these tests we do not need to create new snapshot just list with filters.\" So, I added and remove from tests creating snapshot and now use snapshot from resource setup","commit_id":"054f8ab37aa91a13e97ef55b23815d02f39ba41d"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e9b9d545f71b5450f0d1035663adb59d91419629","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _list_by_param_values_and_assert(self, with_detail\u003dFalse, **params):"},{"line_number":40,"context_line":"        \"\"\"list or list_details with given params and validates result.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if with_detail:"},{"line_number":43,"context_line":"            fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":44,"context_line":"                detail\u003dTrue, **params)[\u0027snapshots\u0027]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":47,"context_line":"                **params)[\u0027snapshots\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Validating params of fetched snapshots"},{"line_number":50,"context_line":"        for snap in fetched_snap_list:"}],"source_content_type":"text/x-python","patch_set":28,"id":"5a8bc5a2_eadbb219","line":47,"range":{"start_line":42,"start_character":8,"end_line":47,"end_character":38},"updated":"2016-09-22 16:40:23.000000000","message":"This can be changed as a single line such as:\nfetched_snap_list \u003d self.snapshots_client.list_snapshots(\n                detail\u003dwith_detail, **params)[\u0027snapshots\u0027] ??","commit_id":"642f835d139bec9e7d8b3ed98dfc7de86bde589b"},{"author":{"_account_id":14510,"name":"Oleksii Butenko","email":"apbutenko@gmail.com","username":"obutenko"},"change_message_id":"417a06868475170506681af61da37a62d413f8cd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _list_by_param_values_and_assert(self, with_detail\u003dFalse, **params):"},{"line_number":40,"context_line":"        \"\"\"list or list_details with given params and validates result.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if with_detail:"},{"line_number":43,"context_line":"            fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":44,"context_line":"                detail\u003dTrue, **params)[\u0027snapshots\u0027]"},{"line_number":45,"context_line":"        else:"},{"line_number":46,"context_line":"            fetched_snap_list \u003d self.snapshots_client.list_snapshots("},{"line_number":47,"context_line":"                **params)[\u0027snapshots\u0027]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Validating params of fetched snapshots"},{"line_number":50,"context_line":"        for snap in fetched_snap_list:"}],"source_content_type":"text/x-python","patch_set":28,"id":"5a8bc5a2_18210f4e","line":47,"range":{"start_line":42,"start_character":8,"end_line":47,"end_character":38},"in_reply_to":"5a8bc5a2_eadbb219","updated":"2016-09-22 20:02:49.000000000","message":"Done","commit_id":"642f835d139bec9e7d8b3ed98dfc7de86bde589b"}]}