)]}'
{"tempest/api/network/test_networks.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"51141c8954f089b0a5d5f282b86c3f2b47163f20","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _get_allocation_pools_from_gateway(cls, ip_version):"},{"line_number":128,"context_line":"        \"\"\"Return allocation range for subnet of given gateway\"\"\""},{"line_number":129,"context_line":"        gateway \u003d cls._get_gateway_from_tempest_conf(ip_version)"},{"line_number":130,"context_line":"        return [{\u0027start\u0027: str(gateway + 2), \u0027end\u0027: str(gateway + 3)}]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def subnet_dict(self, include_keys):"},{"line_number":133,"context_line":"        # Return a subnet dict which has include_keys and their corresponding"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_aa063883","side":"PARENT","line":130,"updated":"2016-06-30 16:28:16.000000000","message":"What about changing this to:\n  \u0027end\u0027: str(gateway + 7)\n\nThat should be enough ?","commit_id":"5e2ebd5ccffaead5119557a925c3c79e5733b7a4"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"a88b0717e3abb3aea5f78a1788dd2d325fe7c222","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _get_allocation_pools_from_gateway(cls, ip_version):"},{"line_number":128,"context_line":"        \"\"\"Return allocation range for subnet of given gateway\"\"\""},{"line_number":129,"context_line":"        gateway \u003d cls._get_gateway_from_tempest_conf(ip_version)"},{"line_number":130,"context_line":"        return [{\u0027start\u0027: str(gateway + 2), \u0027end\u0027: str(gateway + 3)}]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def subnet_dict(self, include_keys):"},{"line_number":133,"context_line":"        # Return a subnet dict which has include_keys and their corresponding"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8c585afc","side":"PARENT","line":130,"in_reply_to":"3aaa91ec_aa063883","updated":"2016-07-04 11:14:11.000000000","message":"I think we could set there 7 as default value, but making it also configurable as it won\u0027t be that much effort and would avoid hardcoding anything if possible ;)","commit_id":"5e2ebd5ccffaead5119557a925c3c79e5733b7a4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0bdac2209060c9469521f6ae5474ba09d305e714","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    def _get_allocation_pools_from_gateway(cls, ip_version):"},{"line_number":128,"context_line":"        \"\"\"Return allocation range for subnet of given gateway\"\"\""},{"line_number":129,"context_line":"        gateway \u003d cls._get_gateway_from_tempest_conf(ip_version)"},{"line_number":130,"context_line":"        return [{\u0027start\u0027: str(gateway + 2), \u0027end\u0027: str(gateway + 6)}]"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def subnet_dict(self, include_keys):"},{"line_number":133,"context_line":"        # Return a subnet dict which has include_keys and their corresponding"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bf3a7696","line":130,"updated":"2016-07-28 22:40:57.000000000","message":"nit: better to write the reason why of 6 as the comment later.","commit_id":"be634fcb59b4a6b1cc17a4663c6fc0202386e1fc"}],"tempest/config.py":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"7ef30e1f9be2b4cd2965348b50ac187f928cbefa","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                     \" for subnetpools creation\"),"},{"line_number":524,"context_line":"    cfg.IntOpt(\u0027allocation_pool_size\u0027,"},{"line_number":525,"context_line":"               default\u003d2,"},{"line_number":526,"context_line":"               help\u003d\"Default number of IP addresses in the allocation pool\""},{"line_number":527,"context_line":"                    \" of a newly created subnet\"),"},{"line_number":528,"context_line":"]"},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_1bea44db","line":527,"range":{"start_line":526,"start_character":0,"end_line":527,"end_character":50},"updated":"2016-06-30 15:05:00.000000000","message":"NIT: The only concern I have with this is that this parameter is only going to be honoured for subnets created by a network API tests in test_networks.py, but not any test, while the text here is rather generic.\nI guess that\u0027s fair enough in any case, and other tests can be fixed to use this parameter as well on demand if required.","commit_id":"b717aeca9d872709d5c0fe5cdd2a1820238f48db"}]}