)]}'
{"tempest/service_clients.py":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"507c760fe25ab3d1de83486cb850e5d85f09f03e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # Register service clients owned by tempest"},{"line_number":296,"context_line":"        for service in tempest_modules():"},{"line_number":297,"context_line":"            if service in [\u0027compute\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027, \u0027network\u0027]:"},{"line_number":298,"context_line":"                attribute \u003d service.replace(\u0027.\u0027, \u0027_\u0027)"},{"line_number":299,"context_line":"                configs \u003d service.split(\u0027.\u0027)[0]"},{"line_number":300,"context_line":"                module \u003d client_modules_by_service_name[service]"},{"line_number":301,"context_line":"                self.register_service_client_module("}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_10de2511","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":53},"updated":"2016-07-19 08:26:50.000000000","message":"is there any reason to not name directly image_v1 instead of image.v1?","commit_id":"adf9344f38d7a855c76c4997889685460776e350"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"0c6ea27d95aae231a35b79ae25ba28fbecb91b96","unresolved":false,"context_lines":[{"line_number":295,"context_line":"        # Register service clients owned by tempest"},{"line_number":296,"context_line":"        for service in tempest_modules():"},{"line_number":297,"context_line":"            if service in [\u0027compute\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027, \u0027network\u0027]:"},{"line_number":298,"context_line":"                attribute \u003d service.replace(\u0027.\u0027, \u0027_\u0027)"},{"line_number":299,"context_line":"                configs \u003d service.split(\u0027.\u0027)[0]"},{"line_number":300,"context_line":"                module \u003d client_modules_by_service_name[service]"},{"line_number":301,"context_line":"                self.register_service_client_module("}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_33736a82","line":298,"range":{"start_line":298,"start_character":0,"end_line":298,"end_character":53},"in_reply_to":"dada55a8_10de2511","updated":"2016-07-19 11:18:16.000000000","message":"Well I need both versions, the one with the \u0027.\u0027 which is the module name and the one with the \u0027_\u0027 which is the attribute name.","commit_id":"adf9344f38d7a855c76c4997889685460776e350"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"981b0671be1e3412c3b4e633d8752045246a77b5","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        # Register service clients owned by tempest"},{"line_number":296,"context_line":"        for service in tempest_modules():"},{"line_number":297,"context_line":"            if service in [\u0027compute\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027, \u0027network\u0027]:"},{"line_number":298,"context_line":"                attribute \u003d service.replace(\u0027.\u0027, \u0027_\u0027)"},{"line_number":299,"context_line":"                configs \u003d service.split(\u0027.\u0027)[0]"},{"line_number":300,"context_line":"                module \u003d client_modules_by_service_name[service]"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_a5eb7577","line":297,"updated":"2016-07-25 17:58:43.000000000","message":"You already have this hardcoded in the top you can just do if service in list(client_modules_by_service_name.keys())","commit_id":"806afb0d1390d8cf4b1028db313b1171632ed08f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"981b0671be1e3412c3b4e633d8752045246a77b5","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def registered_services(self):"},{"line_number":373,"context_line":"        # TODO(andreaf) Temporary set needed until all services are migrated"},{"line_number":374,"context_line":"        _non_migrated_services \u003d tempest_modules() - set("},{"line_number":375,"context_line":"            [\u0027compute\u0027, \u0027network\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027])"},{"line_number":376,"context_line":"        return self._registered_services | _non_migrated_services"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def _setup_parameters(self, parameters):"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_05036143","line":375,"updated":"2016-07-25 17:58:43.000000000","message":"You already have this hardcoded in the top, just do list(client_modules_by_service_name.keys()) (ugh, I hate py3) or something","commit_id":"806afb0d1390d8cf4b1028db313b1171632ed08f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9e42e3f2976d9bf9c6c92de10b7e50dd68059b5","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        # TODO(andreaf) Temporary set needed until all services are migrated"},{"line_number":374,"context_line":"        _non_migrated_services \u003d tempest_modules() - set("},{"line_number":375,"context_line":"            [\u0027compute\u0027, \u0027network\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027])"},{"line_number":376,"context_line":"        return self._registered_services | _non_migrated_services"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def _setup_parameters(self, parameters):"},{"line_number":379,"context_line":"        \"\"\"Setup default values for client parameters"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_f1d233ff","line":376,"range":{"start_line":376,"start_character":43,"end_line":376,"end_character":65},"updated":"2016-07-26 08:55:22.000000000","message":"i did not get, it will return unregistered services right?","commit_id":"806afb0d1390d8cf4b1028db313b1171632ed08f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f58f0abc794e13d4c0d0f340e53e2b157d3097a8","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        # TODO(andreaf) Temporary set needed until all services are migrated"},{"line_number":374,"context_line":"        _non_migrated_services \u003d tempest_modules() - set("},{"line_number":375,"context_line":"            [\u0027compute\u0027, \u0027network\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027])"},{"line_number":376,"context_line":"        return self._registered_services | _non_migrated_services"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def _setup_parameters(self, parameters):"},{"line_number":379,"context_line":"        \"\"\"Setup default values for client parameters"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_a7489d88","line":376,"range":{"start_line":376,"start_character":43,"end_line":376,"end_character":65},"in_reply_to":"dada55a8_de828551","updated":"2016-07-29 09:03:11.000000000","message":"oh, right. Thanks.","commit_id":"806afb0d1390d8cf4b1028db313b1171632ed08f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"43e036d73c993b113da8f9e3f2954af26acc8064","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        # TODO(andreaf) Temporary set needed until all services are migrated"},{"line_number":374,"context_line":"        _non_migrated_services \u003d tempest_modules() - set("},{"line_number":375,"context_line":"            [\u0027compute\u0027, \u0027network\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027])"},{"line_number":376,"context_line":"        return self._registered_services | _non_migrated_services"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def _setup_parameters(self, parameters):"},{"line_number":379,"context_line":"        \"\"\"Setup default values for client parameters"}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_de828551","line":376,"range":{"start_line":376,"start_character":43,"end_line":376,"end_character":65},"in_reply_to":"dada55a8_f1d233ff","updated":"2016-07-26 14:43:19.000000000","message":"It will returned all services registered via the new interface plus services which are simply available via the old mechanism.","commit_id":"806afb0d1390d8cf4b1028db313b1171632ed08f"}],"tempest/tests/test_service_clients.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"981b0671be1e3412c3b4e633d8752045246a77b5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        expected_params \u003d {\u0027fake_param1\u0027: \u0027fake_value1\u0027,"},{"line_number":269,"context_line":"                           \u0027fake_param2\u0027: \u0027fake_value2\u0027}"},{"line_number":270,"context_line":"        _manager \u003d self._get_manager(init_region\u003d\u0027fake_region_default\u0027)"},{"line_number":271,"context_line":"        # Mock after the _manager is setup to preserve the call count"},{"line_number":272,"context_line":"        factory_mock \u003d self.useFixture(fixtures.MockPatch("},{"line_number":273,"context_line":"            \u0027tempest.service_clients.ClientsFactory\u0027)).mock"},{"line_number":274,"context_line":"        _manager.register_service_client_module("}],"source_content_type":"text/x-python","patch_set":15,"id":"dada55a8_e5fd6d3c","line":271,"updated":"2016-07-25 17:58:43.000000000","message":"You can always just reset() the mock, but ok","commit_id":"806afb0d1390d8cf4b1028db313b1171632ed08f"}]}