)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"695b4e507138424e04da75f047e5a08875332f32","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Domain Actions Test Case-V3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds one testcass test_create_update_delete_domian"},{"line_number":10,"context_line":"to \"test_domains.py\" so as to verfiy create, update, get,"},{"line_number":11,"context_line":"actions on domains"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2FcOQ%3D","line":9,"updated":"2013-07-01 21:24:36.000000000","message":"change \"testcass\" to \"testcase\"","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"cfb2fc483a2985c6d683364bc86df1457283615b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Domain Actions Test Case-V3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds one testcass test_create_update_delete_domian"},{"line_number":10,"context_line":"to \"test_domains.py\" so as to verfiy create, update, get,"},{"line_number":11,"context_line":"actions on domains"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2FXHs%3D","line":9,"in_reply_to":"AAAAPn%2F%2FcOQ%3D","updated":"2013-07-03 10:11:46.000000000","message":"Done","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"695b4e507138424e04da75f047e5a08875332f32","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Domain Actions Test Case-V3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds one testcass test_create_update_delete_domian"},{"line_number":10,"context_line":"to \"test_domains.py\" so as to verfiy create, update, get,"},{"line_number":11,"context_line":"actions on domains"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I10d449bb07d20d681098e95295ca081e8f9172ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2FcOI%3D","line":10,"updated":"2013-07-01 21:24:36.000000000","message":"change \"verfiy\" to \"verify\"","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"cfb2fc483a2985c6d683364bc86df1457283615b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Domain Actions Test Case-V3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission adds one testcass test_create_update_delete_domian"},{"line_number":10,"context_line":"to \"test_domains.py\" so as to verfiy create, update, get,"},{"line_number":11,"context_line":"actions on domains"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I10d449bb07d20d681098e95295ca081e8f9172ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAPn%2F%2FXHo%3D","line":10,"in_reply_to":"AAAAPn%2F%2FcOI%3D","updated":"2013-07-03 10:11:46.000000000","message":"Done","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"}],"tempest/api/identity/admin/v3/test_domains.py":[{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"72c1c026fe2c3808bc327529d1b51576ac5364f8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        self.assertEqual(0, len(missing_doms))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":53,"context_line":"    def test_create_update_delete_domian(self):"},{"line_number":54,"context_line":"        #Test to create update delete domain"},{"line_number":55,"context_line":"        # Create Domain"},{"line_number":56,"context_line":"        d_name \u003d rand_name(\u0027domain-\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2F1yY%3D","line":53,"updated":"2013-06-20 00:56:07.000000000","message":"change domian to domain","commit_id":"e1d8e202f5f7aaeed95e1227221b528fbecf71b2"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"036655725a5daaa4426cb7118ad6134c90f8502a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":53,"context_line":"    def test_create_update_delete_domain(self):"},{"line_number":54,"context_line":"        #Test to create update delete domain"},{"line_number":55,"context_line":"        # Create Domain"},{"line_number":56,"context_line":"        d_name \u003d rand_name(\u0027domain-\u0027)"},{"line_number":57,"context_line":"        d_desc \u003d rand_name(\u0027domain-desc-\u0027)"},{"line_number":58,"context_line":"        resp_1, domain \u003d self.v3_client.create_domain("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX%2FA%3D","line":55,"updated":"2013-07-03 02:25:58.000000000","message":"This comment above is not necessary, please remove it :) The test name says it all...","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"cfb2fc483a2985c6d683364bc86df1457283615b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @attr(type\u003d\u0027smoke\u0027)"},{"line_number":53,"context_line":"    def test_create_update_delete_domain(self):"},{"line_number":54,"context_line":"        #Test to create update delete domain"},{"line_number":55,"context_line":"        # Create Domain"},{"line_number":56,"context_line":"        d_name \u003d rand_name(\u0027domain-\u0027)"},{"line_number":57,"context_line":"        d_desc \u003d rand_name(\u0027domain-desc-\u0027)"},{"line_number":58,"context_line":"        resp_1, domain \u003d self.v3_client.create_domain("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXHk%3D","line":55,"in_reply_to":"AAAAPn%2F%2FX%2FA%3D","updated":"2013-07-03 10:11:46.000000000","message":"Done","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"c998ea742a03b1821168c9cf3cc3fc8be8a1be55","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertIsNotNone(domain[\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(d_name, domain[\u0027name\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(d_desc, domain[\u0027description\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":71,"context_line":"        # Update Domain"},{"line_number":72,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":73,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fx5I%3D","line":70,"updated":"2013-06-21 12:59:31.000000000","message":"I don\u0027t think user code would do this. The keystone v3 spec says \u0027enabled\u0027 is a json boolean. Shouldn\u0027t we be asserting that\u0027s what we are getting?","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"cfb2fc483a2985c6d683364bc86df1457283615b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertIsNotNone(domain[\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(d_name, domain[\u0027name\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(d_desc, domain[\u0027description\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":71,"context_line":"        # Update Domain"},{"line_number":72,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":73,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXG4%3D","line":70,"in_reply_to":"AAAAPn%2F%2FcQM%3D","updated":"2013-07-03 10:11:46.000000000","message":"I have put a question with my observations on XML Request and response.\n\nref: https://answers.launchpad.net/keystone/+question/231798","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"146a307ec92de9277fac6f9e4a532b28ef13c4ee","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertIsNotNone(domain[\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(d_name, domain[\u0027name\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(d_desc, domain[\u0027description\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":71,"context_line":"        # Update Domain"},{"line_number":72,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":73,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FcQM%3D","line":70,"in_reply_to":"AAAAPn%2F%2FhaA%3D","updated":"2013-07-01 21:22:13.000000000","message":"create_domain calls self._parse_body(etree.fromstring(body)), see\n\n https://github.com/openstack/tempest/blob/master/tempest/services/identity/v3/xml/identity_client.py#L208\n\nWhich calls xml_to_json(),\n\n https://github.com/openstack/tempest/blob/master/tempest/services/compute/xml/common.py#L95\n\nxml_to_json is \"braindead\", it can\u0027t know that the \"enabled\" attribute in the response XML is a Boolean and not a string, and none of the other code bothers to correct it.\n\nI don\u0027t think Keystone is doing anything wrong here.","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f157573df121a025c1056c01d7d2308c6222f18c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertIsNotNone(domain[\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(d_name, domain[\u0027name\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(d_desc, domain[\u0027description\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":71,"context_line":"        # Update Domain"},{"line_number":72,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":73,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FhaA%3D","line":70,"in_reply_to":"AAAAPn%2F%2Fx3g%3D","updated":"2013-06-28 15:49:53.000000000","message":"Harika, that actually sounds like a keystone bug. Can you register it against them?","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"d373cafd0d62c7efc8fbf35bf9b114561996f776","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertIsNotNone(domain[\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(d_name, domain[\u0027name\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(d_desc, domain[\u0027description\u0027])"},{"line_number":70,"context_line":"        self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":71,"context_line":"        # Update Domain"},{"line_number":72,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":73,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fx3g%3D","line":70,"in_reply_to":"AAAAPn%2F%2Fx5I%3D","updated":"2013-06-21 13:13:50.000000000","message":"Hi David, If enabled response is not converted to lower, the test case would be failed in case of XML interface. To be generic I have converted what ever the response type to be string(lower case). Please let me know, if it is an issue in the case of XML interface.\n\nJSON Interface : we are observing \u0027True\u0027\nXML Interface: we are observing \u0027true\u0027","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"036655725a5daaa4426cb7118ad6134c90f8502a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(new_name, updated_domain[\u0027name\u0027])"},{"line_number":84,"context_line":"        self.assertEqual(new_desc, updated_domain[\u0027description\u0027])"},{"line_number":85,"context_line":"        self.assertEqual(\u0027true\u0027, str(updated_domain[\u0027enabled\u0027]).lower())"},{"line_number":86,"context_line":"        #Assertion for updated value with fetched value"},{"line_number":87,"context_line":"        resp_3, fetched_domain \u003d self.v3_client.get_domain(domain[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(resp_3[\u0027status\u0027], \u0027200\u0027)"},{"line_number":89,"context_line":"        self.assertEqual(new_name, fetched_domain[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX%2B8%3D","line":86,"updated":"2013-07-03 02:25:58.000000000","message":"I\u0027m not sure this comment or the # Update domain comment above are useful, since the code itself is self explanatory... comments should generally add insight into what the code is doing that is not obvious or apparent from the code itself...","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"cfb2fc483a2985c6d683364bc86df1457283615b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.assertEqual(new_name, updated_domain[\u0027name\u0027])"},{"line_number":84,"context_line":"        self.assertEqual(new_desc, updated_domain[\u0027description\u0027])"},{"line_number":85,"context_line":"        self.assertEqual(\u0027true\u0027, str(updated_domain[\u0027enabled\u0027]).lower())"},{"line_number":86,"context_line":"        #Assertion for updated value with fetched value"},{"line_number":87,"context_line":"        resp_3, fetched_domain \u003d self.v3_client.get_domain(domain[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(resp_3[\u0027status\u0027], \u0027200\u0027)"},{"line_number":89,"context_line":"        self.assertEqual(new_name, fetched_domain[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXHg%3D","line":86,"in_reply_to":"AAAAPn%2F%2FX%2B8%3D","updated":"2013-07-03 10:11:46.000000000","message":"Done","commit_id":"1608560876c7ba4e803218b54601dc38587b082d"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7314331ebe40552c8ddcb7159f9007d4e57c0aaa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":73,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":74,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"},{"line_number":75,"context_line":"        resp_2, updated_domain \u003d self.v3_client.update_domain("},{"line_number":76,"context_line":"            domain[\u0027id\u0027], name\u003dnew_name, description\u003dnew_desc)"},{"line_number":77,"context_line":"        self.assertEqual(resp_2[\u0027status\u0027], \u0027200\u0027)"},{"line_number":78,"context_line":"        self.assertIn(\u0027id\u0027, updated_domain)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F8eI%3D","line":75,"updated":"2013-07-08 19:10:42.000000000","message":"please throw a space before this line, just to make it easier to understand we\u0027re onto a new call.","commit_id":"df6ddf9c537893f9570febd58222bbefc8521837"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"837146790a33b80b230d675c16dbc98523ac3c77","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            self.assertEqual(\u0027true\u0027, str(domain[\u0027enabled\u0027]).lower())"},{"line_number":73,"context_line":"        new_desc \u003d rand_name(\u0027new-desc-\u0027)"},{"line_number":74,"context_line":"        new_name \u003d rand_name(\u0027new-name-\u0027)"},{"line_number":75,"context_line":"        resp_2, updated_domain \u003d self.v3_client.update_domain("},{"line_number":76,"context_line":"            domain[\u0027id\u0027], name\u003dnew_name, description\u003dnew_desc)"},{"line_number":77,"context_line":"        self.assertEqual(resp_2[\u0027status\u0027], \u0027200\u0027)"},{"line_number":78,"context_line":"        self.assertIn(\u0027id\u0027, updated_domain)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F68M%3D","line":75,"in_reply_to":"AAAAP3%2F%2F8eI%3D","updated":"2013-07-09 06:29:23.000000000","message":"Done","commit_id":"df6ddf9c537893f9570febd58222bbefc8521837"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7314331ebe40552c8ddcb7159f9007d4e57c0aaa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.assertEqual(new_name, updated_domain[\u0027name\u0027])"},{"line_number":85,"context_line":"        self.assertEqual(new_desc, updated_domain[\u0027description\u0027])"},{"line_number":86,"context_line":"        self.assertEqual(\u0027true\u0027, str(updated_domain[\u0027enabled\u0027]).lower())"},{"line_number":87,"context_line":"        resp_3, fetched_domain \u003d self.v3_client.get_domain(domain[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(resp_3[\u0027status\u0027], \u0027200\u0027)"},{"line_number":89,"context_line":"        self.assertEqual(new_name, fetched_domain[\u0027name\u0027])"},{"line_number":90,"context_line":"        self.assertEqual(new_desc, fetched_domain[\u0027description\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F8eE%3D","line":87,"updated":"2013-07-08 19:10:42.000000000","message":"add break here as well, same reason as above.","commit_id":"df6ddf9c537893f9570febd58222bbefc8521837"},{"author":{"_account_id":6455,"name":"Harika Vakadi","email":"harika_vakadi@persistent.co.in","username":"harika-vakadi"},"change_message_id":"837146790a33b80b230d675c16dbc98523ac3c77","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.assertEqual(new_name, updated_domain[\u0027name\u0027])"},{"line_number":85,"context_line":"        self.assertEqual(new_desc, updated_domain[\u0027description\u0027])"},{"line_number":86,"context_line":"        self.assertEqual(\u0027true\u0027, str(updated_domain[\u0027enabled\u0027]).lower())"},{"line_number":87,"context_line":"        resp_3, fetched_domain \u003d self.v3_client.get_domain(domain[\u0027id\u0027])"},{"line_number":88,"context_line":"        self.assertEqual(resp_3[\u0027status\u0027], \u0027200\u0027)"},{"line_number":89,"context_line":"        self.assertEqual(new_name, fetched_domain[\u0027name\u0027])"},{"line_number":90,"context_line":"        self.assertEqual(new_desc, fetched_domain[\u0027description\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F68I%3D","line":87,"in_reply_to":"AAAAP3%2F%2F8eE%3D","updated":"2013-07-09 06:29:23.000000000","message":"Done","commit_id":"df6ddf9c537893f9570febd58222bbefc8521837"}]}