)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":10016,"name":"Joseph Lanoux","email":"joseph.lanoux@hpe.com","username":"lanoux"},"change_message_id":"37865ee513bc7e699785c8d345096b689df78af0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    multiple_create_request \u003d (max(kwargs.get(\u0027min_count\u0027, 0),"},{"line_number":63,"context_line":"                                   kwargs.get(\u0027max_count\u0027, 0)) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    delete_on_termination \u003d kwargs.get(\u0027delete_on_termination\u0027, True)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if CONF.validation.run_validation and validatable:"},{"line_number":68,"context_line":"        # As a first implementation, multiple pingable or sshable servers will"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_db84ff0c","line":65,"updated":"2016-07-01 14:43:52.000000000","message":"I would prefer to see this as an explicit argument and not in kwargs. We\u0027re trying to get away from kwargs as it makes things harder to debug.","commit_id":"8b770a472571f2d3f44210acd3965f30c71684e2"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"26f256a87131586ad726fdd2ff1ace9d9c1bb005","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    multiple_create_request \u003d (max(kwargs.get(\u0027min_count\u0027, 0),"},{"line_number":63,"context_line":"                                   kwargs.get(\u0027max_count\u0027, 0)) \u003e 1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    delete_on_termination \u003d kwargs.get(\u0027delete_on_termination\u0027, True)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if CONF.validation.run_validation and validatable:"},{"line_number":68,"context_line":"        # As a first implementation, multiple pingable or sshable servers will"}],"source_content_type":"text/x-python","patch_set":1,"id":"3aaa91ec_615d5c15","line":65,"in_reply_to":"3aaa91ec_db84ff0c","updated":"2016-07-01 15:10:09.000000000","message":"Done","commit_id":"8b770a472571f2d3f44210acd3965f30c71684e2"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"a9e23903747025c8607688bdfac8b386f4602592","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def create_test_server(clients, validatable\u003dFalse, validation_resources\u003dNone,"},{"line_number":31,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":32,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":33,"context_line":"                       image_id\u003dNone, delete_on_termination\u003dTrue,"},{"line_number":34,"context_line":"                       **kwargs):"},{"line_number":35,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d0e8feb6","line":33,"updated":"2016-07-05 13:17:13.000000000","message":"What about renaming this to \u0027delete_volume_on_termination\u0027. Otherwise one could think that the kw param applies to the newly created server, not the volume.","commit_id":"c5e8f41ed7bed499c08e09dd8cd8506c563d2adc"},{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"acda16afc1cbdbba918ff51e6b96d616667a4bf3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"def create_test_server(clients, validatable\u003dFalse, validation_resources\u003dNone,"},{"line_number":31,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":32,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":33,"context_line":"                       image_id\u003dNone, delete_on_termination\u003dTrue,"},{"line_number":34,"context_line":"                       **kwargs):"},{"line_number":35,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_50e7eeaf","line":33,"in_reply_to":"1aa78d24_d0e8feb6","updated":"2016-07-05 13:25:54.000000000","message":"for the sake of clarity I am going to change it but for the sake of brevity I am going to call it delete_vol_on_termination","commit_id":"c5e8f41ed7bed499c08e09dd8cd8506c563d2adc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"0bf0dfd0858d95356f2cbca8a040052a96609a4e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    :param tenant_network: Tenant network to be used for creating a server."},{"line_number":45,"context_line":"    :param wait_until: Server status to wait for the server to reach after"},{"line_number":46,"context_line":"    its creation."},{"line_number":47,"context_line":"    :param volume_backed: Whether the instance is volume backed or not."},{"line_number":48,"context_line":"    :returns: a tuple"},{"line_number":49,"context_line":"    \"\"\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_b178bdc5","line":47,"updated":"2016-07-05 21:04:56.000000000","message":"TBH, I wanted to see the change here to add a new arg.\nBut current docstring already gets old as you see, so it is fine for me at this time and good to add it with updating the other args.","commit_id":"c4b0e0091b16773b8180946c73f789cc429673e8"}]}