)]}'
{"tempest/api/compute/admin/test_servers_v23.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"986151895921eec039bff597cbf997dd60c7fbb6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_35a2f0fd","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":26},"updated":"2016-07-06 01:49:22.000000000","message":"because of coping from the original?","commit_id":"1d6f3b04a25c6a8dcfef30e866f4b8a5fbb939e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"128035b1b36e0c3b8c1f4660edf4c4898df4d3d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_b0126e55","line":1,"range":{"start_line":1,"start_character":2,"end_line":1,"end_character":26},"in_reply_to":"1aa78d24_35a2f0fd","updated":"2016-07-06 02:22:58.000000000","message":"ops, Done","commit_id":"1d6f3b04a25c6a8dcfef30e866f4b8a5fbb939e1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"986151895921eec039bff597cbf997dd60c7fbb6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ServersAdminV23TestJSON(base.BaseV2ComputeAdminTest):"},{"line_number":21,"context_line":"    \"\"\"Tests Servers API for compute microversion 2.3\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    min_microversion \u003d \u00272.3\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_757f5866","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":29},"updated":"2016-07-06 01:49:22.000000000","message":"If this test is just for verifying a response with JSON-Schema, can we use the existing test class by switching JSON-Schema without a new test class ?","commit_id":"1d6f3b04a25c6a8dcfef30e866f4b8a5fbb939e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"128035b1b36e0c3b8c1f4660edf4c4898df4d3d5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest import test"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ServersAdminV23TestJSON(base.BaseV2ComputeAdminTest):"},{"line_number":21,"context_line":"    \"\"\"Tests Servers API for compute microversion 2.3\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    min_microversion \u003d \u00272.3\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_700c863b","line":20,"range":{"start_line":20,"start_character":6,"end_line":20,"end_character":29},"in_reply_to":"1aa78d24_757f5866","updated":"2016-07-06 02:22:58.000000000","message":"actually i tried to find if we have only GET tests in separate file but could not find and i do not want to run unnecessary duplicate tests for version 2.3","commit_id":"1d6f3b04a25c6a8dcfef30e866f4b8a5fbb939e1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"986151895921eec039bff597cbf997dd60c7fbb6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":34,"context_line":"        server \u003d self.create_test_server(name\u003dname,"},{"line_number":35,"context_line":"                                         wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":36,"context_line":"        # JSON schema verify whether all required extended attributes"},{"line_number":37,"context_line":"        # are present in response of version 2.3."},{"line_number":38,"context_line":"        self.server_client.show_server(server[\u0027id\u0027])"},{"line_number":39,"context_line":"        servers \u003d self.server_client.list_servers(detail\u003dTrue, all_tenants\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_95a3e4ff","line":36,"range":{"start_line":36,"start_character":22,"end_line":36,"end_character":28},"updated":"2016-07-06 01:49:22.000000000","message":"nit: verifies","commit_id":"1d6f3b04a25c6a8dcfef30e866f4b8a5fbb939e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"128035b1b36e0c3b8c1f4660edf4c4898df4d3d5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":34,"context_line":"        server \u003d self.create_test_server(name\u003dname,"},{"line_number":35,"context_line":"                                         wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":36,"context_line":"        # JSON schema verify whether all required extended attributes"},{"line_number":37,"context_line":"        # are present in response of version 2.3."},{"line_number":38,"context_line":"        self.server_client.show_server(server[\u0027id\u0027])"},{"line_number":39,"context_line":"        servers \u003d self.server_client.list_servers(detail\u003dTrue, all_tenants\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_f0187677","line":36,"range":{"start_line":36,"start_character":22,"end_line":36,"end_character":28},"in_reply_to":"1aa78d24_95a3e4ff","updated":"2016-07-06 02:22:58.000000000","message":"Thanks Done","commit_id":"1d6f3b04a25c6a8dcfef30e866f4b8a5fbb939e1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d78666d3ab4ba6deccb7a7403b7a3913fdfac929","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        name \u003d data_utils.rand_name(\u0027server\u0027)"},{"line_number":34,"context_line":"        server \u003d self.create_test_server(name\u003dname,"},{"line_number":35,"context_line":"                                         wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":36,"context_line":"        # JSON schema verifies whether all required extended attributes"},{"line_number":37,"context_line":"        # are present in response of version 2.3."},{"line_number":38,"context_line":"        self.server_client.show_server(server[\u0027id\u0027])"},{"line_number":39,"context_line":"        servers \u003d self.server_client.list_servers(detail\u003dTrue, all_tenants\u003d\u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_74ca2651","line":36,"updated":"2016-07-27 21:11:05.000000000","message":"The microversion added reservation_id, launch_index, ramdisk_id, kernel_id, hostname, root_device_name and userdata on the response. However, this test is not special for these cases. The response is checked on Jsonschema, but it would be nice to add some special tests for this microversion. e.g: specify userdata on create_test_server() and verify the same userdata on the response.","commit_id":"6f32e9819108bece66ae3cda1cc7fde0dd49a5d5"}],"tempest/lib/api_schema/response/compute/v2_3/servers.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"8bf803961c1dfa24159499e96c87f2ed48242b68","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import servers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"server_detail \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_3b19287a","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"updated":"2016-07-06 12:15:42.000000000","message":"what is the reason for redefining this? why not to deepcopy one from 2.1? see https://review.openstack.org/#/c/338201/ for example","commit_id":"8b82772e8e582827ce87e5ac7f905b7088ae951e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9ba2aa493fce8455928eaccd2642cddaadb087f5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import servers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"server_detail \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_7cb9c5cb","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"1aa78d24_3b19287a","updated":"2016-07-06 23:42:10.000000000","message":"Yea that\u0027s what we do not want to do for readability reason.\n\nWe have those deepcopy used everywhere which going to be disappear soon. Each schema will be well defined itself so that we do not need to iterate to files/other schema to understand complete response.","commit_id":"8b82772e8e582827ce87e5ac7f905b7088ae951e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0623bb48aa4a1a56699d7c61f1b12b9be8c90b6c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import servers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"server_detail \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_ac937ff9","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"1aa78d24_4e951c31","updated":"2016-07-09 01:04:10.000000000","message":"Yea i agree that this is little bit hard to review. For changes in schema i added comment in schema(# NOTE(gmann): new attributes in version 2.3).\n\nThere are two thing which we need to trade off\n- hard to review when adding new schema which extend the old one - This one is one time effort.\n\n- Easy to read. Later anyone want to see complete schema for debugging or quick glance, it will be present in single place. \n\nIf we use deepcopy, I agree it will be easy to review and see detla but it makes very complicated to understand the complete schema.\nFor example - you cannot understand schema of keypair v2.2 without iterating many schema and files. - https://github.com/openstack/tempest/blob/master/tempest/lib/api_schema/response/compute/v2_2/keypairs.py\n\nFor old schema also i would like to do the same, please check this - https://review.openstack.org/#/c/306245/","commit_id":"8b82772e8e582827ce87e5ac7f905b7088ae951e"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"9ca76f6003a90b837796107a9778ac71ba1cbdab","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import servers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"server_detail \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_d03d35de","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"1aa78d24_7cb9c5cb","updated":"2016-07-07 06:01:02.000000000","message":"I think the current approach with deep copy has the advantage that it highlights what changed - it\u0027s hard to see it with the full schema, and certainly harder to review.\n\nIt should be easy enough to print out the whole schema if needed.","commit_id":"8b82772e8e582827ce87e5ac7f905b7088ae951e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"43bf1041f1da5a373ad553b87bb5d180965e6bb2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import servers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"server_detail \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_cc336b12","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"1aa78d24_ac937ff9","updated":"2016-07-09 01:07:50.000000000","message":"IMO, we should go for better readability here than optimization of schema code. Schema servers the goal of finding the complete response of any API quickly along with finding the difference between versions. and difference can be taken always by comparing the file.","commit_id":"8b82772e8e582827ce87e5ac7f905b7088ae951e"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"de733efe416a95f7fad91aeae9c57b5ac212f808","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import parameter_types"},{"line_number":18,"context_line":"from tempest.lib.api_schema.response.compute.v2_1 import servers"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"server_detail \u003d {"},{"line_number":21,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":22,"context_line":"    \u0027properties\u0027: {"},{"line_number":23,"context_line":"        \u0027id\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_4e951c31","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"1aa78d24_d03d35de","updated":"2016-07-07 10:03:05.000000000","message":"That was my point. I\u0027d like to see a delta between the previous version and the current one. And here it\u0027s hard to find out what exactly was changed","commit_id":"8b82772e8e582827ce87e5ac7f905b7088ae951e"}]}