)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"947bdbb44ab6eb4ca521aaf1f4e24eca4ba8858f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-09-25 07:05:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test case for live migration with iso9660 config drive"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Idef66cd1ba05290232dcd87c60490f2d6f2fa840"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3a98d1f4_2374f033","line":8,"updated":"2016-09-28 21:40:16.000000000","message":"Can we add some more detail to this commit message, explain why we\u0027re adding this or the reason it\u0027s important to add a new test case for live migration with a config drive. Please refer to:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"ecb307f3d4c5594ce9da257ecb034b4027414360"}],"tempest/api/compute/admin/test_live_migration.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ba335a099adb8d859fe3586326eb9fee0eb3fa27","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Live migrate an instance to another host"},{"line_number":101,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\"ACTIVE\","},{"line_number":102,"context_line":"                                            volume_backed\u003dvolume_backed,"},{"line_number":103,"context_line":"                                            config_drive\u003dconfig_drive)[\u0027id\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if config_drive:"},{"line_number":106,"context_line":"            server_details \u003d self._get_server_details(server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_7ee4deaa","line":103,"updated":"2016-07-22 05:43:40.000000000","message":"If the config_drive feature disabled, I think we shouldn\u0027t send this parameter to a nova api server.","commit_id":"b303e1d92505bd4df08f9e3a219ecae17cbd6f4e"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"baf2a53fd0dcaff2aa42cc95e2384282e4cea407","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Live migrate an instance to another host"},{"line_number":101,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\"ACTIVE\","},{"line_number":102,"context_line":"                                            volume_backed\u003dvolume_backed,"},{"line_number":103,"context_line":"                                            config_drive\u003dconfig_drive)[\u0027id\u0027]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        if config_drive:"},{"line_number":106,"context_line":"            server_details \u003d self._get_server_details(server_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_7bd54741","line":103,"in_reply_to":"dada55a8_7ee4deaa","updated":"2016-07-27 06:48:11.000000000","message":"Done","commit_id":"b303e1d92505bd4df08f9e3a219ecae17cbd6f4e"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ba335a099adb8d859fe3586326eb9fee0eb3fa27","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._test_live_migration()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @test.idempotent_id(\u0027a6bffc34-7a7c-4331-8e67-1070861978a3\u0027)"},{"line_number":136,"context_line":"    def test_live_block_migration_with_config_drive(self):"},{"line_number":137,"context_line":"        self._test_live_migration(config_drive\u003dTrue)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @test.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_5edf5ad5","line":136,"updated":"2016-07-22 05:43:40.000000000","message":"I think this test should check the compute_feature_enabled.config_drive setting.","commit_id":"b303e1d92505bd4df08f9e3a219ecae17cbd6f4e"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"baf2a53fd0dcaff2aa42cc95e2384282e4cea407","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._test_live_migration()"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    @test.idempotent_id(\u0027a6bffc34-7a7c-4331-8e67-1070861978a3\u0027)"},{"line_number":136,"context_line":"    def test_live_block_migration_with_config_drive(self):"},{"line_number":137,"context_line":"        self._test_live_migration(config_drive\u003dTrue)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    @test.idempotent_id(\u00271e107f21-61b2-4988-8f22-b196e938ab88\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_dbc8b3aa","line":136,"in_reply_to":"dada55a8_5edf5ad5","updated":"2016-07-27 06:48:11.000000000","message":"Done","commit_id":"b303e1d92505bd4df08f9e3a219ecae17cbd6f4e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aa02f774394a6e1d228c33143c877af6f5ff7e0c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                      after the live migration. Supported values are \u0027ACTIVE\u0027"},{"line_number":102,"context_line":"                      and \u0027PAUSED\u0027."},{"line_number":103,"context_line":"        :param volume_backed: If the instance is volume backed or not. If"},{"line_number":104,"context_line":"                              volume_backed, *block* migration is not used."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # Live migrate an instance to another host"},{"line_number":107,"context_line":"        kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_fe2797c7","line":104,"updated":"2016-07-30 01:09:33.000000000","message":"need to add a new argument docstring here.","commit_id":"bcb5ecb4929ee0552e2f016af495bd673b65cc23"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5023df53ce0e6b9f278aa1ae193ba132dcd7fd92","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                      after the live migration. Supported values are \u0027ACTIVE\u0027"},{"line_number":102,"context_line":"                      and \u0027PAUSED\u0027."},{"line_number":103,"context_line":"        :param volume_backed: If the instance is volume backed or not. If"},{"line_number":104,"context_line":"                              volume_backed, *block* migration is not used."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # Live migrate an instance to another host"},{"line_number":107,"context_line":"        kwargs \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_636baeb7","line":104,"in_reply_to":"bacf61ea_fe2797c7","updated":"2016-08-02 09:20:14.000000000","message":"Done","commit_id":"bcb5ecb4929ee0552e2f016af495bd673b65cc23"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aa02f774394a6e1d228c33143c877af6f5ff7e0c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                              volume_backed, *block* migration is not used."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # Live migrate an instance to another host"},{"line_number":107,"context_line":"        kwargs \u003d {}"},{"line_number":108,"context_line":"        if config_drive:"},{"line_number":109,"context_line":"            kwargs[\u0027config_drive\u0027] \u003d config_drive"},{"line_number":110,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\"ACTIVE\","},{"line_number":111,"context_line":"                                            volume_backed\u003dvolume_backed,"},{"line_number":112,"context_line":"                                            **kwargs)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_f915f13f","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":49},"updated":"2016-07-30 01:09:33.000000000","message":"Why don\u0027t we pass config_drive directly like volume_backed?","commit_id":"bcb5ecb4929ee0552e2f016af495bd673b65cc23"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5023df53ce0e6b9f278aa1ae193ba132dcd7fd92","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                              volume_backed, *block* migration is not used."},{"line_number":105,"context_line":"        \"\"\""},{"line_number":106,"context_line":"        # Live migrate an instance to another host"},{"line_number":107,"context_line":"        kwargs \u003d {}"},{"line_number":108,"context_line":"        if config_drive:"},{"line_number":109,"context_line":"            kwargs[\u0027config_drive\u0027] \u003d config_drive"},{"line_number":110,"context_line":"        server_id \u003d self.create_test_server(wait_until\u003d\"ACTIVE\","},{"line_number":111,"context_line":"                                            volume_backed\u003dvolume_backed,"},{"line_number":112,"context_line":"                                            **kwargs)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_e384be5e","line":109,"range":{"start_line":107,"start_character":0,"end_line":109,"end_character":49},"in_reply_to":"bacf61ea_f915f13f","updated":"2016-08-02 09:20:14.000000000","message":"Done","commit_id":"bcb5ecb4929ee0552e2f016af495bd673b65cc23"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"aa02f774394a6e1d228c33143c877af6f5ff7e0c","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if config_drive:"},{"line_number":115,"context_line":"            server_details \u003d self._get_server_details(server_id)"},{"line_number":116,"context_line":"            self.assertTrue(server_details[\u0027config_drive\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        actual_host \u003d self._get_host_for_server(server_id)"},{"line_number":119,"context_line":"        target_host \u003d self._get_host_other_than(actual_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_d912ad56","line":116,"updated":"2016-07-30 01:09:33.000000000","message":"nice to check this response when a test case which disables config_drive also.","commit_id":"bcb5ecb4929ee0552e2f016af495bd673b65cc23"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5023df53ce0e6b9f278aa1ae193ba132dcd7fd92","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if config_drive:"},{"line_number":115,"context_line":"            server_details \u003d self._get_server_details(server_id)"},{"line_number":116,"context_line":"            self.assertTrue(server_details[\u0027config_drive\u0027])"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        actual_host \u003d self._get_host_for_server(server_id)"},{"line_number":119,"context_line":"        target_host \u003d self._get_host_other_than(actual_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_a3b8062b","line":116,"in_reply_to":"bacf61ea_d912ad56","updated":"2016-08-02 09:20:14.000000000","message":"Done","commit_id":"bcb5ecb4929ee0552e2f016af495bd673b65cc23"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f081f106ad23d7358daf1144abaf1f19afd9b181","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    @test.idempotent_id(\u0027a6bffc34-7a7c-4331-8e67-1070861978a3\u0027)"},{"line_number":134,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.config_drive,"},{"line_number":135,"context_line":"                          \u0027Config drive is not available\u0027)"},{"line_number":136,"context_line":"    def test_live_block_migration_with_config_drive(self):"},{"line_number":137,"context_line":"        self._test_live_migration(config_drive\u003dTrue)"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a461143_179577e3","line":135,"updated":"2017-01-26 06:10:51.000000000","message":"I\u0027m worried about the case of the version is Mitaka(or older) and \u0027compute_feature_enabled.config_drive\u003dTrue\u0027. If Nova supports this config_drive\u0026live_migration feature from Newton only, I guess this test would fail in that case.","commit_id":"fda40f160aadd044f2ba181d2d45d580a0e57070"}]}