)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"a7131b228bcecd54ffff39a7da49d57c1f2308b6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(ServersAdminTestJSON, cls).setUpClass()"},{"line_number":35,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":36,"context_line":"        cls.non_admin_client \u003d cls.servers_client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        images_client \u003d cls.images_client"},{"line_number":39,"context_line":"        resp, images \u003d images_client.list_images()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FwMI%3D","line":36,"updated":"2013-06-22 05:42:05.000000000","message":"cls.os.servers_client also could be usable here.","commit_id":"f6bfb2a3a38f4f743dff609670e1ce2b0ef28bb7"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"868df7d153d471bdf016316143d349bb6344a9df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    def setUpClass(cls):"},{"line_number":34,"context_line":"        super(ServersAdminTestJSON, cls).setUpClass()"},{"line_number":35,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":36,"context_line":"        cls.non_admin_client \u003d cls.servers_client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        images_client \u003d cls.images_client"},{"line_number":39,"context_line":"        resp, images \u003d images_client.list_images()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FuOU%3D","line":36,"in_reply_to":"AAAAPn%2F%2FwMI%3D","updated":"2013-06-24 13:44:28.000000000","message":"fix in patch set 3","commit_id":"f6bfb2a3a38f4f743dff609670e1ce2b0ef28bb7"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"a7131b228bcecd54ffff39a7da49d57c1f2308b6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":82,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.assertIn(self.s1_name, map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":85,"context_line":"        self.assertIn(self.s2_name, map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FwMM%3D","line":84,"updated":"2013-06-22 05:42:05.000000000","message":"The same map/lambda expression twice, can you use an additional variable and write the expression once ?","commit_id":"f6bfb2a3a38f4f743dff609670e1ce2b0ef28bb7"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"868df7d153d471bdf016316143d349bb6344a9df","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        resp, body \u003d self.client.list_servers_with_detail(params)"},{"line_number":82,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.assertIn(self.s1_name, map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":85,"context_line":"        self.assertIn(self.s2_name, map(lambda x: x[\u0027name\u0027], servers))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FuOM%3D","line":84,"in_reply_to":"AAAAPn%2F%2FwMM%3D","updated":"2013-06-24 13:44:28.000000000","message":"fix in patch set 3","commit_id":"f6bfb2a3a38f4f743dff609670e1ce2b0ef28bb7"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"7ad09905426a9b83cc6ce24f896ae062fd78711e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ft%2Bk%3D","line":3,"updated":"2013-06-24 15:23:23.000000000","message":"I think this should be removed.\n\nIf it is kept, it needs to be updated.   The year and company are wrong.\n\nhttps://wiki.openstack.org/wiki/LegalIssuesFAQ","commit_id":"cb276c4bf80a0cd9ae713995253204fbcb254f6b"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"59fdf07835645128a2e632761c302aa5d8da77e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FpTA%3D","line":3,"in_reply_to":"AAAAPn%2F%2Ft%2Bk%3D","updated":"2013-06-26 01:56:36.000000000","message":"fixed in patch set 4","commit_id":"cb276c4bf80a0cd9ae713995253204fbcb254f6b"},{"author":{"_account_id":6601,"name":"James Carey","email":"jecarey@yerac.com","username":"jecarey"},"change_message_id":"7ad09905426a9b83cc6ce24f896ae062fd78711e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ft%2Bs%3D","line":4,"updated":"2013-06-24 15:23:23.000000000","message":"This is no longer used with new copyright notices, so it should be removed.","commit_id":"cb276c4bf80a0cd9ae713995253204fbcb254f6b"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"59fdf07835645128a2e632761c302aa5d8da77e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FpS8%3D","line":4,"in_reply_to":"AAAAPn%2F%2Ft%2Bs%3D","updated":"2013-06-26 01:56:36.000000000","message":"fixed in patch set 4","commit_id":"cb276c4bf80a0cd9ae713995253204fbcb254f6b"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"9937b01fc525133823949245de76adaf63e5f5ea","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                               cls.image_ref)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls.s1_name \u003d rand_name(\u0027server\u0027)"},{"line_number":45,"context_line":"        resp, cls.s1 \u003d cls.non_admin_client.create_server(cls.s1_name,"},{"line_number":46,"context_line":"                                                          cls.image_ref,"},{"line_number":47,"context_line":"                                                          cls.flavor_ref)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FoV0%3D","line":45,"updated":"2013-06-26 12:31:07.000000000","message":"Perhaps it would be better to call cls.create_server instead which will handle the cleanup implicitly as part of the tearDownClass (see tempest/api/compute/base.py)","commit_id":"5d5314aedc5a712aac2e28e727a3f137936015a3"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"c38982b4d65e729fa27c0f5ac3c0087b69fb5705","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                               cls.image_ref)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        cls.s1_name \u003d rand_name(\u0027server\u0027)"},{"line_number":45,"context_line":"        resp, cls.s1 \u003d cls.non_admin_client.create_server(cls.s1_name,"},{"line_number":46,"context_line":"                                                          cls.image_ref,"},{"line_number":47,"context_line":"                                                          cls.flavor_ref)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fn8E%3D","line":45,"in_reply_to":"AAAAPn%2F%2FoV0%3D","updated":"2013-06-26 14:39:07.000000000","message":"fix it in patch set 5","commit_id":"5d5314aedc5a712aac2e28e727a3f137936015a3"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"e9ac69158c493cbd2d2b3cec3c59c8ac50bb88ad","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUpClass(cls):"},{"line_number":31,"context_line":"        super(ServersAdminTestJSON, cls).setUpClass()"},{"line_number":32,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":33,"context_line":"        cls.non_admin_client \u003d cls.os.servers_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        images_client \u003d cls.images_client"},{"line_number":36,"context_line":"        resp, images \u003d images_client.list_images()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FnMg%3D","line":33,"updated":"2013-06-26 18:46:38.000000000","message":"non_admin_client is not used.","commit_id":"56f7abcc7454c9a695d419af08ddcee4c5577ec8"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"943eebe9b6293f6727ea0ab2665dc7a4f1138608","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUpClass(cls):"},{"line_number":31,"context_line":"        super(ServersAdminTestJSON, cls).setUpClass()"},{"line_number":32,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":33,"context_line":"        cls.non_admin_client \u003d cls.os.servers_client"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        images_client \u003d cls.images_client"},{"line_number":36,"context_line":"        resp, images \u003d images_client.list_images()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2FmYs%3D","line":33,"in_reply_to":"AAAAPn%2F%2FnMg%3D","updated":"2013-06-26 23:24:17.000000000","message":"fix it in patch set 6","commit_id":"56f7abcc7454c9a695d419af08ddcee4c5577ec8"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1134d884427ccdbc2e783d0773232b7bb51f2e41","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(ServersAdminTestJSON, cls).setUpClass()"},{"line_number":34,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        images_client \u003d cls.images_client"},{"line_number":37,"context_line":"        resp, images \u003d images_client.list_images()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fkxk%3D","line":36,"updated":"2013-06-27 14:47:32.000000000","message":"not sure why you are doing this, this isn\u0027t used again.","commit_id":"db1a9362712fe951e6c1ff910ab05f0f83e5b8d7"},{"author":{"_account_id":7139,"name":"Zhi Kun Liu","username":"zhikunliu","inactive":true},"change_message_id":"908e354b0707e5577f8766b5151901e0ad0031c8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        super(ServersAdminTestJSON, cls).setUpClass()"},{"line_number":34,"context_line":"        cls.client \u003d cls.os_adm.servers_client"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        images_client \u003d cls.images_client"},{"line_number":37,"context_line":"        resp, images \u003d images_client.list_images()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2Fkv8%3D","line":36,"in_reply_to":"AAAAPn%2F%2Fkxk%3D","updated":"2013-06-27 14:52:39.000000000","message":"don\u0027t need it. remove it in patch set 8","commit_id":"db1a9362712fe951e6c1ff910ab05f0f83e5b8d7"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"1134d884427ccdbc2e783d0773232b7bb51f2e41","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        resp, images \u003d images_client.list_images()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            cls.images_client.get_image(cls.image_ref)"},{"line_number":41,"context_line":"        except exceptions.NotFound:"},{"line_number":42,"context_line":"            raise RuntimeError(\"Image %s (image_ref) was not found!\" %"},{"line_number":43,"context_line":"                               cls.image_ref)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPn%2F%2FkxE%3D","line":40,"updated":"2013-06-27 14:47:32.000000000","message":"I don\u0027t understand any of the reason for the image gets in here.","commit_id":"db1a9362712fe951e6c1ff910ab05f0f83e5b8d7"}]}