)]}'
{"tempest/api/volume/admin/test_volumes_backup.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"60b5dca9833f348ae7486e1619c604a975ab77ae","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                                         \u0027available\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class VolumesBackupsAdminV2TResetTest(base.BaseVolumeAdminTest):"},{"line_number":171,"context_line":"    \"\"\"Test backup reset state in V2 version\"\"\""},{"line_number":172,"context_line":"    @classmethod"},{"line_number":173,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_4263911a","line":170,"updated":"2016-07-11 15:01:54.000000000","message":"Why do you introduce a new class here ?\n\nThis duplicates some code.","commit_id":"eca58ab986ae12ae21e1fe58ab425b8d0930bbd9"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"7563c5ade038a37edba21d3a9ecd5d2c6288115b","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                                                         \u0027available\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class VolumesBackupsAdminV2TResetTest(base.BaseVolumeAdminTest):"},{"line_number":171,"context_line":"    \"\"\"Test backup reset state in V2 version\"\"\""},{"line_number":172,"context_line":"    @classmethod"},{"line_number":173,"context_line":"    def skip_checks(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_f86cea9d","line":170,"in_reply_to":"1aa78d24_4263911a","updated":"2016-07-11 15:23:31.000000000","message":"From the documention it looks like its only V2 version , So we need to skip version 1 . Do we have other way to do it ?","commit_id":"eca58ab986ae12ae21e1fe58ab425b8d0930bbd9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"60b5dca9833f348ae7486e1619c604a975ab77ae","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        # reset backup state to error"},{"line_number":197,"context_line":"        self.admin_backups_client.reset_backup_status(backup_id\u003dbackup[\u0027id\u0027],"},{"line_number":198,"context_line":"                                                      status\u003d\"error\")"},{"line_number":199,"context_line":"        self.admin_backups_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":200,"context_line":"                                                         \u0027error\u0027)"},{"line_number":201,"context_line":"        # verify backup state changed to error"},{"line_number":202,"context_line":"        backup_info \u003d self.admin_backups_client.show_backup("}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_8509032f","line":199,"updated":"2016-07-11 15:01:54.000000000","message":"If you wait here, then there\u0027s no need to check L202, you already got the expected status.","commit_id":"eca58ab986ae12ae21e1fe58ab425b8d0930bbd9"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"7563c5ade038a37edba21d3a9ecd5d2c6288115b","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        # reset backup state to error"},{"line_number":197,"context_line":"        self.admin_backups_client.reset_backup_status(backup_id\u003dbackup[\u0027id\u0027],"},{"line_number":198,"context_line":"                                                      status\u003d\"error\")"},{"line_number":199,"context_line":"        self.admin_backups_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":200,"context_line":"                                                         \u0027error\u0027)"},{"line_number":201,"context_line":"        # verify backup state changed to error"},{"line_number":202,"context_line":"        backup_info \u003d self.admin_backups_client.show_backup("}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_f89fca5c","line":199,"in_reply_to":"1aa78d24_8509032f","updated":"2016-07-11 15:23:31.000000000","message":"I got into issue when the reset status worked but it took a second to get into error state . waiting to \"error\" state solved this issue .","commit_id":"eca58ab986ae12ae21e1fe58ab425b8d0930bbd9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"86b847ea28938d67d79835229e972d8a976db157","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                                      status\u003d\"error\")"},{"line_number":184,"context_line":"        self.admin_backups_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":185,"context_line":"                                                         \u0027error\u0027)"},{"line_number":186,"context_line":"        # verify backup status changed to error"},{"line_number":187,"context_line":"        backup_info \u003d self.admin_backups_client.show_backup("},{"line_number":188,"context_line":"            backup_id\u003dbackup[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":189,"context_line":"        self.assertEqual(backup_info[\u0027status\u0027], \"error\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_e1136963","line":186,"updated":"2016-07-12 11:43:24.000000000","message":"What I meant it, yes you have to wait using \"wait_for_backup_status\" but then the following call to show_backup is useless because it\u0027s already called as part of the \"wait_for_backup_status method. Please check the code of \"wait_for_backup_status\".","commit_id":"2984ed686bac378706de9804a29e7691ee634af8"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"89a7585c5d28a81990fd7359ac9421fe25e7280f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                                      status\u003d\"error\")"},{"line_number":184,"context_line":"        self.admin_backups_client.wait_for_backup_status(backup[\u0027id\u0027],"},{"line_number":185,"context_line":"                                                         \u0027error\u0027)"},{"line_number":186,"context_line":"        # verify backup status changed to error"},{"line_number":187,"context_line":"        backup_info \u003d self.admin_backups_client.show_backup("},{"line_number":188,"context_line":"            backup_id\u003dbackup[\u0027id\u0027])[\u0027backup\u0027]"},{"line_number":189,"context_line":"        self.assertEqual(backup_info[\u0027status\u0027], \"error\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"1aa78d24_7a80b7bf","line":186,"in_reply_to":"1aa78d24_e1136963","updated":"2016-07-12 14:01:19.000000000","message":"Yes , you are right . my mistake .","commit_id":"2984ed686bac378706de9804a29e7691ee634af8"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f58917e13fcec8e42d28f1c8a0290d9436ee357c","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def test_volume_backup_reset_status(self):"},{"line_number":171,"context_line":"        # Create backup"},{"line_number":172,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":173,"context_line":"        create_backup \u003d self.admin_backups_client.create_backup"},{"line_number":174,"context_line":"        backup \u003d create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":175,"context_line":"                               name\u003dbackup_name)[\u0027backup\u0027]"},{"line_number":176,"context_line":"        self.addCleanup(self.admin_backups_client.delete_backup,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_2eda5017","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":21},"updated":"2016-07-13 05:20:49.000000000","message":"Why to separate the command, you can simply do: \nbackup \u003d self.admin_backups_client.create_backup(\n    volume_id\u003dself.volume[\u0027id\u0027], name\u003dbackup_name)[\u0027backup\u0027]","commit_id":"eb8a556af1e630c32d58972e6d65da59e5cf9336"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"8a73cfdf5e2228c2e835b364d3a1270c44fad053","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def test_volume_backup_reset_status(self):"},{"line_number":171,"context_line":"        # Create backup"},{"line_number":172,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":173,"context_line":"        create_backup \u003d self.admin_backups_client.create_backup"},{"line_number":174,"context_line":"        backup \u003d create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":175,"context_line":"                               name\u003dbackup_name)[\u0027backup\u0027]"},{"line_number":176,"context_line":"        self.addCleanup(self.admin_backups_client.delete_backup,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_719d59bb","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":21},"in_reply_to":"1aa78d24_2eda5017","updated":"2016-07-13 05:38:26.000000000","message":"Thanks for your comment , same code is used in other backup tests.\nI dont see much difference but if it\u0027s annoying i can fix it on next patch.\n\nBenny","commit_id":"eb8a556af1e630c32d58972e6d65da59e5cf9336"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"889fda350f635d784f260312b45ee13812c0438a","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def test_volume_backup_reset_status(self):"},{"line_number":171,"context_line":"        # Create backup"},{"line_number":172,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":173,"context_line":"        create_backup \u003d self.admin_backups_client.create_backup"},{"line_number":174,"context_line":"        backup \u003d create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":175,"context_line":"                               name\u003dbackup_name)[\u0027backup\u0027]"},{"line_number":176,"context_line":"        self.addCleanup(self.admin_backups_client.delete_backup,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_93fc4573","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":21},"in_reply_to":"1aa78d24_719d59bb","updated":"2016-07-13 08:31:59.000000000","message":"It\u0027s minor I know but it annoys me a bit. It introduces a new variable that I (as a reviewer) have to remember the purpose and it creates an alias to a function for no good reason. \n\nI think changing this should take only 2min, so please if you can do it it would be great.","commit_id":"eb8a556af1e630c32d58972e6d65da59e5cf9336"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"7b1a81e148508d27e6b53d179e74ce620ba2b41f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def test_volume_backup_reset_status(self):"},{"line_number":171,"context_line":"        # Create backup"},{"line_number":172,"context_line":"        backup_name \u003d data_utils.rand_name(\u0027Backup\u0027)"},{"line_number":173,"context_line":"        create_backup \u003d self.admin_backups_client.create_backup"},{"line_number":174,"context_line":"        backup \u003d create_backup(volume_id\u003dself.volume[\u0027id\u0027],"},{"line_number":175,"context_line":"                               name\u003dbackup_name)[\u0027backup\u0027]"},{"line_number":176,"context_line":"        self.addCleanup(self.admin_backups_client.delete_backup,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_ab6f4529","line":173,"range":{"start_line":173,"start_character":8,"end_line":173,"end_character":21},"in_reply_to":"1aa78d24_93fc4573","updated":"2016-07-13 10:01:38.000000000","message":"Fixing it \nThanks .\nBenny","commit_id":"eb8a556af1e630c32d58972e6d65da59e5cf9336"}]}