)]}'
{"tempest/config.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6bc57aa90599ce7dd782fc722812109b9c9f0ca2","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    cfg.BoolOpt(\u0027resize\u0027,"},{"line_number":325,"context_line":"                default\u003dFalse,"},{"line_number":326,"context_line":"                help\u003d\"Does the test environment support resizing?\"),"},{"line_number":327,"context_line":"    cfg.BoolOpt(\u0027migrate\u0027,"},{"line_number":328,"context_line":"                default\u003dFalse,"},{"line_number":329,"context_line":"                help\u003d\"Does the test environment support migration?\"),"},{"line_number":330,"context_line":"    cfg.BoolOpt(\u0027pause\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_5387e3d6","line":327,"updated":"2016-09-14 18:32:42.000000000","message":"How does this differ from any of the other migration flags, like live migration below. This seems like an unnecessary flag","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35b1b2a6827985db25fcd16e067f7b6e93639b25","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    cfg.BoolOpt(\u0027resize\u0027,"},{"line_number":325,"context_line":"                default\u003dFalse,"},{"line_number":326,"context_line":"                help\u003d\"Does the test environment support resizing?\"),"},{"line_number":327,"context_line":"    cfg.BoolOpt(\u0027migrate\u0027,"},{"line_number":328,"context_line":"                default\u003dFalse,"},{"line_number":329,"context_line":"                help\u003d\"Does the test environment support migration?\"),"},{"line_number":330,"context_line":"    cfg.BoolOpt(\u0027pause\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_5310c3a8","line":327,"range":{"start_line":327,"start_character":17,"end_line":327,"end_character":24},"updated":"2016-09-14 18:31:27.000000000","message":"There is a live_migration option below, I wonder if we should make this more explicit by naming it \u0027cold_migration\u0027?","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"310d18d8d55eb7d4bbef1ebc428c20713ceddd8e","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    cfg.BoolOpt(\u0027resize\u0027,"},{"line_number":325,"context_line":"                default\u003dFalse,"},{"line_number":326,"context_line":"                help\u003d\"Does the test environment support resizing?\"),"},{"line_number":327,"context_line":"    cfg.BoolOpt(\u0027migrate\u0027,"},{"line_number":328,"context_line":"                default\u003dFalse,"},{"line_number":329,"context_line":"                help\u003d\"Does the test environment support migration?\"),"},{"line_number":330,"context_line":"    cfg.BoolOpt(\u0027pause\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_675b352f","line":327,"in_reply_to":"7a8ec9b2_36dec53f","updated":"2016-09-15 14:09:27.000000000","message":"Done","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"113032810349d7516fe18759529b5ee248842c57","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    cfg.BoolOpt(\u0027resize\u0027,"},{"line_number":325,"context_line":"                default\u003dFalse,"},{"line_number":326,"context_line":"                help\u003d\"Does the test environment support resizing?\"),"},{"line_number":327,"context_line":"    cfg.BoolOpt(\u0027migrate\u0027,"},{"line_number":328,"context_line":"                default\u003dFalse,"},{"line_number":329,"context_line":"                help\u003d\"Does the test environment support migration?\"),"},{"line_number":330,"context_line":"    cfg.BoolOpt(\u0027pause\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_36dec53f","line":327,"in_reply_to":"7a8ec9b2_5387e3d6","updated":"2016-09-14 19:08:20.000000000","message":"Yeah, this is cold migration. And the other options are live_migration, block_migration_for_live_migration, block_migrate_cinder_iscsi. They don\u0027t seem to fit to this purpose. So I tend to prefer cold_migration.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"}],"tempest/scenario/test_network_advanced_server_ops.py":[{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"f04075270571f0c5398f40dee11ce516325d12fd","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":187,"context_line":"    def test_server_connectivity_migration(self):"},{"line_number":188,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":189,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":190,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":191,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":192,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_db9b1165","line":189,"updated":"2016-07-26 13:20:48.000000000","message":"need to verify that there are at least 2 computes available","commit_id":"669fd72507ebd9713a45cbf0a95ac273996cb056"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"439b45f538ef612b4233457cf198eed41a43367e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":187,"context_line":"    def test_server_connectivity_migration(self):"},{"line_number":188,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":189,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":190,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":191,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":192,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8122c5ff","line":189,"in_reply_to":"1aa78d24_db9b1165","updated":"2016-07-28 18:11:53.000000000","message":"Is this necessary ?  The migration would fail and raise and exception.","commit_id":"669fd72507ebd9713a45cbf0a95ac273996cb056"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"f04075270571f0c5398f40dee11ce516325d12fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1aa78d24_fb988d6c","line":195,"updated":"2016-07-26 13:20:48.000000000","message":"need to verify that migration was to another host.","commit_id":"669fd72507ebd9713a45cbf0a95ac273996cb056"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"439b45f538ef612b4233457cf198eed41a43367e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bacf61ea_610d1190","line":195,"in_reply_to":"1aa78d24_fb988d6c","updated":"2016-07-28 18:11:53.000000000","message":"Done","commit_id":"669fd72507ebd9713a45cbf0a95ac273996cb056"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35b1b2a6827985db25fcd16e067f7b6e93639b25","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cls.set_network_resources()"},{"line_number":57,"context_line":"        super(TestNetworkAdvancedServerOps, cls).setup_credentials()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setup_network_and_servers(self):"},{"line_number":60,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":61,"context_line":"        security_groups \u003d []"},{"line_number":62,"context_line":"        if test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_b382e792","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":34},"updated":"2016-09-14 18:31:27.000000000","message":"unrelated nit, this makes it sound like multiple servers are created - I can clean that up separately","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"2e2db41dfdcf7dd3ed68bab8ea6a4a7d49c52cf0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        cls.set_network_resources()"},{"line_number":57,"context_line":"        super(TestNetworkAdvancedServerOps, cls).setup_credentials()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _setup_network_and_servers(self):"},{"line_number":60,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":61,"context_line":"        security_groups \u003d []"},{"line_number":62,"context_line":"        if test.is_extension_enabled(\u0027security-group\u0027, \u0027network\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_b2fab3bb","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":34},"in_reply_to":"7a8ec9b2_b382e792","updated":"2016-09-15 14:24:42.000000000","message":"See https://review.openstack.org/370879","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35b1b2a6827985db25fcd16e067f7b6e93639b25","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        host_client \u003d self.admin_hosts_client"},{"line_number":190,"context_line":"        hosts \u003d host_client.list_hosts()[\u0027hosts\u0027]"},{"line_number":191,"context_line":"        computes \u003d [x for x in hosts if x[\u0027service\u0027] \u003d\u003d \u0027compute\u0027]"},{"line_number":192,"context_line":"        if len(computes) \u003c 2:"},{"line_number":193,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_f3bc6f6e","line":192,"updated":"2016-09-14 18:31:27.000000000","message":"This is checked a bit differently here:\n\nhttps://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_live_migration.py#L40\n\nI\u0027m not sure which I like better.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"310d18d8d55eb7d4bbef1ebc428c20713ceddd8e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        host_client \u003d self.admin_hosts_client"},{"line_number":190,"context_line":"        hosts \u003d host_client.list_hosts()[\u0027hosts\u0027]"},{"line_number":191,"context_line":"        computes \u003d [x for x in hosts if x[\u0027service\u0027] \u003d\u003d \u0027compute\u0027]"},{"line_number":192,"context_line":"        if len(computes) \u003c 2:"},{"line_number":193,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_c756c9d1","line":192,"in_reply_to":"7a8ec9b2_f3bc6f6e","updated":"2016-09-15 14:09:27.000000000","message":"Yeah, I saw this one.  I initially taught it would be better to dynamically discover how much computes are up instead of relying on config.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6bc57aa90599ce7dd782fc722812109b9c9f0ca2","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_7614cd43","line":196,"updated":"2016-09-14 18:32:42.000000000","message":"What does this function do? It doesn\u0027t mean anything reading it. I realize other tests in this module do things like this, but this is completely unreadable I have no idea what this means. Lets not continue using a terrible pattern.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"2e2db41dfdcf7dd3ed68bab8ea6a4a7d49c52cf0","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_b221d34f","line":196,"in_reply_to":"7a8ec9b2_71021771","updated":"2016-09-15 14:24:42.000000000","message":"See separate patch https://review.openstack.org/370879","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"113032810349d7516fe18759529b5ee248842c57","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_71021771","line":196,"in_reply_to":"7a8ec9b2_7614cd43","updated":"2016-09-14 19:08:20.000000000","message":"Yeah, that is a nice point. This return values are a little difficult to read. It is nice to separate for each resource.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35b1b2a6827985db25fcd16e067f7b6e93639b25","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_131c7b76","line":197,"updated":"2016-09-14 18:31:27.000000000","message":"This is done a little differently here:\n\nhttps://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_live_migration.py#L65","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"310d18d8d55eb7d4bbef1ebc428c20713ceddd8e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_1db61d3d","line":197,"in_reply_to":"7a8ec9b2_131c7b76","updated":"2016-09-15 14:09:27.000000000","message":"Done","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"113032810349d7516fe18759529b5ee248842c57","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_4c6f40c5","line":197,"in_reply_to":"7a8ec9b2_131c7b76","updated":"2016-09-14 19:08:20.000000000","message":"I prefer to use \u0027OS-EXT-SRV-ATTR:host\u0027 here instead of \u0027hostId\u0027 because hostname is readable and useful for debugging.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"310d18d8d55eb7d4bbef1ebc428c20713ceddd8e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            raise self.skipException(msg)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_fdba5122","line":197,"in_reply_to":"7a8ec9b2_4c6f40c5","updated":"2016-09-15 14:09:27.000000000","message":"Done","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6bc57aa90599ce7dd782fc722812109b9c9f0ca2","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":203,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_b63575db","line":200,"updated":"2016-09-14 18:32:42.000000000","message":"How long does this state last? Isn\u0027t this a potential race condition if it\u0027s a quick state.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"d2e1b5f792c2856d0b002f322b79e581d06eb358","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":203,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_96cdd95f","line":200,"in_reply_to":"7a8ec9b2_16ed4925","updated":"2016-09-14 18:39:11.000000000","message":"Well  it\u0027s a potential issue on clouds with that enabled then, even if we won\u0027t hit it in the gate. But, if you\u0027re ok with ignoring that potential risk I\u0027m fine with it.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0918b0572b15ceafa6d08beabc00c585d65d7aea","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":203,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_0cbd3868","line":200,"in_reply_to":"7a8ec9b2_8c214850","updated":"2016-09-14 19:23:22.000000000","message":"FYI for completeness on the periodic task:\n\nhttps://github.com/openstack/nova/blob/233160644f4f0a17177fffe8a1e6db1341e61ad4/nova/compute/manager.py#L5825","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d167ab0ec4ea7bccef5f10a2e6a93ce7416ad065","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":203,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_8c214850","line":200,"in_reply_to":"7a8ec9b2_96cdd95f","updated":"2016-09-14 19:13:19.000000000","message":"*shrug* I\u0027m pretty sure it\u0027s already done in other tests for resize in tempest, like, forever now.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"703346a1b4efa03222559f8343e0c1fd6106b95e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":198,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":199,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":203,"context_line":"        self._wait_server_status_and_check_network_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_16ed4925","line":200,"in_reply_to":"7a8ec9b2_b63575db","updated":"2016-09-14 18:34:32.000000000","message":"No, VERIFY_RESIZE sticks until you confirm or revert the resize. There are periodic tasks in n-cpu that can be used to auto-confirm the resize, but those aren\u0027t set by default.","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6bc57aa90599ce7dd782fc722812109b9c9f0ca2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":203,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":204,"context_line":"            server, keypair, floating_ip)"},{"line_number":205,"context_line":"        dst_host \u003d self.servers_client.show_server("},{"line_number":206,"context_line":"            server[\u0027id\u0027])[\u0027server\u0027][\u0027hostId\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_9664f9e5","line":203,"updated":"2016-09-14 18:32:42.000000000","message":"How is this checking connectivity? What is it doing a ping? ssh? We need to be more explicit here otherwise we\u0027ll never be able to debug anything","commit_id":"a05a71d624479dbc34370d40e51883889e2e8b88"},{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"e0f60ec6464f4efe50ce1ca48d76f016b411543e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"        self._check_network_connectivity(server, keypair, floating_ip)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def _get_server_details(self, server_id):"},{"line_number":107,"context_line":"        body \u003d self.admin_servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":108,"context_line":"        return body"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_42d7c64a","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":45},"updated":"2016-11-01 15:28:46.000000000","message":"This method is used only in _get_host_for_server() and nowhere else in test_network_advanced_server_ops. Maybe, it would make sense to move its logic to _get_host_for_server() directly?","commit_id":"4119647e1032f971c649eb8f08c0943a76c18af1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"27dfedc3b9b8f27e0ad8e2c118d7ee5ab10bc75b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                       \u0027ACTIVE\u0027)"},{"line_number":104,"context_line":"        self._check_network_connectivity(server, keypair, floating_ip)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def _get_server_details(self, server_id):"},{"line_number":107,"context_line":"        body \u003d self.admin_servers_client.show_server(server_id)[\u0027server\u0027]"},{"line_number":108,"context_line":"        return body"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_81197224","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":45},"in_reply_to":"ba5da102_42d7c64a","updated":"2016-11-03 18:38:17.000000000","message":"Good idea.  Done.","commit_id":"4119647e1032f971c649eb8f08c0943a76c18af1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"10a88dea887915619916da89e40123f9109b2470","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"        self.servers_client.confirm_resize_server(server[\u0027id\u0027])"},{"line_number":216,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":217,"context_line":"            server, keypair, floating_ip)"},{"line_number":218,"context_line":"        dst_host \u003d self._get_host_for_server(server[\u0027id\u0027])"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5da102_1a1759ee","line":216,"updated":"2016-11-04 23:15:15.000000000","message":"Can we check this connectivity before the migration also?\nIt would be nice to distinguish when the connectivity becomes wrong when facing the problem on the test.","commit_id":"4593b235b15f6605030655d68aa0e842d254b899"}]}