)]}'
{"tempest/api/volume/admin/test_volumes_list.py":[{"author":{"_account_id":22344,"name":"Yoshiki Eguchi","email":"yoshiki.eguchi@gmail.com","username":"yoshiki.eguchi"},"change_message_id":"8f9592e3f6a74aa09e9e65260eded897f23a83c6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            detail\u003dTrue, params\u003dparams)[\u0027volumes\u0027]"},{"line_number":50,"context_line":"        # Verifying fetched volume ids list is related to primary tenant"},{"line_number":51,"context_line":"        fetched_list_ids \u003d map(operator.itemgetter(\u0027id\u0027), fetched_list)"},{"line_number":52,"context_line":"        expected_list_ids \u003d map(operator.itemgetter(\u0027id\u0027), self.volume_list)"},{"line_number":53,"context_line":"        self.assertEqual(sorted(expected_list_ids), sorted(fetched_list_ids))"},{"line_number":54,"context_line":"        # Verifying tenant id of volumes fetched list is related to"},{"line_number":55,"context_line":"        # primary tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_cdbcde6e","line":52,"updated":"2016-07-19 14:26:20.000000000","message":"Above 2 lines also uses map. Don\u0027t them need to replace to list comprehension also?","commit_id":"935f2cca8e9d05fdd1b6d3cb2149a84dadabfea1"},{"author":{"_account_id":22344,"name":"Yoshiki Eguchi","email":"yoshiki.eguchi@gmail.com","username":"yoshiki.eguchi"},"change_message_id":"520dfe8381ab70dfe87df78ecfa0614e68ba1546","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            detail\u003dTrue, params\u003dparams)[\u0027volumes\u0027]"},{"line_number":50,"context_line":"        # Verifying fetched volume ids list is related to primary tenant"},{"line_number":51,"context_line":"        fetched_list_ids \u003d map(operator.itemgetter(\u0027id\u0027), fetched_list)"},{"line_number":52,"context_line":"        expected_list_ids \u003d map(operator.itemgetter(\u0027id\u0027), self.volume_list)"},{"line_number":53,"context_line":"        self.assertEqual(sorted(expected_list_ids), sorted(fetched_list_ids))"},{"line_number":54,"context_line":"        # Verifying tenant id of volumes fetched list is related to"},{"line_number":55,"context_line":"        # primary tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_1031d805","line":52,"in_reply_to":"dada55a8_b35c6cee","updated":"2016-07-19 22:34:12.000000000","message":"Understood, thanks.","commit_id":"935f2cca8e9d05fdd1b6d3cb2149a84dadabfea1"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"5c77d17b90f72658ce96e8e147e3232af45329e6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            detail\u003dTrue, params\u003dparams)[\u0027volumes\u0027]"},{"line_number":50,"context_line":"        # Verifying fetched volume ids list is related to primary tenant"},{"line_number":51,"context_line":"        fetched_list_ids \u003d map(operator.itemgetter(\u0027id\u0027), fetched_list)"},{"line_number":52,"context_line":"        expected_list_ids \u003d map(operator.itemgetter(\u0027id\u0027), self.volume_list)"},{"line_number":53,"context_line":"        self.assertEqual(sorted(expected_list_ids), sorted(fetched_list_ids))"},{"line_number":54,"context_line":"        # Verifying tenant id of volumes fetched list is related to"},{"line_number":55,"context_line":"        # primary tenant"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b35c6cee","line":52,"in_reply_to":"dada55a8_cdbcde6e","updated":"2016-07-19 15:07:52.000000000","message":"Since the sorted function accepts an iterable as an argument below, this is fine.","commit_id":"935f2cca8e9d05fdd1b6d3cb2149a84dadabfea1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"97baccff3c4ae1f90ce70f0edd125dafbc0bf4f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self.assertEqual(sorted(expected_list_ids), sorted(fetched_list_ids))"},{"line_number":54,"context_line":"        # Verifying tenant id of volumes fetched list is related to"},{"line_number":55,"context_line":"        # primary tenant"},{"line_number":56,"context_line":"        fetched_tenant_id \u003d [operator.itemgetter("},{"line_number":57,"context_line":"            \u0027os-vol-tenant-attr:tenant_id\u0027)(item) for item in fetched_list]"},{"line_number":58,"context_line":"        expected_tenant_id \u003d [self.volumes_client.tenant_id] * 3"},{"line_number":59,"context_line":"        self.assertEqual(expected_tenant_id, fetched_tenant_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_53beac65","line":57,"range":{"start_line":56,"start_character":29,"end_line":57,"end_character":49},"updated":"2016-07-20 08:27:32.000000000","message":"you could do directly like- item[\u0027os-vol-tenant-attr:tenant_id\u0027]","commit_id":"935f2cca8e9d05fdd1b6d3cb2149a84dadabfea1"}],"tempest/api/volume/test_volumes_list.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"0dd597090d122c92767421859a9d251d178c4f72","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def assertVolumesIn(self, fetched_list, expected_list, fields\u003dNone):"},{"line_number":35,"context_line":"        if fields:"},{"line_number":36,"context_line":"            fieldsgetter \u003d operator.itemgetter(*fields)"},{"line_number":37,"context_line":"            expected_list \u003d map(fieldsgetter, expected_list)"},{"line_number":38,"context_line":"            fetched_list \u003d [fieldsgetter(item) for item in fetched_list]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        missing_vols \u003d [v for v in expected_list if v not in fetched_list]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_e178bcc6","line":37,"updated":"2016-07-19 20:21:09.000000000","message":"Is there a reason not to change this line like the one below? I see that it isn\u0027t required given the way it is used later, but I think it would make the code easier to read.","commit_id":"935f2cca8e9d05fdd1b6d3cb2149a84dadabfea1"}]}