)]}'
{"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"a930b6b48d4d2f0d65856dfc215a2943cf11899e","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                         \u0027The fetched Volume_type is different \u0027"},{"line_number":118,"context_line":"                         \u0027from the created Volume_type\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(description, fetched_volume_type[\u0027description\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(body[\u0027is_public\u0027],"},{"line_number":121,"context_line":"                         fetched_volume_type[\u0027is_public\u0027])"},{"line_number":122,"context_line":"        self.assertEqual("},{"line_number":123,"context_line":"            body[\u0027os-volume-type-access:is_public\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_9a451519","line":120,"range":{"start_line":120,"start_character":31,"end_line":120,"end_character":40},"updated":"2017-01-25 09:31:58.000000000","message":"if you add check for \u0027is_public\u0027, then do you consider of specifying is_public when create_volume_type, \nthen you are not just checking create_body[\u0027is_public\u0027] equal to fetched_body[\u0027is_public\u0027], but also to\ncheck whether the volume type\u0027s is_public is correctly set and returned in show_volume_type.","commit_id":"625e0bca319457d879ffb0a05d31f1ffbbfd2878"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f458ed2d55aeeb42ae427afbc6d47bf7af121d81","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                         \u0027The fetched Volume_type is different \u0027"},{"line_number":118,"context_line":"                         \u0027from the created Volume_type\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(description, fetched_volume_type[\u0027description\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(body[\u0027is_public\u0027],"},{"line_number":121,"context_line":"                         fetched_volume_type[\u0027is_public\u0027])"},{"line_number":122,"context_line":"        self.assertEqual("},{"line_number":123,"context_line":"            body[\u0027os-volume-type-access:is_public\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_0081d64a","line":120,"range":{"start_line":120,"start_character":31,"end_line":120,"end_character":40},"in_reply_to":"5a3905b3_8e5ceeee","updated":"2017-01-25 14:41:19.000000000","message":"Thanks, Done\nBy the way, \u0027is_public\u0027 is not a valid parameter for the request, however, \u0027os-volume-type-access:is_public\u0027 is valid.","commit_id":"625e0bca319457d879ffb0a05d31f1ffbbfd2878"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21c689ba8f863b0debc66a8476b3c086069ede2c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                         \u0027The fetched Volume_type is different \u0027"},{"line_number":118,"context_line":"                         \u0027from the created Volume_type\u0027)"},{"line_number":119,"context_line":"        self.assertEqual(description, fetched_volume_type[\u0027description\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(body[\u0027is_public\u0027],"},{"line_number":121,"context_line":"                         fetched_volume_type[\u0027is_public\u0027])"},{"line_number":122,"context_line":"        self.assertEqual("},{"line_number":123,"context_line":"            body[\u0027os-volume-type-access:is_public\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_8e5ceeee","line":120,"range":{"start_line":120,"start_character":31,"end_line":120,"end_character":40},"in_reply_to":"5a3905b3_9a451519","updated":"2017-01-25 12:39:56.000000000","message":"yea, nice point. let\u0027s test thoroughly","commit_id":"625e0bca319457d879ffb0a05d31f1ffbbfd2878"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3157319cb3d4572ca11f9950f7bb99ee3514fd2b","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(description, fetched_volume_type[\u0027description\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(body[\u0027is_public\u0027],"},{"line_number":121,"context_line":"                         fetched_volume_type[\u0027is_public\u0027])"},{"line_number":122,"context_line":"        self.assertEqual("},{"line_number":123,"context_line":"            body[\u0027os-volume-type-access:is_public\u0027],"},{"line_number":124,"context_line":"            fetched_volume_type[\u0027os-volume-type-access:is_public\u0027])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @test.idempotent_id(\u00277830abd0-ff99-4793-a265-405684a54d46\u0027)"},{"line_number":127,"context_line":"    def test_volume_type_encryption_create_get_delete(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_f4e472ad","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":67},"updated":"2017-01-25 08:51:52.000000000","message":"this seems like from extension os-volume-type-access. \n\ndoes cinder load all extension always?  but i can see https://github.com/openstack/cinder/blob/master/cinder/common/config.py#L96","commit_id":"625e0bca319457d879ffb0a05d31f1ffbbfd2878"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21c689ba8f863b0debc66a8476b3c086069ede2c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        self.assertEqual(description, fetched_volume_type[\u0027description\u0027])"},{"line_number":120,"context_line":"        self.assertEqual(body[\u0027is_public\u0027],"},{"line_number":121,"context_line":"                         fetched_volume_type[\u0027is_public\u0027])"},{"line_number":122,"context_line":"        self.assertEqual("},{"line_number":123,"context_line":"            body[\u0027os-volume-type-access:is_public\u0027],"},{"line_number":124,"context_line":"            fetched_volume_type[\u0027os-volume-type-access:is_public\u0027])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    @test.idempotent_id(\u00277830abd0-ff99-4793-a265-405684a54d46\u0027)"},{"line_number":127,"context_line":"    def test_volume_type_encryption_create_get_delete(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a3905b3_6ea42208","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":67},"in_reply_to":"5a3905b3_f4e472ad","updated":"2017-01-25 12:39:56.000000000","message":"confirmed that os-volume-type-access is standard extensions and always loaded in cloud.","commit_id":"625e0bca319457d879ffb0a05d31f1ffbbfd2878"}]}