)]}'
{"tempest/common/compute.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e7c03a28bbd8611ca9c655d2ab9203dd7959f29c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":32,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":33,"context_line":"                       image_id\u003dNone, delete_vol_on_termination\u003dTrue,"},{"line_number":34,"context_line":"                       bootable_volume\u003dNone,"},{"line_number":35,"context_line":"                       **kwargs):"},{"line_number":36,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_53318804","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":44},"updated":"2016-09-23 17:16:36.000000000","message":"IMHO If you want to use an existing bootable volume (instead of creating one).\nUse existing kwargs - block_device_mapping_v2\nWhere block_device_mapping_v2 is something like:\n      [{\n            \u0027uuid\u0027: volume_id,\n            \u0027source_type\u0027: \u0027volume\u0027,\n            \u0027destination_type\u0027: \u0027volume\u0027,\n            \u0027boot_index\u0027: 0,\n            \u0027delete_on_termination\u0027: True\n     }]","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"2984f3af02701d94a67a1a472477b0a7c94097c8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                       tenant_network\u003dNone, wait_until\u003dNone,"},{"line_number":32,"context_line":"                       volume_backed\u003dFalse, name\u003dNone, flavor\u003dNone,"},{"line_number":33,"context_line":"                       image_id\u003dNone, delete_vol_on_termination\u003dTrue,"},{"line_number":34,"context_line":"                       bootable_volume\u003dNone,"},{"line_number":35,"context_line":"                       **kwargs):"},{"line_number":36,"context_line":"    \"\"\"Common wrapper utility returning a test server."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_8afc8a73","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":44},"in_reply_to":"5a8bc5a2_53318804","updated":"2016-09-26 01:44:42.000000000","message":"Please look at Line 121, it uses block_device_mapping_v2.","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"}],"tempest/config.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e7c03a28bbd8611ca9c655d2ab9203dd7959f29c","unresolved":false,"context_lines":[{"line_number":760,"context_line":"    cfg.BoolOpt(\u0027api_v3\u0027,"},{"line_number":761,"context_line":"                default\u003dFalse,"},{"line_number":762,"context_line":"                help\u003d\"Is the v3 volume API enabled\"),"},{"line_number":763,"context_line":"    cfg.BoolOpt(\u0027encrypted_vol_from_image\u0027,"},{"line_number":764,"context_line":"                default\u003dFalse,"},{"line_number":765,"context_line":"                help\u003d\"Is encrypted volume from image enabled\"),"},{"line_number":766,"context_line":"    cfg.BoolOpt(\u0027bootable\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_9827a863","line":763,"range":{"start_line":763,"start_character":16,"end_line":763,"end_character":43},"updated":"2016-09-23 17:16:36.000000000","message":"can \u0027attach_encrypted_volume\u0027 be reused for this scenario?\nshould this value be renamed to encrypted_volume or is it an additional/different configuration?","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"2984f3af02701d94a67a1a472477b0a7c94097c8","unresolved":false,"context_lines":[{"line_number":760,"context_line":"    cfg.BoolOpt(\u0027api_v3\u0027,"},{"line_number":761,"context_line":"                default\u003dFalse,"},{"line_number":762,"context_line":"                help\u003d\"Is the v3 volume API enabled\"),"},{"line_number":763,"context_line":"    cfg.BoolOpt(\u0027encrypted_vol_from_image\u0027,"},{"line_number":764,"context_line":"                default\u003dFalse,"},{"line_number":765,"context_line":"                help\u003d\"Is encrypted volume from image enabled\"),"},{"line_number":766,"context_line":"    cfg.BoolOpt(\u0027bootable\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_2aee16b4","line":763,"range":{"start_line":763,"start_character":16,"end_line":763,"end_character":43},"in_reply_to":"5a8bc5a2_9827a863","updated":"2016-09-26 01:44:42.000000000","message":"These are two features. As I just fixed the problem to create encrypted volume from images in Newton, this encrypted_vol_from_image is added to introduce the corresponding tests.","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"}],"tempest/scenario/test_encrypted_cinder_volumes.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e7c03a28bbd8611ca9c655d2ab9203dd7959f29c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":57,"context_line":"        return self.create_server(key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":58,"context_line":"                                  wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":59,"context_line":"                                  bootable_volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def create_encrypted_volume(self, encryption_provider,"},{"line_number":62,"context_line":"                                volume_type,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_eee1c7ff","line":59,"range":{"start_line":59,"start_character":34,"end_line":59,"end_character":65},"updated":"2016-09-23 17:16:36.000000000","message":"here construct block_device_mapping_v2 and pass it to create_server","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"2984f3af02701d94a67a1a472477b0a7c94097c8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":57,"context_line":"        return self.create_server(key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":58,"context_line":"                                  wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":59,"context_line":"                                  bootable_volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def create_encrypted_volume(self, encryption_provider,"},{"line_number":62,"context_line":"                                volume_type,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_6a32de60","line":59,"range":{"start_line":59,"start_character":34,"end_line":59,"end_character":65},"in_reply_to":"5a8bc5a2_eee1c7ff","updated":"2016-09-26 01:44:42.000000000","message":"Here I just transfer the volume id, and it constructs block_device_mapping_v2 in create_server.","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"e7c03a28bbd8611ca9c655d2ab9203dd7959f29c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                    key_size\u003d256,"},{"line_number":68,"context_line":"                                    cipher\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":69,"context_line":"                                    control_location\u003d\u0027front-end\u0027)"},{"line_number":70,"context_line":"        return self.create_volume(volume_type\u003dvolume_type[\u0027name\u0027],"},{"line_number":71,"context_line":"                                  imageRef\u003dimage)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def attach_detach_volume(self, server, volume):"},{"line_number":74,"context_line":"        attached_volume \u003d self.nova_volume_attach(server, volume)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_821657a5","line":71,"range":{"start_line":70,"start_character":15,"end_line":71,"end_character":49},"updated":"2016-09-23 17:16:36.000000000","message":"Probably add assetion to verify volume is actually encrypted before returning the volume.\nresponse[encrypted]\u003dTrue","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"00a570ac1b6086a7f9ed3656514e99f20de28ae1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                    key_size\u003d256,"},{"line_number":68,"context_line":"                                    cipher\u003d\u0027aes-xts-plain64\u0027,"},{"line_number":69,"context_line":"                                    control_location\u003d\u0027front-end\u0027)"},{"line_number":70,"context_line":"        return self.create_volume(volume_type\u003dvolume_type[\u0027name\u0027],"},{"line_number":71,"context_line":"                                  imageRef\u003dimage)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def attach_detach_volume(self, server, volume):"},{"line_number":74,"context_line":"        attached_volume \u003d self.nova_volume_attach(server, volume)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a8bc5a2_65ce912f","line":71,"range":{"start_line":70,"start_character":15,"end_line":71,"end_character":49},"in_reply_to":"5a8bc5a2_821657a5","updated":"2016-09-26 02:27:36.000000000","message":"Done","commit_id":"3c8a3a08f8e93538bb49f89cbe3423985e0f8258"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"194893bc58ae5a11976f59713fec01b01c0ed012","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                  wait_until\u003d\u0027ACTIVE\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def launch_instance_from_volume(self, volume):"},{"line_number":56,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":57,"context_line":"        return self.create_server(key_name\u003dkeypair[\u0027name\u0027],"},{"line_number":58,"context_line":"                                  wait_until\u003d\u0027ACTIVE\u0027,"},{"line_number":59,"context_line":"                                  volume_backed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba5201f7_d0a31cff","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":39},"updated":"2017-01-09 09:22:45.000000000","message":"I wonder why keypair is needed here? This testcase won\u0027t ssh to server","commit_id":"237564a3ef75a9babcf711f9e3854cb5c45d6722"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"194893bc58ae5a11976f59713fec01b01c0ed012","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            volume_type\u003d\u0027cryptsetup\u0027,"},{"line_number":125,"context_line":"            image\u003dimage)"},{"line_number":126,"context_line":"        volume2 \u003d self.create_encrypted_volume("},{"line_number":127,"context_line":"            \u0027nova.volume.encryptors.\u0027"},{"line_number":128,"context_line":"            \u0027cryptsetup.CryptsetupEncryptor\u0027,"},{"line_number":129,"context_line":"            volume_type\u003d\u0027cryptsetup\u0027,"},{"line_number":130,"context_line":"            image\u003dimage)"},{"line_number":131,"context_line":"        server \u003d self.launch_instance_from_volume(volume1)"}],"source_content_type":"text/x-python","patch_set":22,"id":"ba5201f7_7072704b","line":128,"range":{"start_line":127,"start_character":0,"end_line":128,"end_character":45},"updated":"2017-01-09 09:22:45.000000000","message":"It seems encryption_provider can be automatically set according to volume_type, so maybe we can remove encryption_provider from create_encrypted_volume\u0027s parameters. Now there are four tests in this file and so we may consider of reducing some duplicated code.","commit_id":"237564a3ef75a9babcf711f9e3854cb5c45d6722"}]}