)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- Api for snapshot-unmange"},{"line_number":15,"context_line":"- Api for snapshot-manage"},{"line_number":16,"context_line":"- Flag for snapshot manage feature in config.py"},{"line_number":17,"context_line":"Note: Cinder V1 does not support unmanage \u0026 manage snapshot."},{"line_number":18,"context_line":"Only some drivers support this operation."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib02fe171b07814aa12d311171dceac834ecbfe39"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a629dbe_5d96e2f0","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":40},"updated":"2016-11-09 08:25:29.000000000","message":"Is it mean v1 also support for some driver or v1 does not support at all and v2 for some driver ?","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"21f96e56a6a6f37fd5bbb8ad372a2d5e77ce1f55","unresolved":false,"context_lines":[{"line_number":14,"context_line":"- Api for snapshot-unmange"},{"line_number":15,"context_line":"- Api for snapshot-manage"},{"line_number":16,"context_line":"- Flag for snapshot manage feature in config.py"},{"line_number":17,"context_line":"Note: Cinder V1 does not support unmanage \u0026 manage snapshot."},{"line_number":18,"context_line":"Only some drivers support this operation."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ib02fe171b07814aa12d311171dceac834ecbfe39"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9a629dbe_90cbfca4","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":40},"in_reply_to":"9a629dbe_5d96e2f0","updated":"2016-11-09 10:25:09.000000000","message":"Cinder v1 does not support this feature at all","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"}],"tempest/api/volume/admin/v2/test_snapshot_manage.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b9a736f3ec192a259c1cf87f898a382d8d09aa88","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(SnapshotManageAdminV2Test, cls).resource_setup()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Create a volume"},{"line_number":49,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _delete_snapshot(self, snapshot_id):"},{"line_number":52,"context_line":"        # Delete a snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_4031b004","line":49,"updated":"2016-10-06 10:43:27.000000000","message":"Please create that volume in the test itself. This volume can\u0027t be shared between tests so no need to create it in the resource_setup method.","commit_id":"46492b483686f2a7b21adf76c2dd35c42ddc4310"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e8681812214385ce649baf5b55609f089015fd1b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        super(SnapshotManageAdminV2Test, cls).resource_setup()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Create a volume"},{"line_number":49,"context_line":"        cls.volume \u003d cls.create_volume()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _delete_snapshot(self, snapshot_id):"},{"line_number":52,"context_line":"        # Delete a snapshot"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_ac2a6b7c","line":49,"in_reply_to":"1a95cdbc_4031b004","updated":"2016-10-06 11:50:03.000000000","message":"Done","commit_id":"46492b483686f2a7b21adf76c2dd35c42ddc4310"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b9a736f3ec192a259c1cf87f898a382d8d09aa88","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            self.admin_snapshots_client.list_snapshots()[\u0027snapshots\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Verify the managed snapshot has the expected parent volume"},{"line_number":97,"context_line":"        self.assertIn(snapshot[\u0027volume_id\u0027], volume_parent)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_40837098","line":97,"updated":"2016-10-06 10:43:27.000000000","message":"Couldn\u0027t this be assertEqual(snapshot[\u0027volume_id\u0027], self.volume[\u0027id\u0027]) ?","commit_id":"46492b483686f2a7b21adf76c2dd35c42ddc4310"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e8681812214385ce649baf5b55609f089015fd1b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            self.admin_snapshots_client.list_snapshots()[\u0027snapshots\u0027])"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        # Verify the managed snapshot has the expected parent volume"},{"line_number":97,"context_line":"        self.assertIn(snapshot[\u0027volume_id\u0027], volume_parent)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_ac78ab90","line":97,"in_reply_to":"1a95cdbc_40837098","updated":"2016-10-06 11:50:03.000000000","message":"Right, I really don\u0027t know why I did it","commit_id":"46492b483686f2a7b21adf76c2dd35c42ddc4310"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.api.volume import base"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_bda9bee1","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":24},"updated":"2016-11-09 08:25:29.000000000","message":"these should be together","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"21f96e56a6a6f37fd5bbb8ad372a2d5e77ce1f55","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import testtools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from tempest.common import waiters"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tempest.api.volume import base"},{"line_number":21,"context_line":"from tempest import config"},{"line_number":22,"context_line":"from tempest import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d config.CONF"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_b02480af","line":22,"range":{"start_line":18,"start_character":0,"end_line":22,"end_character":24},"in_reply_to":"9a629dbe_bda9bee1","updated":"2016-11-09 10:25:09.000000000","message":"Done","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":53,"context_line":"        # Create a volume"},{"line_number":54,"context_line":"        volume \u003d self.create_volume()"},{"line_number":55,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Create a snapshot"},{"line_number":58,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_df5e93e8","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":72},"updated":"2016-11-09 08:25:29.000000000","message":"this actually not needed as delete volume is taken care by self.create_volume()","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"21f96e56a6a6f37fd5bbb8ad372a2d5e77ce1f55","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":53,"context_line":"        # Create a volume"},{"line_number":54,"context_line":"        volume \u003d self.create_volume()"},{"line_number":55,"context_line":"        self.addCleanup(self.volumes_client.delete_volume, volume[\u0027id\u0027])"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        # Create a snapshot"},{"line_number":58,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_30bb1010","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":72},"in_reply_to":"9a629dbe_df5e93e8","updated":"2016-11-09 10:25:09.000000000","message":"Done","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                         \u0027available\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Verify the managed snapshot has the expected parent volume"},{"line_number":88,"context_line":"        self.assertEqual(snapshot[\u0027volume_id\u0027], volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_c28cfc81","line":88,"range":{"start_line":88,"start_character":25,"end_line":88,"end_character":33},"updated":"2016-11-09 08:25:29.000000000","message":"you mean new_snapshot ?","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"21f96e56a6a6f37fd5bbb8ad372a2d5e77ce1f55","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                                         \u0027available\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Verify the managed snapshot has the expected parent volume"},{"line_number":88,"context_line":"        self.assertEqual(snapshot[\u0027volume_id\u0027], volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_f047d81a","line":88,"range":{"start_line":88,"start_character":25,"end_line":88,"end_character":33},"in_reply_to":"9a629dbe_c28cfc81","updated":"2016-11-09 10:25:09.000000000","message":"Thanks, my mistake","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":23003,"name":"Gal Amado","email":"gamado@redhat.com","username":"gamado"},"change_message_id":"07e3a85c9c3d5b2e14653e02e8bf8904883ceede","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # Create a snapshot"},{"line_number":48,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Unmanage the snapshot"},{"line_number":51,"context_line":"        # Unmanage snapshot function works almost the same as delete snapshot,"},{"line_number":52,"context_line":"        # but it does not delete the snapshot data"},{"line_number":53,"context_line":"        self.admin_snapshots_client.unmanage_snapshot(snapshot[\u0027id\u0027])"},{"line_number":54,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Fetch snapshot ids"},{"line_number":57,"context_line":"        snapshot_list \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_f6c39536","line":54,"range":{"start_line":50,"start_character":0,"end_line":54,"end_character":78},"updated":"2016-11-30 11:53:00.000000000","message":"Does it make sense to have a _unmanage_snapshot(), as you did for _delete_snapshot ?","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6e0955671f84616c2f4a682472b60ce4f463e0d5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # Create a snapshot"},{"line_number":48,"context_line":"        snapshot \u003d self.create_snapshot(volume_id\u003dvolume[\u0027id\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        # Unmanage the snapshot"},{"line_number":51,"context_line":"        # Unmanage snapshot function works almost the same as delete snapshot,"},{"line_number":52,"context_line":"        # but it does not delete the snapshot data"},{"line_number":53,"context_line":"        self.admin_snapshots_client.unmanage_snapshot(snapshot[\u0027id\u0027])"},{"line_number":54,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot[\u0027id\u0027])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # Fetch snapshot ids"},{"line_number":57,"context_line":"        snapshot_list \u003d ["}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_c81ed462","line":54,"range":{"start_line":50,"start_character":0,"end_line":54,"end_character":78},"in_reply_to":"5a74a57a_f6c39536","updated":"2016-12-02 12:00:29.000000000","message":"No, no need to introduce a function for 2 lines of self descriptive code that is not reused anywhere else.","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"6ef3a86f84704504efce75582cf1ad6127c4a6bb","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.idempotent_id(\u00270132f42d-0147-4b45-8501-cc504bbf7810\u0027)"},{"line_number":40,"context_line":"    @testtools.skipIf(CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027,"},{"line_number":41,"context_line":"                      \u0027Currently, Ceph does not support\u0027"},{"line_number":42,"context_line":"                      \u0027unmanage/manage snapshot\u0027)"},{"line_number":43,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":44,"context_line":"        # Create a volume"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_9317de53","line":41,"range":{"start_line":41,"start_character":55,"end_line":41,"end_character":56},"updated":"2016-12-29 06:26:46.000000000","message":"a space should be added here.","commit_id":"62776e0921ae1854ec1d850c7a1b355436b757e3"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5cab07d615274398d9c2aa89e3b054d810566b5e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @test.idempotent_id(\u00270132f42d-0147-4b45-8501-cc504bbf7810\u0027)"},{"line_number":40,"context_line":"    @testtools.skipIf(CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027,"},{"line_number":41,"context_line":"                      \u0027Currently, Ceph does not support\u0027"},{"line_number":42,"context_line":"                      \u0027unmanage/manage snapshot\u0027)"},{"line_number":43,"context_line":"    def test_unmanage_manage_snapshot(self):"},{"line_number":44,"context_line":"        # Create a volume"}],"source_content_type":"text/x-python","patch_set":14,"id":"ba5201f7_b60930e0","line":41,"range":{"start_line":41,"start_character":55,"end_line":41,"end_character":56},"in_reply_to":"ba5201f7_9317de53","updated":"2016-12-29 06:53:37.000000000","message":"Done","commit_id":"62776e0921ae1854ec1d850c7a1b355436b757e3"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"8fed789d02611d78e42fd9aa48e975e24bcd81fe","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                         \u0027available\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        # Verify the managed snapshot has the expected parent volume"},{"line_number":78,"context_line":"        self.assertEqual(new_snapshot[\u0027volume_id\u0027], volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_2559535b","line":78,"range":{"start_line":78,"start_character":8,"end_line":78,"end_character":65},"updated":"2017-01-03 03:40:24.000000000","message":"Maybe it\u0027s better to add an error message here?","commit_id":"d481b5792e66798254ab674ced005d0673faabdd"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7096568466c6877c07bdc36d0d9828f2753a6daa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     managed by Cinder from a storage back end to Cinder"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _delete_snapshot(self, snapshot_id):"},{"line_number":35,"context_line":"        # Delete a snapshot"},{"line_number":36,"context_line":"        self.admin_snapshots_client.delete_snapshot(snapshot_id)"},{"line_number":37,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_8e7c4ced","line":34,"updated":"2017-01-06 13:45:37.000000000","message":"Move this method in the BaseVolumeTest class, and rename it to \u0027delete_snapshot\u0027 (no underscore). Do not make it a class method. Add an additional argument to this method named \u0027client\u0027 which will receive your admin_snapshots_client variable.","commit_id":"98d1c1c9836320b3e0097fb61f48084e280b0e62"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"cc60851cbe24ad493357b4f9b31bdd60a38099f9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     managed by Cinder from a storage back end to Cinder"},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _delete_snapshot(self, snapshot_id):"},{"line_number":35,"context_line":"        # Delete a snapshot"},{"line_number":36,"context_line":"        self.admin_snapshots_client.delete_snapshot(snapshot_id)"},{"line_number":37,"context_line":"        self.admin_snapshots_client.wait_for_resource_deletion(snapshot_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_4f288233","line":34,"in_reply_to":"ba5201f7_8e7c4ced","updated":"2017-01-07 19:36:23.000000000","message":"Done","commit_id":"98d1c1c9836320b3e0097fb61f48084e280b0e62"}],"tempest/config.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":763,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":764,"context_line":"                default\u003dTrue,"},{"line_number":765,"context_line":"                help\u003d\u0027Runs Cinder volume snapshot test\u0027),"},{"line_number":766,"context_line":"    cfg.BoolOpt(\u0027snapshot_manage\u0027,"},{"line_number":767,"context_line":"                default\u003dTrue,"},{"line_number":768,"context_line":"                help\u003d\u0027Runs Cinder snapshot manage test\u0027),"},{"line_number":769,"context_line":"    cfg.BoolOpt(\u0027clone\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_fdac1637","line":766,"range":{"start_line":766,"start_character":17,"end_line":766,"end_character":32},"updated":"2016-11-09 08:25:29.000000000","message":"do we need this flag ? it seems feature being included ~2 year back and should be available for all stable branches now.","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"21f96e56a6a6f37fd5bbb8ad372a2d5e77ce1f55","unresolved":false,"context_lines":[{"line_number":763,"context_line":"    cfg.BoolOpt(\u0027snapshot\u0027,"},{"line_number":764,"context_line":"                default\u003dTrue,"},{"line_number":765,"context_line":"                help\u003d\u0027Runs Cinder volume snapshot test\u0027),"},{"line_number":766,"context_line":"    cfg.BoolOpt(\u0027snapshot_manage\u0027,"},{"line_number":767,"context_line":"                default\u003dTrue,"},{"line_number":768,"context_line":"                help\u003d\u0027Runs Cinder snapshot manage test\u0027),"},{"line_number":769,"context_line":"    cfg.BoolOpt(\u0027clone\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_702ae87f","line":766,"range":{"start_line":766,"start_character":17,"end_line":766,"end_character":32},"in_reply_to":"9a629dbe_fdac1637","updated":"2016-11-09 10:25:09.000000000","message":"Right, we don\u0027t need this flag","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":1215,"context_line":"        logging_cfg_path \u003d \"%s/logging.conf\" % os.path.dirname(path)"},{"line_number":1216,"context_line":"        if ((not hasattr(_CONF, \u0027log_config_append\u0027) or"},{"line_number":1217,"context_line":"            _CONF.log_config_append is None) and"},{"line_number":1218,"context_line":"                os.path.isfile(logging_cfg_path)):"},{"line_number":1219,"context_line":"            # if logging conf is in place we need to set log_config_append"},{"line_number":1220,"context_line":"            _CONF.log_config_append \u003d logging_cfg_path"},{"line_number":1221,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_bd5b7e2d","line":1218,"range":{"start_line":1218,"start_character":12,"end_line":1218,"end_character":17},"updated":"2016-11-09 08:25:29.000000000","message":"unrelated changes.","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"}],"tempest/lib/services/volume/v2/snapshot_manage_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"7096568466c6877c07bdc36d0d9828f2753a6daa","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SnapshotManageClient(rest_client.RestClient):"},{"line_number":22,"context_line":"    \"\"\"Client class to send CRUD Volume V2 API requests.\"\"\""},{"line_number":23,"context_line":"    api_version \u003d \"v2\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def manage_snapshot(self, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_ee431811","line":22,"updated":"2017-01-06 13:45:37.000000000","message":"This doc string is wrong.","commit_id":"98d1c1c9836320b3e0097fb61f48084e280b0e62"}],"tempest/lib/services/volume/v2/snapshots_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8d28487aa8e6a748ebb6aabd3eed0f09fa35b6dd","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manages a snapshot."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        Available params: see https://specs.openstack.org/openstack/"},{"line_number":187,"context_line":"                              cinder-specs/specs/liberty/"},{"line_number":188,"context_line":"                              support-import-export-snapshots.html"},{"line_number":189,"context_line":"                              #rest-api-impact"},{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":192,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_1d646ae2","line":189,"range":{"start_line":186,"start_character":30,"end_line":189,"end_character":46},"updated":"2016-11-09 08:25:29.000000000","message":"actually we should provide api ref link here and if it is not there then we can log bug on api-ref and once fixed then we can add.","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"21f96e56a6a6f37fd5bbb8ad372a2d5e77ce1f55","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manages a snapshot."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        Available params: see https://specs.openstack.org/openstack/"},{"line_number":187,"context_line":"                              cinder-specs/specs/liberty/"},{"line_number":188,"context_line":"                              support-import-export-snapshots.html"},{"line_number":189,"context_line":"                              #rest-api-impact"},{"line_number":190,"context_line":"        \"\"\""},{"line_number":191,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":192,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a629dbe_ada34b4e","line":189,"range":{"start_line":186,"start_character":30,"end_line":189,"end_character":46},"in_reply_to":"9a629dbe_1d646ae2","updated":"2016-11-09 10:25:09.000000000","message":"There is not api ref","commit_id":"b109ee927d43215abedf973bf7b102a757abc871"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6e0955671f84616c2f4a682472b60ce4f463e0d5","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":181,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manages a snapshot.\"\"\""},{"line_number":185,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":186,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_a836f8e4","line":183,"updated":"2016-12-02 12:00:29.000000000","message":"You need to add a release note entry for these 2 new methods.","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f4c52ec493e6c8478ec94d53441338c71695ae9a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":181,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manages a snapshot.\"\"\""},{"line_number":185,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":186,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_95d4b3bd","line":183,"in_reply_to":"3a71b18c_a836f8e4","updated":"2016-12-05 09:50:06.000000000","message":"Hi Jordan,\nThere is not a api ref link for those methods","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6e0955671f84616c2f4a682472b60ce4f463e0d5","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manages a snapshot.\"\"\""},{"line_number":185,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":186,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"},{"line_number":187,"context_line":"        resp, body \u003d self.post(url, post_body)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_a83d18bd","line":184,"updated":"2016-12-02 12:00:29.000000000","message":"Remove the \u0027s\u0027 here, just use \"Manage a snapshot\"","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f4c52ec493e6c8478ec94d53441338c71695ae9a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manages a snapshot.\"\"\""},{"line_number":185,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":186,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"},{"line_number":187,"context_line":"        resp, body \u003d self.post(url, post_body)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_b5dd2fe2","line":184,"in_reply_to":"3a71b18c_a83d18bd","updated":"2016-12-05 09:50:06.000000000","message":"Done","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"6e0955671f84616c2f4a682472b60ce4f463e0d5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def unmanage_snapshot(self, snapshot_id):"},{"line_number":193,"context_line":"        \"\"\"Unmanages a snapshot.\"\"\""},{"line_number":194,"context_line":"        post_body \u003d json.dumps({\u0027os-unmanage\u0027: {}})"},{"line_number":195,"context_line":"        url \u003d \u0027snapshots/%s/action\u0027 % (snapshot_id)"},{"line_number":196,"context_line":"        resp, body \u003d self.post(url, post_body)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_c84c1473","line":193,"updated":"2016-12-02 12:00:29.000000000","message":"same","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"f4c52ec493e6c8478ec94d53441338c71695ae9a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def unmanage_snapshot(self, snapshot_id):"},{"line_number":193,"context_line":"        \"\"\"Unmanages a snapshot.\"\"\""},{"line_number":194,"context_line":"        post_body \u003d json.dumps({\u0027os-unmanage\u0027: {}})"},{"line_number":195,"context_line":"        url \u003d \u0027snapshots/%s/action\u0027 % (snapshot_id)"},{"line_number":196,"context_line":"        resp, body \u003d self.post(url, post_body)"}],"source_content_type":"text/x-python","patch_set":13,"id":"3a71b18c_d5daabe7","line":193,"in_reply_to":"3a71b18c_c84c1473","updated":"2016-12-05 09:50:06.000000000","message":"Done","commit_id":"2ba7fc2c14539021f9c4ba41df04993fa4a3b4ce"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"94c8932fcc82e4b44eaff99ad36067fffc11bddc","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manage a snapshot.\"\"\""},{"line_number":185,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":186,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"},{"line_number":187,"context_line":"        resp, body \u003d self.post(url, post_body)"},{"line_number":188,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":189,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_f805b079","line":186,"range":{"start_line":186,"start_character":15,"end_line":186,"end_character":33},"updated":"2017-01-05 23:38:27.000000000","message":"os-snapshot-manage API supports GET also according to cinderclient.\nSo it is nice to separate this method from snapshots_client and define a new snapshot_manage_client.py\n\nref: http://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient/v2/volume_snapshots.py","commit_id":"d481b5792e66798254ab674ced005d0673faabdd"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a9dac72438027e7b83f45a4bc02e93fbb319c99e","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    def manage_snapshot(self, **kwargs):"},{"line_number":184,"context_line":"        \"\"\"Manage a snapshot.\"\"\""},{"line_number":185,"context_line":"        post_body \u003d json.dumps({\u0027snapshot\u0027: kwargs})"},{"line_number":186,"context_line":"        url \u003d \u0027os-snapshot-manage\u0027"},{"line_number":187,"context_line":"        resp, body \u003d self.post(url, post_body)"},{"line_number":188,"context_line":"        self.expected_success(202, resp.status)"},{"line_number":189,"context_line":"        body \u003d json.loads(body)"}],"source_content_type":"text/x-python","patch_set":15,"id":"ba5201f7_e170940d","line":186,"range":{"start_line":186,"start_character":15,"end_line":186,"end_character":33},"in_reply_to":"ba5201f7_f805b079","updated":"2017-01-06 07:50:56.000000000","message":"Done","commit_id":"d481b5792e66798254ab674ced005d0673faabdd"}]}