)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"560659a3716f9a9629252910babedcbeab1cf124","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dont create network if vnic_type defined"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I25266d3641202c3099fd603c57945b718004cfd7"},{"line_number":10,"context_line":"Co-Authored-By: Moshe Levi \u003cmoshele@mellanox.com\u003e"},{"line_number":11,"context_line":"Closes-Bug: 1603758"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_7ed5671a","line":9,"updated":"2016-07-30 00:34:35.000000000","message":"need to write the reason why we need to do that on the commit message.\n\nref: https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages\n\n Do not assume the reviewer understands what the original problem was.","commit_id":"29909c7ca18d7324b1c15d43a37fe9fb1a170f8f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"b9647e9c5a5e64fb37e46357f15e0125716b3a1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing creating networks if vnic type defined."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If vnic_type defined create new networks only if they"},{"line_number":10,"context_line":"do not exist."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If we are passing a preexisting port during server create"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_4c01a405","line":9,"updated":"2016-08-01 15:26:11.000000000","message":"Did you mean `port` instead of network?","commit_id":"a01fc75e891f89bd01b9a3a65fdbdea0eb78b3ea"}],"tempest/scenario/manager.py":[{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"d8cf71bdffa0afae67c8af91442107c765eeb12a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        # every network"},{"line_number":184,"context_line":"        if vnic_type:"},{"line_number":185,"context_line":"            ports \u003d []"},{"line_number":186,"context_line":"            if not kwargs and not kwargs.pop(\u0027networks\u0027):"},{"line_number":187,"context_line":"                networks \u003d []"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: vnic_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_afbbbd74","line":186,"range":{"start_line":186,"start_character":34,"end_line":186,"end_character":56},"updated":"2016-07-17 14:57:31.000000000","message":"I think you should check if networks exists in kwargs","commit_id":"8abcf3bef29c067f909a243faf7d7d8a6cd4d6a3"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"605cf7a74a45c5ccc4427c8f410bba148342918d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        # every network"},{"line_number":184,"context_line":"        if vnic_type:"},{"line_number":185,"context_line":"            ports \u003d []"},{"line_number":186,"context_line":"            if not kwargs and not kwargs.pop(\u0027networks\u0027, None):"},{"line_number":187,"context_line":"                networks \u003d []"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"            create_port_body \u003d {\u0027binding:vnic_type\u0027: vnic_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_92ba62bf","line":186,"range":{"start_line":186,"start_character":33,"end_line":186,"end_character":62},"updated":"2016-07-17 15:53:33.000000000","message":"this is not what I meant.\nwhen you  kwargs.pop(\u0027networks\u0027) you are losing the networks if exist. \nso maybe better  to do \nif kwargs:\n    networks \u003d kwargs.pop(\u0027networks\u0027, [])\nelse:\n    networks \u003d []","commit_id":"305bf02b048afc6e211b5ef5c7276274fa712d29"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"560659a3716f9a9629252910babedcbeab1cf124","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                networks \u003d kwargs.pop(\u0027networks\u0027, [])"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                networks \u003d []"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            # If there are no networks passed to us we look up"},{"line_number":212,"context_line":"            # for the project\u0027s private networks and create a port"},{"line_number":213,"context_line":"            # if there is only one private network. The same behaviour"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9ee01bfc","line":210,"updated":"2016-07-30 00:34:35.000000000","message":"The above code seems good for me, but that seems out of scope from this patch purpose.","commit_id":"29909c7ca18d7324b1c15d43a37fe9fb1a170f8f"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"77cb883dcc9c203aa75db07583e8a79d968f1be4","unresolved":false,"context_lines":[{"line_number":207,"context_line":"                networks \u003d kwargs.pop(\u0027networks\u0027, [])"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                networks \u003d []"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            # If there are no networks passed to us we look up"},{"line_number":212,"context_line":"            # for the project\u0027s private networks and create a port"},{"line_number":213,"context_line":"            # if there is only one private network. The same behaviour"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8eed7bb9","line":210,"in_reply_to":"bacf61ea_9ee01bfc","updated":"2016-07-31 08:18:47.000000000","message":"we need to create new networks if they do not exist.\n( Unless I didn\u0027t get your comment )","commit_id":"29909c7ca18d7324b1c15d43a37fe9fb1a170f8f"}]}