)]}'
{"tempest/lib/cli/base.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"300422794611b7f5898f03157488090d42658447","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        :param merge_stderr: if True the stderr buffer is merged into stdout"},{"line_number":122,"context_line":"        :type merge_stderr: boolean"},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if cli not in [\u0027keystone\u0027, \u0027openstack\u0027]:"},{"line_number":125,"context_line":"            if cli in [\u0027cinder\u0027, \u0027neutron\u0027, \u0027sahara\u0027, \u0027trove\u0027]:"},{"line_number":126,"context_line":"                flags +\u003d \u0027 --endpoint-type %s\u0027 % endpoint_type"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                flags +\u003d \u0027 --os-endpoint-type %s\u0027 % endpoint_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_693b38ec","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":63},"updated":"2016-07-25 07:02:30.000000000","message":"Are these conditions always correct?\nAnd I\u0027m doubting that we can always provide proper condition for numerous OpenStack projects. Moreover, is this really useful for individual projects? This is just add only one line for the tests.","commit_id":"43d26689c9478aa8a9df43282ef03c5d4856ab62"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"36357209905911b5c89235c561e94d7b519d5a4c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        :param merge_stderr: if True the stderr buffer is merged into stdout"},{"line_number":122,"context_line":"        :type merge_stderr: boolean"},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if cli not in [\u0027keystone\u0027, \u0027openstack\u0027]:"},{"line_number":125,"context_line":"            if cli in [\u0027cinder\u0027, \u0027neutron\u0027, \u0027sahara\u0027, \u0027trove\u0027]:"},{"line_number":126,"context_line":"                flags +\u003d \u0027 --endpoint-type %s\u0027 % endpoint_type"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                flags +\u003d \u0027 --os-endpoint-type %s\u0027 % endpoint_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_ff919a47","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":63},"in_reply_to":"dada55a8_693b38ec","updated":"2016-07-25 07:47:55.000000000","message":"Yes, these will be always correct as for as my understanding.\nThis is done because in case of \"keystone\" and \"openstack\" CLIs endpoint_type is not considered. but in any other case we have to consider endpoint_type. Again in some projects endpoint type keyword is \"--endpoint-type\" and in some \"--os-endpoint-type\" so again we have to take care of this and so check is introduced.\nIf new project CLIs are being added then we have to ensure whether it is \"--endpoint-type\" or \"--os-endpoint-type\" based on that we have to add keyword here.","commit_id":"43d26689c9478aa8a9df43282ef03c5d4856ab62"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"57cea83e71df7a9cc2ce9d0377b1e2c0c4ea4b83","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        :param merge_stderr: if True the stderr buffer is merged into stdout"},{"line_number":122,"context_line":"        :type merge_stderr: boolean"},{"line_number":123,"context_line":"        \"\"\""},{"line_number":124,"context_line":"        if cli not in [\u0027keystone\u0027, \u0027openstack\u0027]:"},{"line_number":125,"context_line":"            if cli in [\u0027cinder\u0027, \u0027neutron\u0027, \u0027sahara\u0027, \u0027trove\u0027]:"},{"line_number":126,"context_line":"                flags +\u003d \u0027 --endpoint-type %s\u0027 % endpoint_type"},{"line_number":127,"context_line":"            else:"},{"line_number":128,"context_line":"                flags +\u003d \u0027 --os-endpoint-type %s\u0027 % endpoint_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_3f3e92da","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":63},"in_reply_to":"dada55a8_ff919a47","updated":"2016-07-25 08:16:10.000000000","message":"I actually don\u0027t think we should have \u0027trove\u0027 and \u0027sahara\u0027 (and the other non-core project) names in tempest because they should be as a plugin.","commit_id":"43d26689c9478aa8a9df43282ef03c5d4856ab62"}]}