)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cdc70832819c8fae039291b95d9ce9562bde295d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Volume encrypted actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added testcases for volume encryptions"},{"line_number":10,"context_line":"- test_volume_encrypted_upload"},{"line_number":11,"context_line":"- test_volume_encrypted_snapshots"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I165fbae6934db20888f7e98bf68b8f7ea3bd8c3b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dada55a8_bbe50839","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":33},"updated":"2016-07-21 04:03:35.000000000","message":"I\u0027m actually not sure the difference between encrypted and non-encrypted  tests in the API testing viewpoint.\n\nWe already have the non-encrypted tests in test_volumes_actions and it seems same as this test.","commit_id":"332893cdb4a416d228adffa90cc834ac7ec03c50"}],"tempest/api/volume/admin/test_volume_types.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f03294b9b62c76f654fe3bb72672a7c9d38ba6a6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        encrypted_params \u003d {"},{"line_number":121,"context_line":"            \"provider\": CONF.volume.encrypted_provider,"},{"line_number":122,"context_line":"            \"control_location\": CONF.volume.encrypted_control_location,"},{"line_number":123,"context_line":"            \"cipher\": CONF.volume.encrypted_cipher,"},{"line_number":124,"context_line":"            \"key_size\": CONF.volume.encrypted_key_size}"},{"line_number":125,"context_line":"        body \u003d self.create_volume_type()"},{"line_number":126,"context_line":"        # Create encryption type"},{"line_number":127,"context_line":"        encryption_type \u003d \\"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_846c77d1","line":124,"range":{"start_line":123,"start_character":0,"end_line":124,"end_character":55},"updated":"2017-02-07 09:07:42.000000000","message":"These two attributes are not checked below.\nIf it is not so necessary to check them, then it\u0027s not necessary to specify them.","commit_id":"df2a01e8e07dac8c11eb8bf218e3713ec9b6f611"}],"tempest/api/volume/admin/test_volumes_encrypted_actions.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"6977d803753606e9830ae17433d82d67145e90d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_e2780d92","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-15 11:49:15.000000000","message":"Hi Benny, this lines need to be removed or update to your company\u0027s.","commit_id":"6f5dd4f18ee738f8143b2aaa05eeb4c6ea58b399"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"0d38d12c16ad89265fd150fe4ee5fd7847886af3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Red Hat"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_349223a0","line":1,"updated":"2016-08-16 11:59:23.000000000","message":"Red Hat, Inc.\n\nSee: https://github.com/openstack/tempest/blob/master/tempest/api/volume/test_volumes_backup.py#L1","commit_id":"cd59c9cb420607f540200188276f3255d15bbc3a"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ab830af80b3b58cf94d54e61fd0a4e0f88bd9d69","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumesV2EncryptedActionsTest(base.BaseVolumeAdminTest):"},{"line_number":28,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_cffcc474","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":38},"updated":"2017-01-09 09:39:34.000000000","message":"This is already defined in super","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d8ad553193aa5e49fff9006fdd7f29edba13a96b","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class VolumesV2EncryptedActionsTest(base.BaseVolumeAdminTest):"},{"line_number":28,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"},{"line_number":31,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_d4f7538a","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":38},"in_reply_to":"ba5201f7_cffcc474","updated":"2017-01-10 11:51:29.000000000","message":"Yes , fixed.","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":7020,"name":"Joe Hakim Rahme","email":"jhakimra@redhat.com","username":"rahmu"},"change_message_id":"e2e43e82b374ff1e9fbb5a1d68831b6d46f9fd77","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def resource_setup(cls):"},{"line_number":47,"context_line":"        super(VolumesV2EncryptedActionsTest, cls).resource_setup()"},{"line_number":48,"context_line":"        provider \u003d \"LuksEncryptor\""},{"line_number":49,"context_line":"        control_location \u003d \"front-end\""},{"line_number":50,"context_line":"        name \u003d utils.rand_name(\"encrypted-volume-type\")"},{"line_number":51,"context_line":"        volume_name \u003d utils.rand_name(\"encrypted-volume\")"},{"line_number":52,"context_line":"        # Create a volume type"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_ca9da40b","line":49,"updated":"2016-09-07 09:30:58.000000000","message":"I\u0027m not a fan of having these magic strings in the test code. Do you think it\u0027s a good idea to have these values defined in the config? This should give operators more flexibility.\n\nI\u0027m not familiar with encryption types, so take this recommendation with a grain of salt.","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"cf4302b4fdb575003d91fc7c00b111a9f48b65db","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def resource_setup(cls):"},{"line_number":47,"context_line":"        super(VolumesV2EncryptedActionsTest, cls).resource_setup()"},{"line_number":48,"context_line":"        provider \u003d \"LuksEncryptor\""},{"line_number":49,"context_line":"        control_location \u003d \"front-end\""},{"line_number":50,"context_line":"        name \u003d utils.rand_name(\"encrypted-volume-type\")"},{"line_number":51,"context_line":"        volume_name \u003d utils.rand_name(\"encrypted-volume\")"},{"line_number":52,"context_line":"        # Create a volume type"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_14296637","line":49,"in_reply_to":"9a89bdaa_ca9da40b","updated":"2016-09-07 12:15:16.000000000","message":"There are other tests for encryption with \"hardcoded\" configuration in the resource_setup , i am aiming to test the encrypted backend actions , assuming that the volume type already encrypted.\n\nI will add another patch fixing to hardcoded stuff.","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ab830af80b3b58cf94d54e61fd0a4e0f88bd9d69","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        super(VolumesV2EncryptedActionsTest, cls).resource_setup()"},{"line_number":48,"context_line":"        provider \u003d \"LuksEncryptor\""},{"line_number":49,"context_line":"        control_location \u003d \"front-end\""},{"line_number":50,"context_line":"        name \u003d utils.rand_name(\"encrypted-volume-type\")"},{"line_number":51,"context_line":"        volume_name \u003d utils.rand_name(\"encrypted-volume\")"},{"line_number":52,"context_line":"        # Create a volume type"},{"line_number":53,"context_line":"        cls.volume_type \u003d cls.create_volume_type(name\u003dname)"},{"line_number":54,"context_line":"        # Create an encrypted type"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_d0107c5c","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":57},"updated":"2017-01-09 09:39:34.000000000","message":"It seems no name definitions are needed here because in super\u0027s create function, random name with class name as prefix is generated, which will help debugging.","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d8ad553193aa5e49fff9006fdd7f29edba13a96b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        super(VolumesV2EncryptedActionsTest, cls).resource_setup()"},{"line_number":48,"context_line":"        provider \u003d \"LuksEncryptor\""},{"line_number":49,"context_line":"        control_location \u003d \"front-end\""},{"line_number":50,"context_line":"        name \u003d utils.rand_name(\"encrypted-volume-type\")"},{"line_number":51,"context_line":"        volume_name \u003d utils.rand_name(\"encrypted-volume\")"},{"line_number":52,"context_line":"        # Create a volume type"},{"line_number":53,"context_line":"        cls.volume_type \u003d cls.create_volume_type(name\u003dname)"},{"line_number":54,"context_line":"        # Create an encrypted type"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_545fe374","line":51,"range":{"start_line":50,"start_character":0,"end_line":51,"end_character":57},"in_reply_to":"ba5201f7_d0107c5c","updated":"2017-01-10 11:51:29.000000000","message":"fixed","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ab830af80b3b58cf94d54e61fd0a4e0f88bd9d69","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        cls.admin_volume_types_client.wait_for_resource_deletion(resource)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @test.idempotent_id(\u0027adf5916e-c646-4286-8eda-48c45df9bd79\u0027)"},{"line_number":77,"context_line":"    def test_volume_encrypted_upload(self):"},{"line_number":78,"context_line":"        image_name \u003d utils.rand_name(\u0027Image\u0027)"},{"line_number":79,"context_line":"        # Upload an encrypted volume to image"},{"line_number":80,"context_line":"        body \u003d self.volumes_client.upload_volume("}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_333632e8","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":36},"updated":"2017-01-09 09:39:34.000000000","message":"will test_volume_encrypted_image look better?","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d8ad553193aa5e49fff9006fdd7f29edba13a96b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        cls.admin_volume_types_client.wait_for_resource_deletion(resource)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    @test.idempotent_id(\u0027adf5916e-c646-4286-8eda-48c45df9bd79\u0027)"},{"line_number":77,"context_line":"    def test_volume_encrypted_upload(self):"},{"line_number":78,"context_line":"        image_name \u003d utils.rand_name(\u0027Image\u0027)"},{"line_number":79,"context_line":"        # Upload an encrypted volume to image"},{"line_number":80,"context_line":"        body \u003d self.volumes_client.upload_volume("}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_7499471f","line":77,"range":{"start_line":77,"start_character":8,"end_line":77,"end_character":36},"in_reply_to":"ba5201f7_333632e8","updated":"2017-01-10 11:51:29.000000000","message":"changed","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ab830af80b3b58cf94d54e61fd0a4e0f88bd9d69","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":88,"context_line":"                                       self.encrypted_volume[\u0027id\u0027],"},{"line_number":89,"context_line":"                                       \u0027available\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.idempotent_id(\u0027980b8931-02cb-47f7-b8a4-3e5b2422659f\u0027)"},{"line_number":92,"context_line":"    def test_volume_encrypted_snapshots(self):"},{"line_number":93,"context_line":"        # Create a snapshot from encrypted volume"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_d37a4677","line":90,"updated":"2017-01-09 09:39:34.000000000","message":"Is there anything to check? just as test_volume_encrypted_snapshots does","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"d8ad553193aa5e49fff9006fdd7f29edba13a96b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        waiters.wait_for_volume_status(self.volumes_client,"},{"line_number":88,"context_line":"                                       self.encrypted_volume[\u0027id\u0027],"},{"line_number":89,"context_line":"                                       \u0027available\u0027)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    @test.idempotent_id(\u0027980b8931-02cb-47f7-b8a4-3e5b2422659f\u0027)"},{"line_number":92,"context_line":"    def test_volume_encrypted_snapshots(self):"},{"line_number":93,"context_line":"        # Create a snapshot from encrypted volume"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba5201f7_347edfae","line":90,"in_reply_to":"ba5201f7_d37a4677","updated":"2017-01-10 11:51:29.000000000","message":"just to create a snapshot , check its doable with encrypted volume","commit_id":"9ada2edb51d7b2dcbba0352383231375dabd5cfa"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f03294b9b62c76f654fe3bb72672a7c9d38ba6a6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        # Create a volume type"},{"line_number":61,"context_line":"        cls.volume_type \u003d cls.create_volume_type()"},{"line_number":62,"context_line":"        # Create an encrypted type"},{"line_number":63,"context_line":"        cls.encryption_type \u003d \\"},{"line_number":64,"context_line":"            cls.create_volume_encryption_type("},{"line_number":65,"context_line":"                volume_type_id\u003dcls.volume_type[\u0027id\u0027],"},{"line_number":66,"context_line":"                **encrypted_params)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_f0e336a2","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":27},"updated":"2017-02-07 09:07:42.000000000","message":"this is not used anywhere","commit_id":"df2a01e8e07dac8c11eb8bf218e3713ec9b6f611"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f03294b9b62c76f654fe3bb72672a7c9d38ba6a6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                volume_type_id\u003dcls.volume_type[\u0027id\u0027],"},{"line_number":66,"context_line":"                **encrypted_params)"},{"line_number":67,"context_line":"        # Create an encrypted shared volume"},{"line_number":68,"context_line":"        cls.encrypted_volume \u003d cls.create_volume("},{"line_number":69,"context_line":"            size\u003dCONF.volume.volume_size,"},{"line_number":70,"context_line":"            volume_type\u003dcls.volume_type[\u0027name\u0027])"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_10f8c248","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":28},"updated":"2017-02-07 09:07:42.000000000","message":"the volume seems not to be an \"encrypted_volume\"","commit_id":"df2a01e8e07dac8c11eb8bf218e3713ec9b6f611"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f03294b9b62c76f654fe3bb72672a7c9d38ba6a6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        body \u003d self.volumes_client.upload_volume("},{"line_number":77,"context_line":"            self.encrypted_volume[\u0027id\u0027], image_name\u003dimage_name,"},{"line_number":78,"context_line":"            disk_format\u003dCONF.volume.disk_format)[\u0027os-volume_upload_image\u0027]"},{"line_number":79,"context_line":"        image_id \u003d body[\"image_id\"]"},{"line_number":80,"context_line":"        self.addCleanup(self.image_client.delete_image, image_id)"},{"line_number":81,"context_line":"        # Wait till volume and image are ready"},{"line_number":82,"context_line":"        waiters.wait_for_image_status(self.image_client, image_id, \u0027active\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_b060ce02","line":79,"range":{"start_line":79,"start_character":8,"end_line":79,"end_character":35},"updated":"2017-02-07 09:07:42.000000000","message":"shall we check body has \u0027image_id\u0027 key? because upload_volume may fail","commit_id":"df2a01e8e07dac8c11eb8bf218e3713ec9b6f611"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"971fda86dcb9f80cdd270252f2b8c9cadd2a0bc0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(VolumesV2EncryptedActionsTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027:"},{"line_number":33,"context_line":"            skip_msg \u003d (\"%s skipped as ceph volume encrypted volume is not\""},{"line_number":34,"context_line":"                        \" yet supported\" % cls.__name__)"},{"line_number":35,"context_line":"            raise cls.skipException(skip_msg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da36d5c6_1129508a","line":32,"updated":"2017-02-25 14:11:50.000000000","message":"Please disable this in the configuration of the Ceph job. We can\u0027t have statements such as:\n\nif storage \u003d\u003d ceph:\n  do this\nelif  storage \u003d\u003d netapp:\n  do that\nelif storage \u003d\u003d ibm\n  do that\n\nThis is not how Tempest work. Ceph is not special in that regards.","commit_id":"43babf376bbd70d59b6acfddf416b515621d6363"},{"author":{"_account_id":11075,"name":"Benny Kopilov","email":"bkopilov@redhat.com","username":"bkopilov"},"change_message_id":"44537c4aabb30f3f057214d0dfdb0aef31957c04","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def skip_checks(cls):"},{"line_number":31,"context_line":"        super(VolumesV2EncryptedActionsTest, cls).skip_checks()"},{"line_number":32,"context_line":"        if CONF.volume.storage_protocol \u003d\u003d \u0027ceph\u0027:"},{"line_number":33,"context_line":"            skip_msg \u003d (\"%s skipped as ceph volume encrypted volume is not\""},{"line_number":34,"context_line":"                        \" yet supported\" % cls.__name__)"},{"line_number":35,"context_line":"            raise cls.skipException(skip_msg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"da36d5c6_ea80084c","line":32,"in_reply_to":"da36d5c6_1129508a","updated":"2017-02-28 04:32:29.000000000","message":"Done","commit_id":"43babf376bbd70d59b6acfddf416b515621d6363"}],"tempest/api/volume/base.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f03294b9b62c76f654fe3bb72672a7c9d38ba6a6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        cls.volume_types.append(volume_type[\u0027id\u0027])"},{"line_number":303,"context_line":"        return volume_type"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    @classmethod"},{"line_number":306,"context_line":"    def create_volume_encryption_type(cls, volume_type_id, **kwargs):"},{"line_number":307,"context_line":"        \"\"\"Create a test encrypted-volume-type\"\"\""},{"line_number":308,"context_line":"        volume_encrypted_type \u003d \\"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_04b88729","line":305,"range":{"start_line":305,"start_character":4,"end_line":305,"end_character":16},"updated":"2017-02-07 09:07:42.000000000","message":"this function seems no need to be a classmethod, because it seems we won\u0027t call it in resource_setup","commit_id":"df2a01e8e07dac8c11eb8bf218e3713ec9b6f611"}],"tempest/config.py":[{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"46512c72be10e6d92456a5aed454c3d5369968a3","unresolved":false,"context_lines":[{"line_number":774,"context_line":"    cfg.StrOpt(\u0027encrypted_control_location\u0027,"},{"line_number":775,"context_line":"               default\u003d\"front-end\","},{"line_number":776,"context_line":"               help\u003d\u0027Service where encryption is performed. Valid values are\u0027"},{"line_number":777,"context_line":"                    \u0027 \"front-end\" or \"back-end.\"\u0027),"},{"line_number":778,"context_line":"    cfg.StrOpt(\u0027encrypted_cipher\u0027,"},{"line_number":779,"context_line":"               default\u003dNone,"},{"line_number":780,"context_line":"               help\u003d\u0027The encryption algorithm or mode. For example,\u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_abd406bd","line":777,"range":{"start_line":777,"start_character":37,"end_line":777,"end_character":48},"updated":"2017-01-11 06:53:24.000000000","message":"\"back-end\"","commit_id":"bc16126eae2ba77c829c02adaa259d55710badff"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"46512c72be10e6d92456a5aed454c3d5369968a3","unresolved":false,"context_lines":[{"line_number":776,"context_line":"               help\u003d\u0027Service where encryption is performed. Valid values are\u0027"},{"line_number":777,"context_line":"                    \u0027 \"front-end\" or \"back-end.\"\u0027),"},{"line_number":778,"context_line":"    cfg.StrOpt(\u0027encrypted_cipher\u0027,"},{"line_number":779,"context_line":"               default\u003dNone,"},{"line_number":780,"context_line":"               help\u003d\u0027The encryption algorithm or mode. For example,\u0027"},{"line_number":781,"context_line":"                    \u0027 aes-xts-plain64\u0027),"},{"line_number":782,"context_line":"    cfg.IntOpt(\u0027encrypted_key_size\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_0b9432e0","line":779,"range":{"start_line":779,"start_character":23,"end_line":779,"end_character":27},"updated":"2017-01-11 06:53:24.000000000","message":"better to have a default value","commit_id":"bc16126eae2ba77c829c02adaa259d55710badff"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"46512c72be10e6d92456a5aed454c3d5369968a3","unresolved":false,"context_lines":[{"line_number":778,"context_line":"    cfg.StrOpt(\u0027encrypted_cipher\u0027,"},{"line_number":779,"context_line":"               default\u003dNone,"},{"line_number":780,"context_line":"               help\u003d\u0027The encryption algorithm or mode. For example,\u0027"},{"line_number":781,"context_line":"                    \u0027 aes-xts-plain64\u0027),"},{"line_number":782,"context_line":"    cfg.IntOpt(\u0027encrypted_key_size\u0027,"},{"line_number":783,"context_line":"               default\u003dNone,"},{"line_number":784,"context_line":"               help\u003d\u0027Size of encryption key in bits. example 128 or 256\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_ebfd2e3c","line":781,"range":{"start_line":781,"start_character":21,"end_line":781,"end_character":22},"updated":"2017-01-11 06:53:24.000000000","message":"better to put the space at the end of previous line","commit_id":"bc16126eae2ba77c829c02adaa259d55710badff"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"46512c72be10e6d92456a5aed454c3d5369968a3","unresolved":false,"context_lines":[{"line_number":780,"context_line":"               help\u003d\u0027The encryption algorithm or mode. For example,\u0027"},{"line_number":781,"context_line":"                    \u0027 aes-xts-plain64\u0027),"},{"line_number":782,"context_line":"    cfg.IntOpt(\u0027encrypted_key_size\u0027,"},{"line_number":783,"context_line":"               default\u003dNone,"},{"line_number":784,"context_line":"               help\u003d\u0027Size of encryption key in bits. example 128 or 256\u0027),"},{"line_number":785,"context_line":"    cfg.StrOpt(\u0027min_microversion\u0027,"},{"line_number":786,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba5201f7_6bbf7e60","line":783,"range":{"start_line":783,"start_character":23,"end_line":783,"end_character":27},"updated":"2017-01-11 06:53:24.000000000","message":"better to have a default value","commit_id":"bc16126eae2ba77c829c02adaa259d55710badff"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f03294b9b62c76f654fe3bb72672a7c9d38ba6a6","unresolved":false,"context_lines":[{"line_number":768,"context_line":"    cfg.IntOpt(\u0027volume_size\u0027,"},{"line_number":769,"context_line":"               default\u003d1,"},{"line_number":770,"context_line":"               help\u003d\u0027Default size in GB for volumes created by volumes tests\u0027),"},{"line_number":771,"context_line":"    cfg.StrOpt(\u0027encrypted_provider\u0027,"},{"line_number":772,"context_line":"               default\u003d\"LuksEncryptor\","},{"line_number":773,"context_line":"               help\u003d\u0027The class that provides encryption support. \u0027"},{"line_number":774,"context_line":"                    \u0027For example, nova.volume.encryptors.luks.LuksEncryptor \u0027"},{"line_number":775,"context_line":"                    \u0027nova.volume.encryptors.cryptsetup.CryptsetupEncryptor\u0027),"},{"line_number":776,"context_line":"    cfg.StrOpt(\u0027encrypted_control_location\u0027,"},{"line_number":777,"context_line":"               default\u003d\"front-end\","},{"line_number":778,"context_line":"               help\u003d\u0027Service where encryption is performed. Valid values are\u0027"},{"line_number":779,"context_line":"                    \u0027 \"front-end\" or \"back-end\"\u0027),"},{"line_number":780,"context_line":"    cfg.StrOpt(\u0027encrypted_cipher\u0027,"},{"line_number":781,"context_line":"               default\u003dNone,"},{"line_number":782,"context_line":"               help\u003d\u0027The encryption algorithm or mode. For example, \u0027"},{"line_number":783,"context_line":"                    \u0027aes-xts-plain64 or aes-cbc-essiv\u0027),"},{"line_number":784,"context_line":"    cfg.IntOpt(\u0027encrypted_key_size\u0027,"},{"line_number":785,"context_line":"               default\u003dNone,"},{"line_number":786,"context_line":"               help\u003d\u0027Size of encryption key in bits. \u0027"},{"line_number":787,"context_line":"                    \u0027For example 128 or 256 or 512\u0027),"},{"line_number":788,"context_line":"    cfg.StrOpt(\u0027min_microversion\u0027,"},{"line_number":789,"context_line":"               default\u003dNone,"},{"line_number":790,"context_line":"               help\u003d\"Lower version of the test target microversion range. \""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a430d35_a47fb364","line":787,"range":{"start_line":771,"start_character":0,"end_line":787,"end_character":53},"updated":"2017-02-07 09:07:42.000000000","message":"still I wonder whether it worth adding so many items in config?","commit_id":"df2a01e8e07dac8c11eb8bf218e3713ec9b6f611"}]}