)]}'
{"tempest/lib/services/clients.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"da6a1a9436daa594b0a717a7651fad5b911086c3","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Provides a list of service modules available Tempest not yet migrated to"},{"line_number":44,"context_line":"    tempest.lib."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return set([\u0027identity.v2\u0027, \u0027identity.v3\u0027, \u0027object-storage\u0027, \u0027volume.v1\u0027,"},{"line_number":47,"context_line":"                \u0027volume.v2\u0027, \u0027volume.v3\u0027])"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_763779b0","line":45,"updated":"2016-08-04 04:09:31.000000000","message":"So this technically is a stable interface as soon as we moved it to lib. I\u0027m not sure we can just change what this function does after it\u0027s already landed in tempest.lib. Granted I find it unlikely that in the short window between the patches landing someone is using this I still think we should not change the meaning of this function. We either need to do this when we moved it to lib or add a new function (or what would probably be better is a tempest_lib_modules() function and subtract that from this)","commit_id":"bb62f1245171e5bc738bd38130f370b4d7870bee"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"bc050fa1de729466f32092b6bc595492be9d8039","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    Provides a list of service modules available Tempest not yet migrated to"},{"line_number":44,"context_line":"    tempest.lib."},{"line_number":45,"context_line":"    \"\"\""},{"line_number":46,"context_line":"    return set([\u0027identity.v2\u0027, \u0027identity.v3\u0027, \u0027object-storage\u0027, \u0027volume.v1\u0027,"},{"line_number":47,"context_line":"                \u0027volume.v2\u0027, \u0027volume.v3\u0027])"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_05e8770f","line":45,"in_reply_to":"bacf61ea_763779b0","updated":"2016-08-04 10:12:57.000000000","message":"ok, that\u0027s a fair point. I originally wanted to do this before moving clients to tempest.lib, but I couldn\u0027t do that because I cannot import in config (stable interface) an unstable interface (service_clients).\n\nI\u0027ll implement the tempest_lib_modules option. Eventually it will match tempest_modules, but tempest_lib, after which we may consider deprecating this and remove it in 6 months time.","commit_id":"bb62f1245171e5bc738bd38130f370b4d7870bee"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"de6d66e312a2ffa4e7d4c6cec0a903ea18a47bc4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"def tempest_lib_modules():"},{"line_number":51,"context_line":"    \"\"\"List of stable service client modules available in Tempest."},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    Provides a list of stable service modules available Tempest under the"},{"line_number":54,"context_line":"    tempest.lib namespace."},{"line_number":55,"context_line":"    \"\"\""},{"line_number":56,"context_line":"    return set([\u0027compute\u0027, \u0027image.v1\u0027, \u0027image.v2\u0027, \u0027network\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_d37573cb","line":53,"updated":"2016-08-04 16:02:55.000000000","message":"nit: s/list/set","commit_id":"defd02836d3902605b128aff37da0d024e63261a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"833f49671b4b37b68bec678372a07aff6a023a00","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                    LOG.exception("},{"line_number":370,"context_line":"                        \u0027Failed to register service client from plugin %s \u0027"},{"line_number":371,"context_line":"                        \u0027with parameters %s\u0027 % (plugin, service_client))"},{"line_number":372,"context_line":"                    raise"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def register_service_client_module(self, name, service_version,"},{"line_number":375,"context_line":"                                       module_path, client_names, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_e79e8206","line":372,"range":{"start_line":372,"start_character":18,"end_line":372,"end_character":25},"updated":"2016-08-08 09:01:54.000000000","message":"1 idea (while seeing failure on PS7) for better exceptions. May be we can save the all exceptions occurring during registering the exposed service clients and re-raise with all duplicate service client in exception.\n\nCurrently it will raise on very first duplicate client.\n\nif this can be helpful we can improve this later.","commit_id":"8420abea55b1528dc77a585a23b3cbbfbd418b7a"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"646793e4136e7f985ec0a7b82e6461c39202bdb1","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                    LOG.exception("},{"line_number":370,"context_line":"                        \u0027Failed to register service client from plugin %s \u0027"},{"line_number":371,"context_line":"                        \u0027with parameters %s\u0027 % (plugin, service_client))"},{"line_number":372,"context_line":"                    raise"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def register_service_client_module(self, name, service_version,"},{"line_number":375,"context_line":"                                       module_path, client_names, **kwargs):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_4a5f930e","line":372,"range":{"start_line":372,"start_character":18,"end_line":372,"end_character":25},"in_reply_to":"9ad45d7e_e79e8206","updated":"2016-08-08 09:05:09.000000000","message":"Nice idea, I will prepare a patch for that","commit_id":"8420abea55b1528dc77a585a23b3cbbfbd418b7a"}]}