)]}'
{"tempest/scenario/test_network_advanced_server_ops.py":[{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"c6129f96ac624de65871bedcea92b493f63ce1ca","unresolved":false,"context_lines":[{"line_number":207,"context_line":"        server, keypair, floating_ip \u003d self._setup_network_and_servers()"},{"line_number":208,"context_line":"        src_host \u003d server[\u0027hostId\u0027]"},{"line_number":209,"context_line":"        self.admin_servers_client.migrate_server(server[\u0027id\u0027])"},{"line_number":210,"context_line":"        waiters.wait_for_server_status(self.servers_client, server[\u0027id\u0027],"},{"line_number":211,"context_line":"                                       \u0027VERIFY_RESIZE\u0027)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.servers_client.revert_resize_server(server[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1cc68549","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":8},"updated":"2016-08-02 13:12:23.000000000","message":"dont we need to verify that we have 2 computes?","commit_id":"5e1a0bab62b5f231d493377280760159a3a57a0d"},{"author":{"_account_id":16437,"name":"Anna Babich","email":"anna.v.babich@gmail.com","username":"ababich"},"change_message_id":"e00ce97f4b4d1b0f4da9cb67b70061ce720add02","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    def test_server_connectivity_migration_revert(self):"},{"line_number":221,"context_line":"        host_client \u003d self.admin_hosts_client"},{"line_number":222,"context_line":"        hosts \u003d host_client.list_hosts()[\u0027hosts\u0027]"},{"line_number":223,"context_line":"        computes \u003d [x for x in hosts if x[\u0027service\u0027] \u003d\u003d \u0027compute\u0027]"},{"line_number":224,"context_line":"        if len(computes) \u003c 2:"},{"line_number":225,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":226,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a95cdbc_bb54e3c9","line":223,"updated":"2016-10-10 12:17:09.000000000","message":"Suppose, that you don\u0027t need such a check here, just use @testtools.skipUnless() decorator for min_compute_nodes parameter from ComputeGroup config","commit_id":"9a71e585ecae8136432c85575e427950450ad441"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"74344e103f9dc5f732d4497799d1f25d71092262","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    def test_server_connectivity_migration_revert(self):"},{"line_number":221,"context_line":"        host_client \u003d self.admin_hosts_client"},{"line_number":222,"context_line":"        hosts \u003d host_client.list_hosts()[\u0027hosts\u0027]"},{"line_number":223,"context_line":"        computes \u003d [x for x in hosts if x[\u0027service\u0027] \u003d\u003d \u0027compute\u0027]"},{"line_number":224,"context_line":"        if len(computes) \u003c 2:"},{"line_number":225,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":226,"context_line":"            raise self.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_84fea003","line":223,"in_reply_to":"1a95cdbc_bb54e3c9","updated":"2016-10-18 13:24:31.000000000","message":"Done","commit_id":"9a71e585ecae8136432c85575e427950450ad441"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ea9fb5d665a09905a507f76d0fac5a6a4f19595","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                          \u0027Migrate is not available.\u0027)"},{"line_number":227,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":228,"context_line":"    def test_server_connectivity_cold_migration_revert(self):"},{"line_number":229,"context_line":"        if CONF.compute.min_compute_nodes \u003c 2:"},{"line_number":230,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":231,"context_line":"            raise self.skipException(msg)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":234,"context_line":"        server \u003d self._setup_server(keypair)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_7c7e72e5","line":231,"range":{"start_line":229,"start_character":0,"end_line":231,"end_character":41},"updated":"2016-12-13 16:56:05.000000000","message":"nit: Would\n\n    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003c 2,\n                          \u0027Require more than two compute nodes\u0027)\n\nbe valid?","commit_id":"1ee0ec534e42e2efbb45b9d9fe601e3d39aaa176"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ebbf87dc5f3a3aca491d5788faac205ec14c7d77","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                          \u0027Migrate is not available.\u0027)"},{"line_number":227,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":228,"context_line":"    def test_server_connectivity_cold_migration_revert(self):"},{"line_number":229,"context_line":"        if CONF.compute.min_compute_nodes \u003c 2:"},{"line_number":230,"context_line":"            msg \u003d \"Less than 2 compute nodes, skipping multinode tests.\""},{"line_number":231,"context_line":"            raise self.skipException(msg)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        keypair \u003d self.create_keypair()"},{"line_number":234,"context_line":"        server \u003d self._setup_server(keypair)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_4a8723d7","line":231,"range":{"start_line":229,"start_character":0,"end_line":231,"end_character":41},"in_reply_to":"1a6eadb0_7c7e72e5","updated":"2016-12-13 19:23:57.000000000","message":"Done","commit_id":"1ee0ec534e42e2efbb45b9d9fe601e3d39aaa176"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3ea9fb5d665a09905a507f76d0fac5a6a4f19595","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":244,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":245,"context_line":"            server, keypair, floating_ip)"},{"line_number":246,"context_line":"        dst_host \u003d self.servers_client.show_server("},{"line_number":247,"context_line":"            server[\u0027id\u0027])[\u0027server\u0027][\u0027hostId\u0027]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_1cabbe1e","line":247,"range":{"start_line":246,"start_character":8,"end_line":247,"end_character":45},"updated":"2016-12-13 16:56:05.000000000","message":"What\u0027s the difference between this and:\n\n    dst_host \u003d self._get_host_for_server(server[\u0027id\u0027])\n\nOr, more specifically, what\u0027s the difference between \u0027OS-EXT-SRV-ATTR:host\u0027 and \u0027hostId\u0027?","commit_id":"1ee0ec534e42e2efbb45b9d9fe601e3d39aaa176"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"ebbf87dc5f3a3aca491d5788faac205ec14c7d77","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        self.servers_client.revert_resize_server(server[\u0027id\u0027])"},{"line_number":244,"context_line":"        self._wait_server_status_and_check_network_connectivity("},{"line_number":245,"context_line":"            server, keypair, floating_ip)"},{"line_number":246,"context_line":"        dst_host \u003d self.servers_client.show_server("},{"line_number":247,"context_line":"            server[\u0027id\u0027])[\u0027server\u0027][\u0027hostId\u0027]"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertEqual(src_host, dst_host)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_8afe9b36","line":247,"range":{"start_line":246,"start_character":8,"end_line":247,"end_character":45},"in_reply_to":"1a6eadb0_1cabbe1e","updated":"2016-12-13 19:23:57.000000000","message":"Done\n\nGood catch, looks like I was using it for test_server_connectivity_cold_migration().  Probably forgot at some point to align it.\n\nTBH Not sure what is the difference between host and hostid, but I think one is the name and the other is an id.","commit_id":"1ee0ec534e42e2efbb45b9d9fe601e3d39aaa176"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"15b5b2bdf73ba63af9942e62f1c9508f04d0c4dc","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":200,"context_line":"                          \u0027Cold migration is not available.\u0027)"},{"line_number":201,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":202,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode\u0027"},{"line_number":203,"context_line":"                          \u0027tests.\u0027)"},{"line_number":204,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":205,"context_line":"    def test_server_connectivity_cold_migration(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_307291ae","line":202,"range":{"start_line":202,"start_character":63,"end_line":202,"end_character":72},"updated":"2016-12-19 00:00:23.000000000","message":"nit: A space is necessary after multinode","commit_id":"e6be9f46266d5a7076c4e35c175a47c2ac269e3f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"5b0a861164a19a79b1e4227c55b777c824502121","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":200,"context_line":"                          \u0027Cold migration is not available.\u0027)"},{"line_number":201,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":202,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode\u0027"},{"line_number":203,"context_line":"                          \u0027tests.\u0027)"},{"line_number":204,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":205,"context_line":"    def test_server_connectivity_cold_migration(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_c6c35089","line":202,"range":{"start_line":202,"start_character":63,"end_line":202,"end_character":72},"in_reply_to":"1a6eadb0_307291ae","updated":"2016-12-19 13:20:29.000000000","message":"Done","commit_id":"e6be9f46266d5a7076c4e35c175a47c2ac269e3f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"15b5b2bdf73ba63af9942e62f1c9508f04d0c4dc","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":225,"context_line":"                          \u0027Migrate is not available.\u0027)"},{"line_number":226,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":227,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode\u0027"},{"line_number":228,"context_line":"                          \u0027tests.\u0027)"},{"line_number":229,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":230,"context_line":"    def test_server_connectivity_cold_migration_revert(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_9061a5d6","line":227,"range":{"start_line":227,"start_character":63,"end_line":227,"end_character":72},"updated":"2016-12-19 00:00:23.000000000","message":"ditto","commit_id":"e6be9f46266d5a7076c4e35c175a47c2ac269e3f"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"5b0a861164a19a79b1e4227c55b777c824502121","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":225,"context_line":"                          \u0027Migrate is not available.\u0027)"},{"line_number":226,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":227,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode\u0027"},{"line_number":228,"context_line":"                          \u0027tests.\u0027)"},{"line_number":229,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":230,"context_line":"    def test_server_connectivity_cold_migration_revert(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_e6c04c7f","line":227,"range":{"start_line":227,"start_character":63,"end_line":227,"end_character":72},"in_reply_to":"1a6eadb0_9061a5d6","updated":"2016-12-19 13:20:29.000000000","message":"Done","commit_id":"e6be9f46266d5a7076c4e35c175a47c2ac269e3f"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"064d4bee2e39af9c9568029bd42af0d4426728fc","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @test.idempotent_id(\u002725b188d7-0183-4b1e-a11d-15840c8e2fd6\u0027)"},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":225,"context_line":"                          \u0027Migrate is not available.\u0027)"},{"line_number":226,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":227,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode \u0027"},{"line_number":228,"context_line":"                          \u0027tests.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_916d10cf","line":225,"range":{"start_line":225,"start_character":27,"end_line":225,"end_character":52},"updated":"2016-12-19 13:38:30.000000000","message":"can you change to Cold migration is not available. like in L200?","commit_id":"e8818fa7e24581e7f0ff7aac35d1b2c1fb1d379a"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"45ab8d154200978efbdb4dc14ff1678d1e9445fb","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    @test.idempotent_id(\u002725b188d7-0183-4b1e-a11d-15840c8e2fd6\u0027)"},{"line_number":224,"context_line":"    @testtools.skipUnless(CONF.compute_feature_enabled.cold_migration,"},{"line_number":225,"context_line":"                          \u0027Migrate is not available.\u0027)"},{"line_number":226,"context_line":"    @testtools.skipUnless(CONF.compute.min_compute_nodes \u003e 1,"},{"line_number":227,"context_line":"                          \u0027Less than 2 compute nodes, skipping multinode \u0027"},{"line_number":228,"context_line":"                          \u0027tests.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a6eadb0_3100bcaa","line":225,"range":{"start_line":225,"start_character":27,"end_line":225,"end_character":52},"in_reply_to":"1a6eadb0_916d10cf","updated":"2016-12-19 13:43:12.000000000","message":"Done","commit_id":"e8818fa7e24581e7f0ff7aac35d1b2c1fb1d379a"}]}
