)]}'
{"tempest/common/cred_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f71ee7bff7d0b7c7f417c22d8bfd448fa731f96d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.projects_client \u003d projects_client"},{"line_number":40,"context_line":"        self.roles_client \u003d roles_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":43,"context_line":"        params \u003d self._create_user_params(username, password,"},{"line_number":44,"context_line":"                                          project[\u0027id\u0027], email)"},{"line_number":45,"context_line":"        user \u003d self.users_client.create_user(**params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_333fefd7","line":42,"range":{"start_line":42,"start_character":19,"end_line":42,"end_character":61},"updated":"2016-08-16 03:55:41.000000000","message":"how about taking domain_id here optionally and default it in _create_user_params to self.creds_domain[\u0027id\u0027] if not passed.","commit_id":"3ce52b9e95ee918970fd9c69d449158bd5c8113c"},{"author":{"_account_id":21999,"name":"Liu Qing","email":"liuqing@chinac.com","username":"liuqing"},"change_message_id":"9a781a44f358d5485cdd63ff5d3d8de4798ed99a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        self.projects_client \u003d projects_client"},{"line_number":40,"context_line":"        self.roles_client \u003d roles_client"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def create_user(self, username, password, project, email):"},{"line_number":43,"context_line":"        params \u003d self._create_user_params(username, password,"},{"line_number":44,"context_line":"                                          project[\u0027id\u0027], email)"},{"line_number":45,"context_line":"        user \u003d self.users_client.create_user(**params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_4fa27efe","line":42,"range":{"start_line":42,"start_character":19,"end_line":42,"end_character":61},"in_reply_to":"3ac371cc_333fefd7","updated":"2016-08-17 06:29:01.000000000","message":"Hi Ghanshyam\nKeystone V2 does not need domain_id parameter. This method is in the common class of V2 and V3. So it\u0027s not reasonable to add a parameter which only used in one of its child class.","commit_id":"3ce52b9e95ee918970fd9c69d449158bd5c8113c"}]}
