)]}'
{"tempest/api/volume/v2/test_volumes_list.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7f1346acb164567bca4a7fcf0b6579d8a8aba727","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # may have volumes other than those created upper."},{"line_number":55,"context_line":"        existing_volumes \u003d cls.client.list_volumes()[\u0027volumes\u0027]"},{"line_number":56,"context_line":"        cls.volume_list.extend(existing_volumes)"},{"line_number":57,"context_line":"        cls.volume_id_list.extend([vol[\u0027id\u0027] for vol in existing_volumes])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @classmethod"},{"line_number":60,"context_line":"    def resource_cleanup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac969e8_6f9381fb","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":74},"updated":"2016-08-12 22:48:00.000000000","message":"By adding existing volumes into volume_id_list, these volumes also are removed in resource_cleanup().\nThat seems painful for the existing environment, I think.","commit_id":"122897cadc50cf091721c08b980cfd21146cc5c6"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8cb05eac9b9fa15f0a950ab2086b92f99e2c8a5b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # Create 3 test volumes"},{"line_number":45,"context_line":"        cls.volume_id_list \u003d []"},{"line_number":46,"context_line":"        cls.metadata \u003d {\u0027Type\u0027: \u0027work\u0027}"},{"line_number":47,"context_line":"        # NOTE(zhufl): When using pre-provisioned credentials, the tenant"},{"line_number":48,"context_line":"        # may have volumes other than those created upper."},{"line_number":49,"context_line":"        existing_volumes \u003d cls.client.list_volumes()[\u0027volumes\u0027]"},{"line_number":50,"context_line":"        for i in range(3):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_60f7598b","line":47,"updated":"2016-08-17 20:57:14.000000000","message":"We should use the word \"project\" now.","commit_id":"21e5f85d155eb3b97249a2fa528d844476070f42"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8cb05eac9b9fa15f0a950ab2086b92f99e2c8a5b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        cls.volume_id_list \u003d []"},{"line_number":46,"context_line":"        cls.metadata \u003d {\u0027Type\u0027: \u0027work\u0027}"},{"line_number":47,"context_line":"        # NOTE(zhufl): When using pre-provisioned credentials, the tenant"},{"line_number":48,"context_line":"        # may have volumes other than those created upper."},{"line_number":49,"context_line":"        existing_volumes \u003d cls.client.list_volumes()[\u0027volumes\u0027]"},{"line_number":50,"context_line":"        for i in range(3):"},{"line_number":51,"context_line":"            volume \u003d cls.create_volume(metadata\u003dcls.metadata)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_e066a94f","line":48,"updated":"2016-08-17 20:57:14.000000000","message":"you meant \"other than those created below\" right ?","commit_id":"21e5f85d155eb3b97249a2fa528d844476070f42"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"8cb05eac9b9fa15f0a950ab2086b92f99e2c8a5b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        for i in range(3):"},{"line_number":51,"context_line":"            volume \u003d cls.create_volume(metadata\u003dcls.metadata)"},{"line_number":52,"context_line":"            cls.volume_id_list.append(volume[\u0027id\u0027])"},{"line_number":53,"context_line":"        cls.volume_id_list.extend([vol[\u0027id\u0027] for vol in existing_volumes])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @test.idempotent_id(\u00272a7064eb-b9c3-429b-b888-33928fc5edd3\u0027)"},{"line_number":56,"context_line":"    def test_volume_list_details_with_multiple_params(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_e07fc9dd","line":53,"updated":"2016-08-17 20:57:14.000000000","message":"Move this line closer to the code comment: move it just after line 49.","commit_id":"21e5f85d155eb3b97249a2fa528d844476070f42"}]}