)]}'
{"tempest/api/network/test_quotas.py":[{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"570ffb48870d38b9ae6f3deb9551421a8cca660f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    def setUpClass(cls):"},{"line_number":11,"context_line":"        super(QuotasTest, cls).setUpClass()"},{"line_number":12,"context_line":"        cls.manager \u003d manager.OfficialClientManager()"},{"line_number":13,"context_line":"        cls.tenant_id \u003d cls.manager._get_identity_client("},{"line_number":14,"context_line":"            cls.config.identity.username,"},{"line_number":15,"context_line":"            cls.config.identity.password,"},{"line_number":16,"context_line":"            cls.config.identity.tenant_name).tenant_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2FzdE%3D","line":13,"updated":"2013-07-11 06:15:13.000000000","message":"You should create a new tenant here or in every test case.\n(Since it is an API test, you should use the \u0027rest_client\u0027 based  tools.)","commit_id":"82f609ca610f8d604fad3c19090ae010ce5d51b4"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"570ffb48870d38b9ae6f3deb9551421a8cca660f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            self.assertEqual(list_quotas[0][\u0027tenant_id\u0027], self.tenant_id)"},{"line_number":74,"context_line":"            for quota in self.quotas_list:"},{"line_number":75,"context_line":"                self.assertEqual(list_quotas[0][quota], show_quotas[quota] + 2)"},{"line_number":76,"context_line":"        finally:"},{"line_number":77,"context_line":"            #Resetting values back to the original values"},{"line_number":78,"context_line":"            resp, body \u003d self.admin_client.reset_quotas(self.tenant_id)"},{"line_number":79,"context_line":"            self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fzcw%3D","line":76,"updated":"2013-07-11 06:15:13.000000000","message":"Please try to avoid this kind of finally usage.\n\nIf an exception happens both in the ``try`` block and in the ``finally`` block\nyou just get the exception from the ``finally`` , but in most cases you need the first exception for trouble shooting.","commit_id":"82f609ca610f8d604fad3c19090ae010ce5d51b4"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b6ba94f159f4d79e14f8f6adb5f1eefab0318796","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import testtools"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"from tempest.api.network import base"},{"line_number":4,"context_line":"from tempest import clients"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2F1ys%3D","line":1,"updated":"2013-07-22 10:58:29.000000000","message":"Need copyright and licence header","commit_id":"46315a345c66a2a89d18d1ed50566f0530f558e2"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"4df51e5b93b02eaee18632c36ed62d16caa47f18","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import testtools"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"from tempest.api.network import base"},{"line_number":4,"context_line":"from tempest import clients"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FyoQ%3D","line":1,"in_reply_to":"AAAAQn%2F%2F1ys%3D","updated":"2013-07-23 06:52:44.000000000","message":"Done","commit_id":"46315a345c66a2a89d18d1ed50566f0530f558e2"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"ba98b4a04a459be9b5591179f877a35045dd94de","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                         \"Value of  %s is None in the response\""},{"line_number":51,"context_line":"                         \" of show quotas\" % none_quotas)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @testtools.skip(\"Skipped until the Bug #1198165 is resolved\")"},{"line_number":54,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":55,"context_line":"    def test_update_list_reset_quotas(self):"},{"line_number":56,"context_line":"        test_tenant \u003d rand_name(\u0027test_tenant_\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2F60s%3D","line":53,"updated":"2013-07-19 06:18:55.000000000","message":"Looks like it is just spiked on a devstack bug.\nCan you fix it ? Do you need help ?","commit_id":"46315a345c66a2a89d18d1ed50566f0530f558e2"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5a7625f2da60d8cadbca69614a1aa9f5ba6a9e89","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                         \"Value of  %s is None in the response\""},{"line_number":68,"context_line":"                         \" of show quotas\" % none_quotas)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @testtools.skip(\"Skipped until the Bug #1198165 is resolved\")"},{"line_number":71,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":72,"context_line":"    def test_update_list_reset_quotas(self):"},{"line_number":73,"context_line":"        test_tenant \u003d rand_name(\u0027test_tenant_\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FwpE%3D","line":70,"updated":"2013-07-23 18:25:39.000000000","message":"we don\u0027t merge skipping tests","commit_id":"dd10b80f881591fc39889c7974763731dcf4a99f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5a7625f2da60d8cadbca69614a1aa9f5ba6a9e89","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            description\u003dtest_description)"},{"line_number":78,"context_line":"        tenant_id \u003d tenant[\u0027id\u0027]"},{"line_number":79,"context_line":"        self.addCleanup(self.identity_client.delete_tenant, tenant_id)"},{"line_number":80,"context_line":"        #List quotas when there are no defined quotas"},{"line_number":81,"context_line":"        resp, list_quotas \u003d self.admin_client.list_quotas()"},{"line_number":82,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":83,"context_line":"        self.assertEqual(0, len(list_quotas))"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2Fwos%3D","line":80,"updated":"2013-07-23 18:25:39.000000000","message":"in future, please make comments:\n\n# then words\n\nNot having the space after the \u0027#\u0027 makes them hard to parse.","commit_id":"dd10b80f881591fc39889c7974763731dcf4a99f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5a7625f2da60d8cadbca69614a1aa9f5ba6a9e89","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        for quota in self.quotas_list:"},{"line_number":104,"context_line":"            self.assertEqual(list_quotas[0][quota], show_quotas[quota] + 2)"},{"line_number":105,"context_line":"        #Resetting values back to the original values"},{"line_number":106,"context_line":"        resp, body \u003d self.admin_client.reset_quotas(tenant_id)"},{"line_number":107,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":108,"context_line":"        resp, quota_after_reset \u003d self.admin_client.show_quotas("},{"line_number":109,"context_line":"            tenant_id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2Fwow%3D","line":106,"updated":"2013-07-23 18:25:39.000000000","message":"the reset also needs to be as as an addCleanup in case we fail one of the asserts","commit_id":"dd10b80f881591fc39889c7974763731dcf4a99f"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"00de08d4be261ddf77de1b21d9023db36ab47e06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAQn%2F%2FNRA%3D","line":3,"updated":"2013-08-05 13:57:37.000000000","message":"Please fix the copyright date","commit_id":"339028c1bd41df1ce3a67ff39107add16f83f3e3"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"00de08d4be261ddf77de1b21d9023db36ab47e06","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.assertEqual(\u0027204\u0027, resp[\u0027status\u0027])"},{"line_number":43,"context_line":"        resp, quota_after_reset \u003d self.admin_client.show_quotas("},{"line_number":44,"context_line":"            tenant_id)"},{"line_number":45,"context_line":"        # Aseerting if the values got reset."},{"line_number":46,"context_line":"        for quota in self.quotas_list:"},{"line_number":47,"context_line":"            self.assertEqual(quota_after_reset[quota], quotas[quota])"},{"line_number":48,"context_line":"        self.assertEqual(quota_after_reset[\u0027network\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAQn%2F%2FNQw%3D","line":45,"updated":"2013-08-05 13:57:37.000000000","message":"very minor nit - \"Asserting\" and perhaps \"Asserting that the values got reset\"","commit_id":"339028c1bd41df1ce3a67ff39107add16f83f3e3"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"00de08d4be261ddf77de1b21d9023db36ab47e06","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                         \"Value of  %s is None in the response\""},{"line_number":85,"context_line":"                         \" of show quotas\" % none_quotas)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @testtools.skip(\"Skipped until the Bug #1198165 is resolved\")"},{"line_number":88,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":89,"context_line":"    def test_update_list_reset_quotas(self):"},{"line_number":90,"context_line":"        test_tenant \u003d rand_name(\u0027test_tenant_\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAQn%2F%2FNQE%3D","line":87,"updated":"2013-08-05 13:57:37.000000000","message":"I don\u0027t think we\u0027re merging skipped tests?","commit_id":"339028c1bd41df1ce3a67ff39107add16f83f3e3"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"de0d2537d1539b6e6b4648818de2df6cc636cafa","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                         \"Value of  %s is None in the response\""},{"line_number":85,"context_line":"                         \" of show quotas\" % none_quotas)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @testtools.skip(\"Skipped until the Bug #1198165 is resolved\")"},{"line_number":88,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":89,"context_line":"    def test_update_list_reset_quotas(self):"},{"line_number":90,"context_line":"        test_tenant \u003d rand_name(\u0027test_tenant_\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAQn%2F%2FMRo%3D","line":87,"in_reply_to":"AAAAQn%2F%2FNQE%3D","updated":"2013-08-05 17:53:42.000000000","message":"I think last time this was discussed we decided it was a judgement call. If a series of tests is submitted, and one happens to fail to a bug, IMO it should go in. Otherwise the submitter has to somehow know that the bug has been fixed and then submit new code. They will have lost their context, along with reviewers not having the context, and having missed any refactoring that might have occurred. If we allow it in, we have a tool that tells us which skipped tests refer to bugs that have been fixed. On balance I think it would cost less to let them in.","commit_id":"339028c1bd41df1ce3a67ff39107add16f83f3e3"}]}