)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"55509080a78574058a3defcdcd0543a7b2f30f07","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing baremetal tests from tempest tree"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ironic project now has a tempest plugin and its tests will be maintained there."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1614516"},{"line_number":12,"context_line":"Change-Id: Id518a6d87d0949737cd1c50cb6a83149b85e5f85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ac06dbe_c1c7ca43","line":10,"updated":"2016-08-19 20:07:27.000000000","message":"The ironic patch (https://review.openstack.org/#/c/355591/) is necessary to be merged before this patch, I think.\n\nSo here should contain\n\n Depends-on: Iad6e16c28cf2a35cc6bf040f57224d32c085b7bc","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removing baremetal tests from tempest tree"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ironic project now has a tempest plugin and its tests will be maintained there."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1614516"},{"line_number":12,"context_line":"Change-Id: Id518a6d87d0949737cd1c50cb6a83149b85e5f85"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1ac06dbe_d069518d","line":10,"in_reply_to":"1ac06dbe_c1c7ca43","updated":"2016-08-19 20:58:57.000000000","message":"Hi Ken\u0027ichi. In fact, I\u0027m working to remove this dependency.","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"}],"tempest/common/credentials_factory.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56a450c610ea586e689457aa9759669c5b3215c9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            project_network_cidr\u003dCONF.network.project_network_cidr,"},{"line_number":88,"context_line":"            project_network_mask_bits\u003dCONF.network.project_network_mask_bits,"},{"line_number":89,"context_line":"            public_network_id\u003dCONF.network.public_network_id,"},{"line_number":90,"context_line":"            create_networks\u003dCONF.auth.create_isolated_networks,"},{"line_number":91,"context_line":"            resource_prefix\u003dCONF.resources_prefix,"},{"line_number":92,"context_line":"            **get_dynamic_provider_params())"},{"line_number":93,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_2484ded2","line":90,"range":{"start_line":90,"start_character":28,"end_line":90,"end_character":62},"updated":"2016-11-15 23:57:47.000000000","message":"along with this flag check we should add new config flag check also.","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7934fec3ad30f2112a35aae77d33c6bc263c5b39","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            project_network_cidr\u003dCONF.network.project_network_cidr,"},{"line_number":88,"context_line":"            project_network_mask_bits\u003dCONF.network.project_network_mask_bits,"},{"line_number":89,"context_line":"            public_network_id\u003dCONF.network.public_network_id,"},{"line_number":90,"context_line":"            create_networks\u003dCONF.auth.create_isolated_networks,"},{"line_number":91,"context_line":"            resource_prefix\u003dCONF.resources_prefix,"},{"line_number":92,"context_line":"            **get_dynamic_provider_params())"},{"line_number":93,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_c92441c8","line":90,"range":{"start_line":90,"start_character":28,"end_line":90,"end_character":62},"in_reply_to":"7a77a97e_2484ded2","updated":"2016-11-21 21:28:26.000000000","message":"Done","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"}],"tempest/common/dynamic_creds.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            LOG.info(\"Acquired dynamic creds:\\n credentials: %s\""},{"line_number":292,"context_line":"                     % credentials)"},{"line_number":293,"context_line":"            if (CONF.service_available.neutron and"},{"line_number":294,"context_line":"                not CONF.compute_feature_enabled.baremetal_driver_enabled and"},{"line_number":295,"context_line":"                CONF.auth.create_isolated_networks):"},{"line_number":296,"context_line":"                network, subnet, router \u003d self._create_network_resources("},{"line_number":297,"context_line":"                    credentials.tenant_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_3eb526cd","line":294,"updated":"2016-08-19 15:40:03.000000000","message":"This could probably also be CONF.compute.fixed_network_required","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":291,"context_line":"            LOG.info(\"Acquired dynamic creds:\\n credentials: %s\""},{"line_number":292,"context_line":"                     % credentials)"},{"line_number":293,"context_line":"            if (CONF.service_available.neutron and"},{"line_number":294,"context_line":"                not CONF.compute_feature_enabled.baremetal_driver_enabled and"},{"line_number":295,"context_line":"                CONF.auth.create_isolated_networks):"},{"line_number":296,"context_line":"                network, subnet, router \u003d self._create_network_resources("},{"line_number":297,"context_line":"                    credentials.tenant_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_bc5bd153","line":294,"in_reply_to":"1ac06dbe_3eb526cd","updated":"2016-08-19 20:58:57.000000000","message":"I think that the configuration below holds that thought, wdyt?","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"}],"tempest/config.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e1235f3c4aaeabd2113da6333b7464c4ed6c51b6","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":1003,"context_line":"                default\u003dFalse,"},{"line_number":1004,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":1005,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":1006,"context_line":"                default\u003dFalse,"},{"line_number":1007,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":1008,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_cbe4b6e1","line":1005,"updated":"2016-08-29 20:24:53.000000000","message":"We probably should delete this flag too since nothing uses it anymore right?","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"b2bf3369ae562a489ec04f6d12555d492cbaf687","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":1003,"context_line":"                default\u003dFalse,"},{"line_number":1004,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":1005,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":1006,"context_line":"                default\u003dFalse,"},{"line_number":1007,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":1008,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_aea780bb","line":1005,"in_reply_to":"fa7ab95a_cbe4b6e1","updated":"2016-08-29 20:40:43.000000000","message":"Done","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20cd2ed6d5cfbf8165936306d7e063d02c72e6e5","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":967,"context_line":"                default\u003dFalse,"},{"line_number":968,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":969,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":970,"context_line":"                default\u003dFalse,"},{"line_number":971,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":972,"context_line":"]"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"debug_group \u003d cfg.OptGroup(name\u003d\"debug\","}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_58af2fe3","line":971,"range":{"start_line":969,"start_character":0,"end_line":971,"end_character":74},"updated":"2016-11-15 04:28:52.000000000","message":"this should also go on ironic side, like plugin can just set this to true but in case if any other plugin want to use Ironic service in their tests, otherwise just remove from here is fine.","commit_id":"67ca41e40f078e076a4c607f29d4f14f299cd5c1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8d323eda10dfa109a0bc16210773c45508bb8fe1","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":967,"context_line":"                default\u003dFalse,"},{"line_number":968,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":969,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":970,"context_line":"                default\u003dFalse,"},{"line_number":971,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":972,"context_line":"]"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"debug_group \u003d cfg.OptGroup(name\u003d\"debug\","}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_9af9a6cb","line":971,"range":{"start_line":969,"start_character":0,"end_line":971,"end_character":74},"in_reply_to":"7a77a97e_58af2fe3","updated":"2016-11-15 14:27:26.000000000","message":"So this is used by tempest/api/compute/admin/test_baremetal_nodes.py, which tests a nova API extension, not the ironic service. We can call it something else, but this is a config for nova tests, so I believe it belongs here.\n\nIt\u0027s also used in tempest/scenario/manager.py, where I agree it shouldn\u0027t be there, but it\u0027s a workaround for a bug in Nova so I\u0027d rather just leave it until that bug is fixed.","commit_id":"67ca41e40f078e076a4c607f29d4f14f299cd5c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b01c470a1042d36c7ef4d7140c4a7407b625d195","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":967,"context_line":"                default\u003dFalse,"},{"line_number":968,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":969,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":970,"context_line":"                default\u003dFalse,"},{"line_number":971,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":972,"context_line":"]"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"debug_group \u003d cfg.OptGroup(name\u003d\"debug\","}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_a41b8e1a","line":971,"range":{"start_line":969,"start_character":0,"end_line":971,"end_character":74},"in_reply_to":"7a77a97e_9af9a6cb","updated":"2016-11-15 23:57:58.000000000","message":"Yea, agree but service availability is something ironic tempest plugin should register and tell other tests module whether Ironic is available or not.\n\nTempest or an other module will use this flag same way as it is currently but registration should go on plugin side.\n\nSame use case, congress and ceilometer plugin has.","commit_id":"67ca41e40f078e076a4c607f29d4f14f299cd5c1"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"37ee03525ff97c087fea0bb430527d78a690db9a","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"]"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"baremetal_group \u003d cfg.OptGroup(name\u003d\u0027baremetal\u0027,"},{"line_number":1028,"context_line":"                               title\u003d\u0027Baremetal provisioning service options\u0027,"},{"line_number":1029,"context_line":"                               help\u003d\u0027When enabling baremetal tests, Nova \u0027"},{"line_number":1030,"context_line":"                                    \u0027must be configured to use the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_3c437214","side":"PARENT","line":1027,"updated":"2016-11-19 00:36:33.000000000","message":"According to http://codesearch.openstack.org/?q\u003dCONF.baremetal\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\nthe removal of this config will affect\n\n- openstack/vmware-nsx\n- openstack/networking-fo- rtinet\n- openstack/daisycloud-core\n- openstack/ironic-inspector\n- openstack/ironic\n\nWe need to take care of them so that these projects are using plugin correctly.","commit_id":"2e7d0f026ec81540deef5fe2e4ddf84f484aaa37"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7934fec3ad30f2112a35aae77d33c6bc263c5b39","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"]"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"baremetal_group \u003d cfg.OptGroup(name\u003d\u0027baremetal\u0027,"},{"line_number":1028,"context_line":"                               title\u003d\u0027Baremetal provisioning service options\u0027,"},{"line_number":1029,"context_line":"                               help\u003d\u0027When enabling baremetal tests, Nova \u0027"},{"line_number":1030,"context_line":"                                    \u0027must be configured to use the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_9456e004","side":"PARENT","line":1027,"in_reply_to":"7a77a97e_3c437214","updated":"2016-11-21 21:28:26.000000000","message":"Good point, I\u0027ll take care of ironic-inspector. Ironic is taken care of (the options moved there).\n\nThe others are not official projects, and I don\u0027t know anything about them, so I\u0027m not really interested in doing that work. If we want to block this patch until they\u0027re fixed, we\u0027ll need to find someone to do this work.","commit_id":"2e7d0f026ec81540deef5fe2e4ddf84f484aaa37"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21c67d1849766c688e14780dac6303d6035e12aa","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"]"},{"line_number":1025,"context_line":""},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"baremetal_group \u003d cfg.OptGroup(name\u003d\u0027baremetal\u0027,"},{"line_number":1028,"context_line":"                               title\u003d\u0027Baremetal provisioning service options\u0027,"},{"line_number":1029,"context_line":"                               help\u003d\u0027When enabling baremetal tests, Nova \u0027"},{"line_number":1030,"context_line":"                                    \u0027must be configured to use the Ironic \u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_a40ba72a","side":"PARENT","line":1027,"in_reply_to":"7a77a97e_9456e004","updated":"2016-11-22 00:10:33.000000000","message":"Fixed those. \n\n    Add \u0027driver_enabled\u0027 config options in ironic plugin - https://review.openstack.org/#/c/400032/\n    openstack/vmware-nsx - https://review.openstack.org/#/c/400037/\n    openstack/networking-fo- rtinet - https://review.openstack.org/#/c/400035/\n\nSo with patch(https://review.openstack.org/#/c/400032/) they are all good and does not block this patch.","commit_id":"2e7d0f026ec81540deef5fe2e4ddf84f484aaa37"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"37ee03525ff97c087fea0bb430527d78a690db9a","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                default\u003d[\"1.0.0.0/16\", \"2.0.0.0/16\"],"},{"line_number":558,"context_line":"                help\u003d\"List of ip pools\""},{"line_number":559,"context_line":"                     \" for subnetpools creation\"),"},{"line_number":560,"context_line":"    cfg.BoolOpt(\u0027shared_physical_network\u0027,"},{"line_number":561,"context_line":"                default\u003dFalse,"},{"line_number":562,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":563,"context_line":"                     \"between tenants.\"),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_d94c50a0","line":560,"range":{"start_line":560,"start_character":17,"end_line":560,"end_character":40},"updated":"2016-11-19 00:36:33.000000000","message":"Why do we need to add this new option?","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7934fec3ad30f2112a35aae77d33c6bc263c5b39","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                default\u003d[\"1.0.0.0/16\", \"2.0.0.0/16\"],"},{"line_number":558,"context_line":"                help\u003d\"List of ip pools\""},{"line_number":559,"context_line":"                     \" for subnetpools creation\"),"},{"line_number":560,"context_line":"    cfg.BoolOpt(\u0027shared_physical_network\u0027,"},{"line_number":561,"context_line":"                default\u003dFalse,"},{"line_number":562,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":563,"context_line":"                     \"between tenants.\"),"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_694ecd97","line":560,"range":{"start_line":560,"start_character":17,"end_line":560,"end_character":40},"in_reply_to":"7a77a97e_d94c50a0","updated":"2016-11-21 21:28:26.000000000","message":"Ironic supports deployment on shared physical networks, which means tests that create networks and test between them won\u0027t work. This is replacing some of the uses of CONF.baremetal.enabled or whatever, see previous patchsets for discussion.","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"21c67d1849766c688e14780dac6303d6035e12aa","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":971,"context_line":"                default\u003dFalse,"},{"line_number":972,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":973,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":974,"context_line":"                default\u003dFalse,"},{"line_number":975,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":976,"context_line":"]"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"debug_group \u003d cfg.OptGroup(name\u003d\"debug\","}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_372a6b7f","line":975,"range":{"start_line":973,"start_character":0,"end_line":975,"end_character":74},"updated":"2016-11-22 00:10:33.000000000","message":"This one I again claim should be on Ironic plugin side.","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"53e08b366bc1efd3e6fccb510608ddc6f25242d4","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":971,"context_line":"                default\u003dFalse,"},{"line_number":972,"context_line":"                help\u003d\"Whether or not Sahara is expected to be available\"),"},{"line_number":973,"context_line":"    cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":974,"context_line":"                default\u003dFalse,"},{"line_number":975,"context_line":"                help\u003d\"Whether or not Ironic is expected to be available\"),"},{"line_number":976,"context_line":"]"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"debug_group \u003d cfg.OptGroup(name\u003d\"debug\","}],"source_content_type":"text/x-python","patch_set":17,"id":"5a74a57a_a3757833","line":975,"range":{"start_line":973,"start_character":0,"end_line":975,"end_character":74},"in_reply_to":"7a77a97e_372a6b7f","updated":"2016-11-29 21:55:54.000000000","message":"Done","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"3801e8464701618ef24cae512064abb7d1bec084","unresolved":false,"context_lines":[{"line_number":565,"context_line":"                default\u003d[\"1.0.0.0/16\", \"2.0.0.0/16\"],"},{"line_number":566,"context_line":"                help\u003d\"List of ip pools\""},{"line_number":567,"context_line":"                     \" for subnetpools creation\"),"},{"line_number":568,"context_line":"    cfg.BoolOpt(\u0027shared_physical_network\u0027,"},{"line_number":569,"context_line":"                default\u003dFalse,"},{"line_number":570,"context_line":"                help\u003d\"The environment does not support network separation \""},{"line_number":571,"context_line":"                     \"between tenants.\"),"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a71b18c_16736de8","line":568,"updated":"2016-12-09 12:43:14.000000000","message":"currios why we need a new variable here, and can\u0027t reuse \u0027create_isolated_networks\u0027 here?\n\nhttps://github.com/openstack/tempest/blob/5b6ad769c18723506fb8238ba2d0ee57029122a0/tempest/config.py#L84","commit_id":"4ff30e02e5c68ea849a6adc92594121584fc7f46"}],"tempest/scenario/manager.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1210,"context_line":"        :returns: network, subnet, router"},{"line_number":1211,"context_line":"        \"\"\""},{"line_number":1212,"context_line":"        if CONF.compute_feature_enabled.baremetal_driver_enabled:"},{"line_number":1213,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1214,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1215,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_fe8c2e37","line":1212,"updated":"2016-08-19 15:40:03.000000000","message":"Perhaps this could be CONF.compute.fixed_network_required.","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":1209,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1210,"context_line":"        :returns: network, subnet, router"},{"line_number":1211,"context_line":"        \"\"\""},{"line_number":1212,"context_line":"        if CONF.compute_feature_enabled.baremetal_driver_enabled:"},{"line_number":1213,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1214,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1215,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_50cf21b0","line":1212,"in_reply_to":"1ac06dbe_fe8c2e37","updated":"2016-08-19 20:58:57.000000000","message":"Also could be CONF.auth.create_isolated_networks ?","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"b2bf3369ae562a489ec04f6d12555d492cbaf687","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1151,"context_line":"        :returns: network, subnet, router"},{"line_number":1152,"context_line":"        \"\"\""},{"line_number":1153,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1154,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1155,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1156,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_2e6c5034","line":1153,"range":{"start_line":1153,"start_character":8,"end_line":1153,"end_character":49},"updated":"2016-08-29 20:40:43.000000000","message":"Wdyt of removing this if too? Maybe it\u0027s out of the scope for this patch...","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b8bbd8512cf743eff26cfacd757c9ac7dd0ef7d7","unresolved":false,"context_lines":[{"line_number":1150,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1151,"context_line":"        :returns: network, subnet, router"},{"line_number":1152,"context_line":"        \"\"\""},{"line_number":1153,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1154,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1155,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1156,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_2998cabf","line":1153,"range":{"start_line":1153,"start_character":8,"end_line":1153,"end_character":49},"in_reply_to":"fa7ab95a_2e6c5034","updated":"2016-08-29 20:49:11.000000000","message":"Yeah I missed this before, but my other comment is also for this","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c934c5a11d1359974232a35837757a19613e01a5","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1183,"context_line":"        :returns: network, subnet, router"},{"line_number":1184,"context_line":"        \"\"\""},{"line_number":1185,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1186,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1187,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1188,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_d9d5221c","line":1185,"updated":"2016-11-11 20:34:07.000000000","message":"This needs to go away as well.","commit_id":"388b8b064ab527686ef3ac9879a5e4ad0f960e98"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"20cd2ed6d5cfbf8165936306d7e063d02c72e6e5","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1183,"context_line":"        :returns: network, subnet, router"},{"line_number":1184,"context_line":"        \"\"\""},{"line_number":1185,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1186,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1187,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1188,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_d8b5ffd0","line":1185,"range":{"start_line":1185,"start_character":11,"end_line":1185,"end_character":49},"updated":"2016-11-15 04:28:52.000000000","message":"As mentioned by Matt, I also feel we should add new flag for this till stable/branch is in scope where ironic still need shared physical network.","commit_id":"67ca41e40f078e076a4c607f29d4f14f299cd5c1"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"8d323eda10dfa109a0bc16210773c45508bb8fe1","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"        :param dns_nameservers: list of dns servers to send to subnet."},{"line_number":1183,"context_line":"        :returns: network, subnet, router"},{"line_number":1184,"context_line":"        \"\"\""},{"line_number":1185,"context_line":"        if not CONF.auth.create_isolated_networks:"},{"line_number":1186,"context_line":"            # NOTE(Shrews): This exception is for environments where tenant"},{"line_number":1187,"context_line":"            # credential isolation is available, but network separation is"},{"line_number":1188,"context_line":"            # not (the current baremetal case). Likely can be removed when"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a77a97e_ba3ca230","line":1185,"range":{"start_line":1185,"start_character":11,"end_line":1185,"end_character":49},"in_reply_to":"7a77a97e_d8b5ffd0","updated":"2016-11-15 14:27:26.000000000","message":"A shared physical network will be supported for a long time, FWIW.\n\nHappy to make a new flag for it, though, what do you think about CONF.network.shared_physical_network?","commit_id":"67ca41e40f078e076a4c607f29d4f14f299cd5c1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"15908ee985b6ea9eba1d74389bb04d540effefbc","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        # servers. Neutron does not bind ports for Ironic instances, as a"},{"line_number":811,"context_line":"        # result the port remains in the DOWN state."},{"line_number":812,"context_line":"        # TODO(vsaienko) remove once bug: #1599836 is resolved."},{"line_number":813,"context_line":"        if CONF.service_available.ironic:"},{"line_number":814,"context_line":"            p_status.append(\u0027DOWN\u0027)"},{"line_number":815,"context_line":"        port_map \u003d [(p[\"id\"], fxip[\"ip_address\"])"},{"line_number":816,"context_line":"                    for p in ports"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_d74db7c5","line":813,"range":{"start_line":813,"start_character":11,"end_line":813,"end_character":40},"updated":"2016-11-22 02:21:33.000000000","message":"On moving \u0027ironic flag to ironic plugin then we can check like - (to avoid config error) \n\nif getattr(CONF.service_available, \u0027ironic\u0027, False):","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                   \"floating ip\")"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @test.idempotent_id(\u00271546850e-fbaa-42f5-8b5f-03d8a6a95f15\u0027)"},{"line_number":412,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":413,"context_line":"                      \u0027Baremetal relies on a shared physical network.\u0027)"},{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_5e83c2cc","line":412,"updated":"2016-08-19 15:40:03.000000000","message":"Probably CONF.network.multitenant_network\u003dFalse","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                   \"floating ip\")"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @test.idempotent_id(\u00271546850e-fbaa-42f5-8b5f-03d8a6a95f15\u0027)"},{"line_number":412,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":413,"context_line":"                      \u0027Baremetal relies on a shared physical network.\u0027)"},{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_a183aecb","line":412,"in_reply_to":"1ac06dbe_5e83c2cc","updated":"2016-08-19 20:58:57.000000000","message":"ditto","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        self._check_network_internal_connectivity(network\u003dself.new_net)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    @test.idempotent_id(\u002704b9fe4e-85e8-4aea-b937-ea93885ac59f\u0027)"},{"line_number":488,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":489,"context_line":"                      \u0027Router state cannot be altered on a shared baremetal \u0027"},{"line_number":490,"context_line":"                      \u0027network\u0027)"},{"line_number":491,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_1e602a35","line":488,"updated":"2016-08-19 15:40:03.000000000","message":"CONF.network.allow_update_router?","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":485,"context_line":"        self._check_network_internal_connectivity(network\u003dself.new_net)"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    @test.idempotent_id(\u002704b9fe4e-85e8-4aea-b937-ea93885ac59f\u0027)"},{"line_number":488,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":489,"context_line":"                      \u0027Router state cannot be altered on a shared baremetal \u0027"},{"line_number":490,"context_line":"                      \u0027network\u0027)"},{"line_number":491,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_017562f8","line":488,"in_reply_to":"1ac06dbe_1e602a35","updated":"2016-08-19 20:58:57.000000000","message":"ditto","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            \"admin_state_up of router to True\")"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    @test.idempotent_id(\u0027d8bb918e-e2df-48b2-97cd-b73c95450980\u0027)"},{"line_number":520,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":521,"context_line":"                      \u0027network isolation not available for baremetal nodes\u0027)"},{"line_number":522,"context_line":"    @testtools.skipUnless(CONF.scenario.dhcp_client,"},{"line_number":523,"context_line":"                          \"DHCP client is not available.\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_9edb7aed","line":520,"updated":"2016-08-19 15:40:03.000000000","message":"CONF.network.multitenant_networking","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":517,"context_line":"            \"admin_state_up of router to True\")"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    @test.idempotent_id(\u0027d8bb918e-e2df-48b2-97cd-b73c95450980\u0027)"},{"line_number":520,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":521,"context_line":"                      \u0027network isolation not available for baremetal nodes\u0027)"},{"line_number":522,"context_line":"    @testtools.skipUnless(CONF.scenario.dhcp_client,"},{"line_number":523,"context_line":"                          \"DHCP client is not available.\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_8d41890e","line":520,"in_reply_to":"1ac06dbe_9edb7aed","updated":"2016-08-19 20:58:57.000000000","message":"Didn\u0027t found this option on tempest\u0027s config.py, but found an option \u0027create_isolated_networks\u0027 under \u0027auth\u0027 group. WDYT?","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                            \"new DNS nameservers\")"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @test.idempotent_id(\u0027f5dfcc22-45fd-409f-954c-5bd500d7890b\u0027)"},{"line_number":603,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":604,"context_line":"                      \u0027admin_state of instance ports cannot be altered \u0027"},{"line_number":605,"context_line":"                      \u0027for baremetal nodes\u0027)"},{"line_number":606,"context_line":"    @testtools.skipUnless(CONF.network_feature_enabled.port_admin_state_change,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_7eff9e34","line":603,"updated":"2016-08-19 15:40:03.000000000","message":"Can probably just remove this and we can just use the config below it.","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":600,"context_line":"                            \"new DNS nameservers\")"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    @test.idempotent_id(\u0027f5dfcc22-45fd-409f-954c-5bd500d7890b\u0027)"},{"line_number":603,"context_line":"    @testtools.skipIf(CONF.compute_feature_enabled.baremetal_driver_enabled,"},{"line_number":604,"context_line":"                      \u0027admin_state of instance ports cannot be altered \u0027"},{"line_number":605,"context_line":"                      \u0027for baremetal nodes\u0027)"},{"line_number":606,"context_line":"    @testtools.skipUnless(CONF.network_feature_enabled.port_admin_state_change,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_8d09892f","line":603,"in_reply_to":"1ac06dbe_7eff9e34","updated":"2016-08-19 20:58:57.000000000","message":"Done","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"e1235f3c4aaeabd2113da6333b7464c4ed6c51b6","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                   \"floating ip\")"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @test.idempotent_id(\u00271546850e-fbaa-42f5-8b5f-03d8a6a95f15\u0027)"},{"line_number":412,"context_line":"    @testtools.skipUnless(CONF.auth.create_isolated_networks,"},{"line_number":413,"context_line":"                          \u0027Connectivity can only be tested when in a \u0027"},{"line_number":414,"context_line":"                          \u0027multitenant network environment\u0027)"},{"line_number":415,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_cb96763d","line":412,"updated":"2016-08-29 20:24:53.000000000","message":"This flag doesn\u0027t mean what I think you\u0027re thinking it does. This is used to tell tempest that it needs to create network resources by default when running with dynamic credentials. This doesn\u0027t mean there is a shared physical network (which is what the old skip message said)\n\nIt\u0027s not a generic configuration flag, like if preprovisioned credentials are used this means nothing. It also probably isn\u0027t a skip on ironic jobs in the gate because we run all the voting jobs with dynamic credentials","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"b2bf3369ae562a489ec04f6d12555d492cbaf687","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                   \"floating ip\")"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @test.idempotent_id(\u00271546850e-fbaa-42f5-8b5f-03d8a6a95f15\u0027)"},{"line_number":412,"context_line":"    @testtools.skipUnless(CONF.auth.create_isolated_networks,"},{"line_number":413,"context_line":"                          \u0027Connectivity can only be tested when in a \u0027"},{"line_number":414,"context_line":"                          \u0027multitenant network environment\u0027)"},{"line_number":415,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_eedfc837","line":412,"in_reply_to":"fa7ab95a_cb96763d","updated":"2016-08-29 20:40:43.000000000","message":"Ironic recently implemented network isolation, so the requirement for shared physical network doesn\u0027t exist anymore. Maybe it\u0027s fine to remove this check then?","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b8bbd8512cf743eff26cfacd757c9ac7dd0ef7d7","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                                                   \"floating ip\")"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    @test.idempotent_id(\u00271546850e-fbaa-42f5-8b5f-03d8a6a95f15\u0027)"},{"line_number":412,"context_line":"    @testtools.skipUnless(CONF.auth.create_isolated_networks,"},{"line_number":413,"context_line":"                          \u0027Connectivity can only be tested when in a \u0027"},{"line_number":414,"context_line":"                          \u0027multitenant network environment\u0027)"},{"line_number":415,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_09e066f9","line":412,"in_reply_to":"fa7ab95a_eedfc837","updated":"2016-08-29 20:49:11.000000000","message":"So the only potential issue with that is these tests are also run on stable branches, so we need to cover that use case too. It also seems like we have a gap here if you can still configure neutron to use a shared physical network, even if it\u0027s not a requirement for ironic anymore. However, if that\u0027s not actually true (I\u0027ve never actually used a deployment like that) then we can just add a flag and add a comment to remove it at the Mitaka EOL.","commit_id":"93e653d5351a21ccb947dfc82b46056af852c450"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c934c5a11d1359974232a35837757a19613e01a5","unresolved":false,"context_lines":[{"line_number":421,"context_line":"            should_connect\u003dTrue, mtu\u003dself.network[\u0027mtu\u0027])"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    @test.idempotent_id(\u00271546850e-fbaa-42f5-8b5f-03d8a6a95f15\u0027)"},{"line_number":424,"context_line":"    @testtools.skipUnless(CONF.auth.create_isolated_networks,"},{"line_number":425,"context_line":"                          \u0027Connectivity can only be tested when in a \u0027"},{"line_number":426,"context_line":"                          \u0027multitenant network environment\u0027)"},{"line_number":427,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_791ed60c","line":424,"updated":"2016-11-11 20:34:07.000000000","message":"This is still wrong, need to come up with something better here.","commit_id":"388b8b064ab527686ef3ac9879a5e4ad0f960e98"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56a450c610ea586e689457aa9759669c5b3215c9","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                        msg\u003d\"DHCP renewal failed to fetch \""},{"line_number":613,"context_line":"                            \"new DNS nameservers\")"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    @test.idempotent_id(\u0027f5dfcc22-45fd-409f-954c-5bd500d7890b\u0027)"},{"line_number":616,"context_line":"    @testtools.skipUnless(CONF.network_feature_enabled.port_admin_state_change,"},{"line_number":617,"context_line":"                          \"Changing a port\u0027s admin state is not supported \""},{"line_number":618,"context_line":"                          \"by the test environment\")"},{"line_number":619,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_update_instance_port_admin_state(self):"},{"line_number":621,"context_line":"        \"\"\"Test to update admin_state_up attribute of instance port"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        1. Check public connectivity before updating"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_04644247","line":620,"range":{"start_line":615,"start_character":0,"end_line":620,"end_character":51},"updated":"2016-11-15 23:57:47.000000000","message":"new flag not needed here?","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"85ea9f3c321dd3c9dcb5239bca8180537d3677ad","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                        msg\u003d\"DHCP renewal failed to fetch \""},{"line_number":613,"context_line":"                            \"new DNS nameservers\")"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"    @test.idempotent_id(\u0027f5dfcc22-45fd-409f-954c-5bd500d7890b\u0027)"},{"line_number":616,"context_line":"    @testtools.skipUnless(CONF.network_feature_enabled.port_admin_state_change,"},{"line_number":617,"context_line":"                          \"Changing a port\u0027s admin state is not supported \""},{"line_number":618,"context_line":"                          \"by the test environment\")"},{"line_number":619,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":620,"context_line":"    def test_update_instance_port_admin_state(self):"},{"line_number":621,"context_line":"        \"\"\"Test to update admin_state_up attribute of instance port"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"        1. Check public connectivity before updating"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_a97d10b3","line":620,"range":{"start_line":615,"start_character":0,"end_line":620,"end_character":51},"in_reply_to":"7a77a97e_04644247","updated":"2016-11-16 12:12:56.000000000","message":"Hmm, we could add it, but ironic CI also sets CONF.network_feature_enabled.port_admin_state_change\u003dFalse","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"}],"tempest/scenario/test_network_v6.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            msg \u003d (\u0027Either project_networks_reachable must be \"true\", or \u0027"},{"line_number":52,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":"        if CONF.compute_feature_enabled.baremetal_driver_enabled:"},{"line_number":55,"context_line":"            msg \u003d (\u0027IPv6 is not currently supported by baremetal due to lack \u0027"},{"line_number":56,"context_line":"                   \u0027of support by PXE.\u0027)"},{"line_number":57,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_bef91650","line":54,"updated":"2016-08-19 15:40:03.000000000","message":"CONF.network.ipv6_enabled or something?","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            msg \u003d (\u0027Either project_networks_reachable must be \"true\", or \u0027"},{"line_number":52,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":53,"context_line":"            raise cls.skipException(msg)"},{"line_number":54,"context_line":"        if CONF.compute_feature_enabled.baremetal_driver_enabled:"},{"line_number":55,"context_line":"            msg \u003d (\u0027IPv6 is not currently supported by baremetal due to lack \u0027"},{"line_number":56,"context_line":"                   \u0027of support by PXE.\u0027)"},{"line_number":57,"context_line":"            raise cls.skipException(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_9c6d3507","line":54,"in_reply_to":"1ac06dbe_bef91650","updated":"2016-08-19 20:58:57.000000000","message":"It\u0027s @46","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56a450c610ea586e689457aa9759669c5b3215c9","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                or CONF.network.public_network_id):"},{"line_number":50,"context_line":"            msg \u003d (\u0027Either project_networks_reachable must be \"true\", or \u0027"},{"line_number":51,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":52,"context_line":"            raise cls.skipException(msg)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_84505260","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":40},"updated":"2016-11-15 23:57:47.000000000","message":"this too?","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7934fec3ad30f2112a35aae77d33c6bc263c5b39","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                or CONF.network.public_network_id):"},{"line_number":50,"context_line":"            msg \u003d (\u0027Either project_networks_reachable must be \"true\", or \u0027"},{"line_number":51,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":52,"context_line":"            raise cls.skipException(msg)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_34e42c3a","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":40},"in_reply_to":"7a77a97e_495f1c41","updated":"2016-11-21 21:28:26.000000000","message":"Done","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"85ea9f3c321dd3c9dcb5239bca8180537d3677ad","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                or CONF.network.public_network_id):"},{"line_number":50,"context_line":"            msg \u003d (\u0027Either project_networks_reachable must be \"true\", or \u0027"},{"line_number":51,"context_line":"                   \u0027public_network_id must be defined.\u0027)"},{"line_number":52,"context_line":"            raise cls.skipException(msg)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @classmethod"},{"line_number":55,"context_line":"    def setup_credentials(cls):"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_495f1c41","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":40},"in_reply_to":"7a77a97e_84505260","updated":"2016-11-16 12:12:56.000000000","message":"+1","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"}],"tempest/scenario/test_security_groups_basic_ops.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ac6e9dddfd600aecc757e31640946780f782a6ca","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    @classmethod"},{"line_number":130,"context_line":"    def skip_checks(cls):"},{"line_number":131,"context_line":"        super(TestSecurityGroupsBasicOps, cls).skip_checks()"},{"line_number":132,"context_line":"        if CONF.compute_feature_enabled.baremetal_driver_enabled:"},{"line_number":133,"context_line":"            msg \u003d (\u0027Not currently supported by baremetal.\u0027)"},{"line_number":134,"context_line":"            raise cls.skipException(msg)"},{"line_number":135,"context_line":"        if CONF.network.port_vnic_type in [\u0027direct\u0027, \u0027macvtap\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_de9332f9","line":132,"updated":"2016-08-19 15:40:03.000000000","message":"CONF.network.enable_security_groups? Or maybe we just disable the security-group extension in our tests, if possible?","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":10697,"name":"Thiago Paiva Brito","email":"thiagop@lsd.ufcg.edu.br","username":"thiagop","inactive":true},"change_message_id":"13f78528c7a0732f7ec777b4f89858de72d7174f","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    @classmethod"},{"line_number":130,"context_line":"    def skip_checks(cls):"},{"line_number":131,"context_line":"        super(TestSecurityGroupsBasicOps, cls).skip_checks()"},{"line_number":132,"context_line":"        if CONF.compute_feature_enabled.baremetal_driver_enabled:"},{"line_number":133,"context_line":"            msg \u003d (\u0027Not currently supported by baremetal.\u0027)"},{"line_number":134,"context_line":"            raise cls.skipException(msg)"},{"line_number":135,"context_line":"        if CONF.network.port_vnic_type in [\u0027direct\u0027, \u0027macvtap\u0027]:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ac06dbe_3cc1a1e5","line":132,"in_reply_to":"1ac06dbe_de9332f9","updated":"2016-08-19 20:58:57.000000000","message":"Done","commit_id":"580ba21b10f044965219e01223e13368f497c5a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"56a450c610ea586e689457aa9759669c5b3215c9","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def skip_checks(cls):"},{"line_number":133,"context_line":"        super(TestSecurityGroupsBasicOps, cls).skip_checks()"},{"line_number":134,"context_line":"        if CONF.network.port_vnic_type in [\u0027direct\u0027, \u0027macvtap\u0027]:"},{"line_number":135,"context_line":"            msg \u003d (\u0027Not currently supported when using vnic_type\u0027"},{"line_number":136,"context_line":"                   \u0027 direct or macvtap\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_a44f0ebc","line":133,"range":{"start_line":133,"start_character":58,"end_line":133,"end_character":60},"updated":"2016-11-15 23:57:47.000000000","message":"and this? or they were not correct one to skip for baremetal.","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"7934fec3ad30f2112a35aae77d33c6bc263c5b39","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def skip_checks(cls):"},{"line_number":133,"context_line":"        super(TestSecurityGroupsBasicOps, cls).skip_checks()"},{"line_number":134,"context_line":"        if CONF.network.port_vnic_type in [\u0027direct\u0027, \u0027macvtap\u0027]:"},{"line_number":135,"context_line":"            msg \u003d (\u0027Not currently supported when using vnic_type\u0027"},{"line_number":136,"context_line":"                   \u0027 direct or macvtap\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_54cfe8b2","line":133,"range":{"start_line":133,"start_character":58,"end_line":133,"end_character":60},"in_reply_to":"7a77a97e_8959345d","updated":"2016-11-21 21:28:26.000000000","message":"Done","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"85ea9f3c321dd3c9dcb5239bca8180537d3677ad","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    @classmethod"},{"line_number":132,"context_line":"    def skip_checks(cls):"},{"line_number":133,"context_line":"        super(TestSecurityGroupsBasicOps, cls).skip_checks()"},{"line_number":134,"context_line":"        if CONF.network.port_vnic_type in [\u0027direct\u0027, \u0027macvtap\u0027]:"},{"line_number":135,"context_line":"            msg \u003d (\u0027Not currently supported when using vnic_type\u0027"},{"line_number":136,"context_line":"                   \u0027 direct or macvtap\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"7a77a97e_8959345d","line":133,"range":{"start_line":133,"start_character":58,"end_line":133,"end_character":60},"in_reply_to":"7a77a97e_a44f0ebc","updated":"2016-11-16 12:12:56.000000000","message":"Yep, +1.","commit_id":"09231ea30225ec14fca5f989c544b16203060b11"}]}