)]}'
{"tempest/services/volume/base/admin/base_types_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a7719ac489520493515399cddfc9c2174b59f884","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @property"},{"line_number":34,"context_line":"    def resource_type(self):"},{"line_number":35,"context_line":"        \"\"\"Returns the primary type of resource this client works with.\"\"\""},{"line_number":36,"context_line":"        return \u0027volume-type/encryption-type\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list_volume_types(self, **params):"},{"line_number":39,"context_line":"        \"\"\"List all the volume_types created."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_6570d40b","line":36,"updated":"2016-08-24 08:43:14.000000000","message":"so, can we also remove this \u0027/encryption-type\u0027?","commit_id":"794f957e2704fb74bb09a08fcfb4360cd9064f27"}],"tempest/services/volume/v1/json/encryption_types_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eea6f298c9c0c228c98dc7dfbf71a8e3789819b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa7ab95a_26a19746","updated":"2016-08-30 16:45:19.000000000","message":"This seems admin only API, so this should be under admin directory.","commit_id":"d53b8b7933f831c416309de6d83aaec168e4619a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"06b155d43bb949c7d6de6a3787eedef7c4582605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa7ab95a_a8148d9f","in_reply_to":"fa7ab95a_26a19746","updated":"2016-08-30 19:01:36.000000000","message":"This is a client, not api test.\nSo I don\u0027t think the clients should be under admin directory.\n\nActually, the other volume clients which call admin APIs under admin directory, but the directory is meaningless because of service client consistency. When migrating clients to tempest.lib, we are removing admin path.","commit_id":"d53b8b7933f831c416309de6d83aaec168e4619a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ea461b375e2f99b9f6e603d9de7f3a9c817ff0b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class EncryptionTypesClient(rest_client.RestClient):"},{"line_number":23,"context_line":"    api_version \u003d \"v2\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":26,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_4cd583b7","line":23,"range":{"start_line":23,"start_character":3,"end_line":23,"end_character":22},"updated":"2016-09-06 00:46:01.000000000","message":"this is v1 client. i think you want to add this in v2 client.","commit_id":"2594c406261409953668c0f4dcdc1b8fa77d299f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca115830ae1068f8776ee59cc43a75c345c42816","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class EncryptionTypesClient(rest_client.RestClient):"},{"line_number":23,"context_line":"    api_version \u003d \"v2\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":26,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_bdd9a485","line":23,"range":{"start_line":23,"start_character":3,"end_line":23,"end_character":22},"in_reply_to":"9a89bdaa_4cd583b7","updated":"2016-09-06 19:54:48.000000000","message":"Oops, nice catch!","commit_id":"2594c406261409953668c0f4dcdc1b8fa77d299f"}],"tempest/services/volume/v2/json/encryption_types_client.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eea6f298c9c0c228c98dc7dfbf71a8e3789819b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fa7ab95a_66ae3f2f","updated":"2016-08-30 16:45:19.000000000","message":"ditto.","commit_id":"d53b8b7933f831c416309de6d83aaec168e4619a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eea6f298c9c0c228c98dc7dfbf71a8e3789819b2","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class EncryptionTypesClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":25,"context_line":"        try:"},{"line_number":26,"context_line":"            body \u003d self.show_encryption_type(id)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_66f63f90","line":23,"updated":"2016-08-30 16:45:19.000000000","message":"version should be defined for v2 client\napi_version \u003d \"v2\"","commit_id":"d53b8b7933f831c416309de6d83aaec168e4619a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ea461b375e2f99b9f6e603d9de7f3a9c817ff0b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class EncryptionTypesClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":25,"context_line":"        try:"},{"line_number":26,"context_line":"            body \u003d self.show_encryption_type(id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_bfdbb81a","line":23,"updated":"2016-09-06 00:46:01.000000000","message":"version should be defined for v2 client\napi_version \u003d \"v2\"","commit_id":"2594c406261409953668c0f4dcdc1b8fa77d299f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ca115830ae1068f8776ee59cc43a75c345c42816","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class EncryptionTypesClient(rest_client.RestClient):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def is_resource_deleted(self, id):"},{"line_number":25,"context_line":"        try:"},{"line_number":26,"context_line":"            body \u003d self.show_encryption_type(id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_9dc5c08f","line":23,"in_reply_to":"9a89bdaa_bfdbb81a","updated":"2016-09-06 19:54:48.000000000","message":"Yeah, completely you are right.","commit_id":"2594c406261409953668c0f4dcdc1b8fa77d299f"}]}