)]}'
{"tempest/api/volume/base.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"71bf5933b6e4a3f427b37b7b3baaea28e5b2ca46","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        return body"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"class BaseVolumeAdminTest(BaseVolumeTest):"},{"line_number":187,"context_line":"    \"\"\"Base test case class for all Volume Admin API tests.\"\"\""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_44d2b7d3","line":186,"updated":"2016-08-26 20:27:42.000000000","message":"here","commit_id":"915700ae2b6413924e181f48d9bbd11b02704233"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b35a33ac24c190ac83ed508914f2fb46eb1a04e1","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                cls.admin_volume_types_client.wait_for_resource_deletion,"},{"line_number":270,"context_line":"                resource)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @classmethod"},{"line_number":273,"context_line":"    def wait_for_qos_operations(cls, qos_id, operation, args\u003dNone):"},{"line_number":274,"context_line":"        \"\"\"Waits for a qos operations to be completed."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_30bb5fc6","line":272,"updated":"2016-08-26 08:53:32.000000000","message":"Why is this a class method ?","commit_id":"915700ae2b6413924e181f48d9bbd11b02704233"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"71bf5933b6e4a3f427b37b7b3baaea28e5b2ca46","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                cls.admin_volume_types_client.wait_for_resource_deletion,"},{"line_number":270,"context_line":"                resource)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    @classmethod"},{"line_number":273,"context_line":"    def wait_for_qos_operations(cls, qos_id, operation, args\u003dNone):"},{"line_number":274,"context_line":"        \"\"\"Waits for a qos operations to be completed."},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_a422a3ff","line":272,"in_reply_to":"fa7ab95a_30bb5fc6","updated":"2016-08-26 20:27:42.000000000","message":"because all other methods in this class are class methods.\nbut actually these methods are not used as class methods without class instances. So it is fine to drop this if you mind current implementation.","commit_id":"915700ae2b6413924e181f48d9bbd11b02704233"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"b35a33ac24c190ac83ed508914f2fb46eb1a04e1","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        args \u003d None when operation \u003d \u0027disassociate-all\u0027"},{"line_number":281,"context_line":"        \"\"\""},{"line_number":282,"context_line":"        start_time \u003d int(time.time())"},{"line_number":283,"context_line":"        client \u003d cls.admin_volume_qos_client"},{"line_number":284,"context_line":"        while True:"},{"line_number":285,"context_line":"            if operation \u003d\u003d \u0027qos-key-unset\u0027:"},{"line_number":286,"context_line":"                body \u003d client.show_qos(qos_id)[\u0027qos_specs\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b0a04f92","line":283,"updated":"2016-08-26 08:53:32.000000000","message":"What if we are not in an \"admin\" test ?  Maybe move this method in BaseVolumeAdminTest ?","commit_id":"915700ae2b6413924e181f48d9bbd11b02704233"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"71bf5933b6e4a3f427b37b7b3baaea28e5b2ca46","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        args \u003d None when operation \u003d \u0027disassociate-all\u0027"},{"line_number":281,"context_line":"        \"\"\""},{"line_number":282,"context_line":"        start_time \u003d int(time.time())"},{"line_number":283,"context_line":"        client \u003d cls.admin_volume_qos_client"},{"line_number":284,"context_line":"        while True:"},{"line_number":285,"context_line":"            if operation \u003d\u003d \u0027qos-key-unset\u0027:"},{"line_number":286,"context_line":"                body \u003d client.show_qos(qos_id)[\u0027qos_specs\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_c44fa7bb","line":283,"in_reply_to":"fa7ab95a_b0a04f92","updated":"2016-08-26 20:27:42.000000000","message":"This method exists in BaseVolumeAdminTest already..","commit_id":"915700ae2b6413924e181f48d9bbd11b02704233"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"f9a4dd2dd382061d1c89aa9f9b248e08ae218d4b","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                cls.admin_volume_types_client.wait_for_resource_deletion,"},{"line_number":270,"context_line":"                resource)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def wait_for_qos_operations(cls, qos_id, operation, args\u003dNone):"},{"line_number":273,"context_line":"        \"\"\"Waits for a qos operations to be completed."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        NOTE : operation value is required for  wait_for_qos_operations()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_9a5ea843","line":272,"updated":"2016-09-01 15:47:00.000000000","message":"Please use \u0027self\u0027 instead of cls. This is a bit misleading.","commit_id":"44a59746d164f53433ff50a071169333a2debc6e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f1ef128e21a1076df892c56953b67d28f0d4187f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                cls.admin_volume_types_client.wait_for_resource_deletion,"},{"line_number":270,"context_line":"                resource)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def wait_for_qos_operations(cls, qos_id, operation, args\u003dNone):"},{"line_number":273,"context_line":"        \"\"\"Waits for a qos operations to be completed."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        NOTE : operation value is required for  wait_for_qos_operations()"}],"source_content_type":"text/x-python","patch_set":4,"id":"da7fb54a_b02b0633","line":272,"in_reply_to":"fa7ab95a_9a5ea843","updated":"2016-09-02 16:35:27.000000000","message":"oops, nice catch. Thanks for pointing it out!","commit_id":"44a59746d164f53433ff50a071169333a2debc6e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbdbbdb176e57637cf7ab9ac4d871dee649ece1f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                cls.admin_volume_types_client.wait_for_resource_deletion,"},{"line_number":270,"context_line":"                resource)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def wait_for_qos_operations(self, qos_id, operation, args\u003dNone):"},{"line_number":273,"context_line":"        \"\"\"Waits for a qos operations to be completed."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"        NOTE : operation value is required for  wait_for_qos_operations()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_2364cd47","line":272,"range":{"start_line":272,"start_character":8,"end_line":272,"end_character":31},"updated":"2016-09-06 02:55:34.000000000","message":"we can move this to waiter but seems like not so global usage of this as of now.","commit_id":"046a7496e8f63d02942dcdabe7cd18e5964dc340"}]}