)]}'
{"tempest/services/volume/v2/json/admin/types_client.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"f88b3eab40238cc53b8c544f9fcaafefe77ca4a2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TypesClient(rest_client.RestClient):"},{"line_number":24,"context_line":"    \"\"\"Client class to send CRUD Volume V2 API requests\"\"\""},{"line_number":25,"context_line":"    api_version \u003d \"v2\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_d9769ea2","line":23,"updated":"2016-09-01 08:20:46.000000000","message":"woo, a lot of copy\u0026paste code.. Can we extends v1 TypesClient class here? I think v1 Types","commit_id":"5990e57c577c3cd112e04778baf3dc16e736d685"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ad3ef333305b2d3c40bd420271169a0d93f0c2d3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from tempest.lib import exceptions as lib_exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TypesClient(rest_client.RestClient):"},{"line_number":24,"context_line":"    \"\"\"Client class to send CRUD Volume V2 API requests\"\"\""},{"line_number":25,"context_line":"    api_version \u003d \"v2\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_87a1e448","line":23,"in_reply_to":"fa7ab95a_d9769ea2","updated":"2016-09-01 18:25:06.000000000","message":"Humm, that is different from this patch purpose.\nWhen digging the gate problem, current deep inheritance makes deep backtrace and investigators need to check layers which contains this class. That is hard to do that now.\n\nIn addition, this class/method is stable now. I don\u0027t think this copy\u0026paste code becomes hard to be maintained in long-term.","commit_id":"5990e57c577c3cd112e04778baf3dc16e736d685"}]}