)]}'
{"tempest/api/volume/admin/test_volume_quotas_negative.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"05af44cb8e108aa7bc49662e123e0a77eaba836b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"},{"line_number":34,"context_line":"        super(BaseVolumeQuotasNegativeV2TestJSON, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.default_volume_size \u003d CONF.volume.volume_size"},{"line_number":36,"context_line":"        cls.shared_quota_set \u003d {\u0027gigabytes\u0027: 2 * cls.default_volume_size,"},{"line_number":37,"context_line":"                                \u0027volumes\u0027: 1}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_fd46f579","line":35,"updated":"2016-09-01 05:50:50.000000000","message":"Can we remove this line because it seems cls.default_volume_size is not used anywhere.","commit_id":"61f47fb44cd05a7d560471b5e6ea0bc1c200b020"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"800b9c9f2415b042b3129ff07f9ee22aa3183078","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"},{"line_number":34,"context_line":"        super(BaseVolumeQuotasNegativeV2TestJSON, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.default_volume_size \u003d CONF.volume.volume_size"},{"line_number":36,"context_line":"        cls.shared_quota_set \u003d {\u0027gigabytes\u0027: 2 * cls.default_volume_size,"},{"line_number":37,"context_line":"                                \u0027volumes\u0027: 1}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_67d68ff2","line":35,"in_reply_to":"fa7ab95a_b93b70d0","updated":"2016-09-02 03:15:59.000000000","message":"ah, I wanted to say that :)","commit_id":"61f47fb44cd05a7d560471b5e6ea0bc1c200b020"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"698d179b0dad8f12635ae71d22d68d2ab47d5471","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def resource_setup(cls):"},{"line_number":34,"context_line":"        super(BaseVolumeQuotasNegativeV2TestJSON, cls).resource_setup()"},{"line_number":35,"context_line":"        cls.default_volume_size \u003d CONF.volume.volume_size"},{"line_number":36,"context_line":"        cls.shared_quota_set \u003d {\u0027gigabytes\u0027: 2 * cls.default_volume_size,"},{"line_number":37,"context_line":"                                \u0027volumes\u0027: 1}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_b93b70d0","line":35,"in_reply_to":"fa7ab95a_fd46f579","updated":"2016-09-01 18:33:13.000000000","message":"This default_value_size is used at line 36 and line 65.\nHowever, it is fine to remove this and use CONF value directly.","commit_id":"61f47fb44cd05a7d560471b5e6ea0bc1c200b020"}],"tempest/api/volume/base.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"05af44cb8e108aa7bc49662e123e0a77eaba836b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def create_volume(cls, **kwargs):"},{"line_number":112,"context_line":"        \"\"\"Wrapper utility that returns a test volume.\"\"\""},{"line_number":113,"context_line":"        if \u0027size\u0027 not in kwargs:"},{"line_number":114,"context_line":"            kwargs[\u0027size\u0027] \u003d CONF.volume.volume_size"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        name \u003d data_utils.rand_name(cls.__name__ + \u0027-Volume\u0027)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_dd43f16a","line":114,"updated":"2016-09-01 05:50:50.000000000","message":"I feel this sets a default value from the config. So do you just want to move(not remove) this code from volume_client? Do I misunderstand something?","commit_id":"61f47fb44cd05a7d560471b5e6ea0bc1c200b020"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"698d179b0dad8f12635ae71d22d68d2ab47d5471","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    def create_volume(cls, **kwargs):"},{"line_number":112,"context_line":"        \"\"\"Wrapper utility that returns a test volume.\"\"\""},{"line_number":113,"context_line":"        if \u0027size\u0027 not in kwargs:"},{"line_number":114,"context_line":"            kwargs[\u0027size\u0027] \u003d CONF.volume.volume_size"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        name \u003d data_utils.rand_name(cls.__name__ + \u0027-Volume\u0027)"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_997eac68","line":114,"in_reply_to":"fa7ab95a_dd43f16a","updated":"2016-09-01 18:33:13.000000000","message":"Yes, I just want to remove the default value from volumes_client because that should be consistent between all clients and this default value is different from the other clients.","commit_id":"61f47fb44cd05a7d560471b5e6ea0bc1c200b020"}]}