)]}'
{"releasenotes/notes/add-new-identity-clients-as-library-3e6559d4bff3e776.yaml":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"d2b3cdd05b2f9558ec2d3404309bfda054ac5785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa7ab95a_904d3dc6","updated":"2016-08-30 16:30:59.000000000","message":"Should this also include the v3 clients that we\u0027ve added to library interface?","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fcd9c84683b03022b06a063a4f252f2db906ad4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa7ab95a_73733fe8","in_reply_to":"fa7ab95a_904d3dc6","updated":"2016-08-31 07:17:05.000000000","message":"Due to reno, I wanted to add a new release note in order not to alter history, so depending on when the new tag is released I\u0027d keep them here or not.","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"99792c90ce95ac46fbe00db5fc243e467bcaff39","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Add new service clients to the library interface so the other projects can use these modules as stable libraries without"},{"line_number":6,"context_line":"    any maintenance changes."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      * endpoints_client(v2)"},{"line_number":9,"context_line":"      * roles_client(v2)"},{"line_number":10,"context_line":"      * services_client(v2)"},{"line_number":11,"context_line":"      * tenants_client(v2)"},{"line_number":12,"context_line":"      * users_client(v2)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_aedf350b","line":12,"range":{"start_line":8,"start_character":8,"end_line":12,"end_character":24},"updated":"2016-08-30 19:32:44.000000000","message":"This patch just defines regions_client, so the other clients should be removed from this list.","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fcd9c84683b03022b06a063a4f252f2db906ad4c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Add new service clients to the library interface so the other projects can use these modules as stable libraries without"},{"line_number":6,"context_line":"    any maintenance changes."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      * endpoints_client(v2)"},{"line_number":9,"context_line":"      * roles_client(v2)"},{"line_number":10,"context_line":"      * services_client(v2)"},{"line_number":11,"context_line":"      * tenants_client(v2)"},{"line_number":12,"context_line":"      * users_client(v2)"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_b37dc7b3","line":12,"range":{"start_line":8,"start_character":8,"end_line":12,"end_character":24},"in_reply_to":"fa7ab95a_aedf350b","updated":"2016-08-31 07:17:05.000000000","message":"Toally, my fault when pushing for review as I was using an old one as a base. I\u0027ll change that and put a new patchset","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"}],"tempest/tests/lib/services/identity/v3/test_regions_client.py":[{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"d2b3cdd05b2f9558ec2d3404309bfda054ac5785","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.check_service_client_function("},{"line_number":66,"context_line":"            self.client.create_region,"},{"line_number":67,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.post\u0027,"},{"line_number":68,"context_line":"            self.FAKE_CREATE_REGION,"},{"line_number":69,"context_line":"            bytes_body,"},{"line_number":70,"context_line":"            status\u003d201)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e39a4113","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":36},"updated":"2016-08-30 16:30:59.000000000","message":"According to the Region API, we can also create a region without specifying an ID, description, or parent_region_id as they\u0027re all optional. Should we also try this creation path?","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"9227fd951d5edb97deb4ffdb2b119d5f8611c01a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.check_service_client_function("},{"line_number":66,"context_line":"            self.client.create_region,"},{"line_number":67,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.post\u0027,"},{"line_number":68,"context_line":"            self.FAKE_CREATE_REGION,"},{"line_number":69,"context_line":"            bytes_body,"},{"line_number":70,"context_line":"            status\u003d201)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_93d9a086","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":36},"in_reply_to":"fa7ab95a_e39a4113","updated":"2016-08-31 08:06:35.000000000","message":"Hi Dustin, after checking, I think I\u0027d stay for now with the examples on the identity api. i.e. http://developer.openstack.org/api-ref/identity/v3/?expanded\u003dcreate-region-detail,list-regions-detail but we can always add more unit tests after this patch lands.","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fcd9c84683b03022b06a063a4f252f2db906ad4c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self.check_service_client_function("},{"line_number":66,"context_line":"            self.client.create_region,"},{"line_number":67,"context_line":"            \u0027tempest.lib.common.rest_client.RestClient.post\u0027,"},{"line_number":68,"context_line":"            self.FAKE_CREATE_REGION,"},{"line_number":69,"context_line":"            bytes_body,"},{"line_number":70,"context_line":"            status\u003d201)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f31bcf7e","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":36},"in_reply_to":"fa7ab95a_e39a4113","updated":"2016-08-31 07:17:05.000000000","message":"will check","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"d2b3cdd05b2f9558ec2d3404309bfda054ac5785","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_list_regions_with_str_body(self):"},{"line_number":108,"context_line":"        self._test_list_regions()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_regions_with_bytes_body(self):"},{"line_number":111,"context_line":"        self._test_list_regions(bytes_body\u003dTrue)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_update_region_with_srt_body(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_832ed5a2","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":41},"updated":"2016-08-30 16:30:59.000000000","message":"We can also list regions with an optional filter on the parent_region_id field. Should we also test this path?","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"9227fd951d5edb97deb4ffdb2b119d5f8611c01a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_list_regions_with_str_body(self):"},{"line_number":108,"context_line":"        self._test_list_regions()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_regions_with_bytes_body(self):"},{"line_number":111,"context_line":"        self._test_list_regions(bytes_body\u003dTrue)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_update_region_with_srt_body(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_33c9b4ad","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":41},"in_reply_to":"fa7ab95a_832ed5a2","updated":"2016-08-31 08:06:35.000000000","message":"ditto","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fcd9c84683b03022b06a063a4f252f2db906ad4c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_list_regions_with_str_body(self):"},{"line_number":108,"context_line":"        self._test_list_regions()"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_regions_with_bytes_body(self):"},{"line_number":111,"context_line":"        self._test_list_regions(bytes_body\u003dTrue)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_update_region_with_srt_body(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_1311135e","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":41},"in_reply_to":"fa7ab95a_832ed5a2","updated":"2016-08-31 07:17:05.000000000","message":"will check.","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"d2b3cdd05b2f9558ec2d3404309bfda054ac5785","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_list_regions_with_bytes_body(self):"},{"line_number":111,"context_line":"        self._test_list_regions(bytes_body\u003dTrue)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_update_region_with_srt_body(self):"},{"line_number":114,"context_line":"        self._test_update_region()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_update_region_with_bytes_body(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e3c161e5","line":113,"range":{"start_line":113,"start_character":32,"end_line":113,"end_character":35},"updated":"2016-08-30 16:30:59.000000000","message":"s/srt/str","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fcd9c84683b03022b06a063a4f252f2db906ad4c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def test_list_regions_with_bytes_body(self):"},{"line_number":111,"context_line":"        self._test_list_regions(bytes_body\u003dTrue)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_update_region_with_srt_body(self):"},{"line_number":114,"context_line":"        self._test_update_region()"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def test_update_region_with_bytes_body(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_33161756","line":113,"range":{"start_line":113,"start_character":32,"end_line":113,"end_character":35},"in_reply_to":"fa7ab95a_e3c161e5","updated":"2016-08-31 07:17:05.000000000","message":"Good catch!","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"d2b3cdd05b2f9558ec2d3404309bfda054ac5785","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa7ab95a_50b3b597","line":126,"updated":"2016-08-30 16:30:59.000000000","message":"Should we also include some negative unit tests here as well?","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"},{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"fcd9c84683b03022b06a063a4f252f2db906ad4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa7ab95a_932e03a4","line":126,"in_reply_to":"fa7ab95a_50b3b597","updated":"2016-08-31 07:17:05.000000000","message":"I wouldn\u0027t put up negative tests here, as they have their own place within tempest.","commit_id":"115ec1136a23b04023875dde334a3ff9c6c3a889"}]}