)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"59dadaa67c9f12f0cd4c37a27455c265118edc27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding an option to create internal network-type Flat"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib81b2f6f78334a941760e4998765e6aae6d978e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ba5201f7_7a1e4960","line":9,"updated":"2017-01-04 20:26:21.000000000","message":"The commit message should say why we need to add this option with some actual problem.\n\nCurrent commit message is difficult to understand what this patch is trying to fix.","commit_id":"90458bdf87c291ba79c8877a639f983152747ede"}],"tempest/config.py":[{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"edd677d7ebf94b5f9a573b6accafa5e7446c2bf0","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                     \" for subnet creation\"),"},{"line_number":532,"context_line":"    cfg.StrOpt(\u0027port_vnic_type\u0027,"},{"line_number":533,"context_line":"               choices\u003d[None, \u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027,"},{"line_number":534,"context_line":"                        \u0027direct-physical\u0027],"},{"line_number":535,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":536,"context_line":"                    \" with pre-configured ports.\""},{"line_number":537,"context_line":"                    \" Supported ports are:\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0ecca1b9","line":534,"range":{"start_line":534,"start_character":25,"end_line":534,"end_character":31},"updated":"2016-08-30 19:32:12.000000000","message":"I could not see use of this option anywhere else in your patch. Generally it is advised, add things when it is required.","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"fbe07dd6740384c7c845f8e3eeb655f7993c0b9d","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                     \" for subnet creation\"),"},{"line_number":532,"context_line":"    cfg.StrOpt(\u0027port_vnic_type\u0027,"},{"line_number":533,"context_line":"               choices\u003d[None, \u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027,"},{"line_number":534,"context_line":"                        \u0027direct-physical\u0027],"},{"line_number":535,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":536,"context_line":"                    \" with pre-configured ports.\""},{"line_number":537,"context_line":"                    \" Supported ports are:\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_d3296bf4","line":534,"range":{"start_line":534,"start_character":25,"end_line":534,"end_character":31},"in_reply_to":"fa7ab95a_0ecca1b9","updated":"2016-08-31 07:23:38.000000000","message":"It is option that we can use in tempest.conf","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"485d33ebd61d36885f86b0c3077ea22dce886330","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                     \" for subnet creation\"),"},{"line_number":532,"context_line":"    cfg.StrOpt(\u0027port_vnic_type\u0027,"},{"line_number":533,"context_line":"               choices\u003d[None, \u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027,"},{"line_number":534,"context_line":"                        \u0027direct-physical\u0027],"},{"line_number":535,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":536,"context_line":"                    \" with pre-configured ports.\""},{"line_number":537,"context_line":"                    \" Supported ports are:\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_30436a6e","line":534,"range":{"start_line":534,"start_character":25,"end_line":534,"end_character":31},"in_reply_to":"fa7ab95a_d3296bf4","updated":"2016-08-31 08:01:55.000000000","message":"This value is being used, btw, by SR-IOV tests (for example, used by the Mellanox gate). So although it isn\u0027t used directly in this patch it will go a long way to add future tests.","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"edd677d7ebf94b5f9a573b6accafa5e7446c2bf0","unresolved":false,"context_lines":[{"line_number":543,"context_line":"    cfg.StrOpt(\u0027provider_network_type\u0027,"},{"line_number":544,"context_line":"               choices\u003d[None, \u0027vlan\u0027, \u0027flat\u0027, \u0027vxlan\u0027, \u0027gre\u0027],"},{"line_number":545,"context_line":"               default\u003dNone,"},{"line_number":546,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \""},{"line_number":547,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":548,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":549,"context_line":"               default\u003d\u0027physnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0e282132","line":546,"range":{"start_line":546,"start_character":37,"end_line":546,"end_character":45},"updated":"2016-08-30 19:32:12.000000000","message":"If \u0027provider_network_type\u0027 can be used to make multiple networks in one go ?\nIf not, it should be changed to \u0027network\u0027","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"fbe07dd6740384c7c845f8e3eeb655f7993c0b9d","unresolved":false,"context_lines":[{"line_number":543,"context_line":"    cfg.StrOpt(\u0027provider_network_type\u0027,"},{"line_number":544,"context_line":"               choices\u003d[None, \u0027vlan\u0027, \u0027flat\u0027, \u0027vxlan\u0027, \u0027gre\u0027],"},{"line_number":545,"context_line":"               default\u003dNone,"},{"line_number":546,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \""},{"line_number":547,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":548,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":549,"context_line":"               default\u003d\u0027physnet\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_93760305","line":546,"range":{"start_line":546,"start_character":37,"end_line":546,"end_character":45},"in_reply_to":"fa7ab95a_0e282132","updated":"2016-08-31 07:23:38.000000000","message":"provider_network_type can be used to create multiple networks","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"edd677d7ebf94b5f9a573b6accafa5e7446c2bf0","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":548,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":549,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":550,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \")"},{"line_number":551,"context_line":"]"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_4e7a2925","line":550,"range":{"start_line":550,"start_character":21,"end_line":550,"end_character":77},"updated":"2016-08-30 19:32:12.000000000","message":"If I am correct this message should be revised.","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"fbe07dd6740384c7c845f8e3eeb655f7993c0b9d","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":548,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":549,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":550,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \")"},{"line_number":551,"context_line":"]"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_b3e1479d","line":550,"range":{"start_line":550,"start_character":21,"end_line":550,"end_character":77},"in_reply_to":"fa7ab95a_4e7a2925","updated":"2016-08-31 07:23:38.000000000","message":"You are correct I will change it","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":21302,"name":"Gena","email":"gcheresh@redhat.com","username":"gcheresh"},"change_message_id":"3f6b83b0787e22a9279795193aa59ae754558848","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":548,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":549,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":550,"context_line":"               help\u003d\"Create provider physical with a specific network type. \")"},{"line_number":551,"context_line":"]"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_ca19a57b","line":550,"updated":"2016-08-31 09:26:19.000000000","message":"remove trailing space","commit_id":"a7aa8658621a4740a6ab9243fe7fe32013498b24"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"563fc1fc7b05a6a1f02271d3a6f8f2c0838f9e5e","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":548,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":549,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":550,"context_line":"               help\u003d\"Create provider physical with a specific network type. \")"},{"line_number":551,"context_line":"]"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_cb752433","line":550,"in_reply_to":"fa7ab95a_ca19a57b","updated":"2016-08-31 10:38:03.000000000","message":"Done","commit_id":"a7aa8658621a4740a6ab9243fe7fe32013498b24"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"6d971f17af66ebb0a7e667b9e1602cae426c05c2","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                     \" for subnet creation\"),"},{"line_number":532,"context_line":"    cfg.StrOpt(\u0027port_vnic_type\u0027,"},{"line_number":533,"context_line":"               choices\u003d[None, \u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027,"},{"line_number":534,"context_line":"                        \u0027direct-physical\u0027],"},{"line_number":535,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":536,"context_line":"                    \" with pre-configured ports.\""},{"line_number":537,"context_line":"                    \" Supported ports are:\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_a4ebaaaf","line":534,"range":{"start_line":534,"start_character":25,"end_line":534,"end_character":40},"updated":"2016-08-31 12:07:47.000000000","message":"Don\u0027t we also need \u0027direct\u0027 here for VFs?","commit_id":"09eaeaa03736beddf660b4fb57e758e5fe61ec89"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"79fcd7399ceac0f5ef729761378db288c50efcf5","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                     \" for subnet creation\"),"},{"line_number":532,"context_line":"    cfg.StrOpt(\u0027port_vnic_type\u0027,"},{"line_number":533,"context_line":"               choices\u003d[None, \u0027normal\u0027, \u0027direct\u0027, \u0027macvtap\u0027,"},{"line_number":534,"context_line":"                        \u0027direct-physical\u0027],"},{"line_number":535,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":536,"context_line":"                    \" with pre-configured ports.\""},{"line_number":537,"context_line":"                    \" Supported ports are:\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_049376fb","line":534,"range":{"start_line":534,"start_character":25,"end_line":534,"end_character":40},"in_reply_to":"fa7ab95a_a4ebaaaf","updated":"2016-08-31 12:11:21.000000000","message":"If it would look like I had a brain fart, that\u0027s because you\u0027re right. Oops :)","commit_id":"09eaeaa03736beddf660b4fb57e758e5fe61ec89"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"01b0732c89cf92419241d84191442190a92feb49","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                     \"in L3 agent scheduler test. Extra resources need to be \""},{"line_number":602,"context_line":"                     \"provisioned in order to bind router to L3 agent in the \""},{"line_number":603,"context_line":"                     \"Liberty release or older, and are not required since \""},{"line_number":604,"context_line":"                     \"the Mitaka release.\")"},{"line_number":605,"context_line":"    cfg.StrOpt(\u0027provider_network_type\u0027,"},{"line_number":606,"context_line":"               choices\u003d[None, \u0027vlan\u0027, \u0027flat\u0027, \u0027vxlan\u0027, \u0027gre\u0027],"},{"line_number":607,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_1904b6be","line":604,"range":{"start_line":604,"start_character":42,"end_line":604,"end_character":43},"updated":"2017-01-03 08:01:27.000000000","message":"add a comma (,) at the end of this line to fix the gate issues.","commit_id":"54f790a394242d9e162eb003b20941d80f971881"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"59dadaa67c9f12f0cd4c37a27455c265118edc27","unresolved":false,"context_lines":[{"line_number":584,"context_line":"               help\u003d\"vnic_type to use when Launching instances\""},{"line_number":585,"context_line":"                    \" with pre-configured ports.\""},{"line_number":586,"context_line":"                    \" Supported ports are:\""},{"line_number":587,"context_line":"                    \" [\u0027normal\u0027,\u0027direct\u0027,\u0027macvtap\u0027]\"),"},{"line_number":588,"context_line":"    cfg.ListOpt(\u0027default_network\u0027,"},{"line_number":589,"context_line":"                default\u003d[\"1.0.0.0/16\", \"2.0.0.0/16\"],"},{"line_number":590,"context_line":"                help\u003d\"List of ip pools\""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_6fe5adda","line":587,"range":{"start_line":587,"start_character":22,"end_line":587,"end_character":51},"updated":"2017-01-04 20:26:21.000000000","message":"We need to update here by adding direct-physical.","commit_id":"90458bdf87c291ba79c8877a639f983152747ede"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"59dadaa67c9f12f0cd4c37a27455c265118edc27","unresolved":false,"context_lines":[{"line_number":606,"context_line":"               choices\u003d[None, \u0027vlan\u0027, \u0027flat\u0027, \u0027vxlan\u0027, \u0027gre\u0027],"},{"line_number":607,"context_line":"               default\u003dNone,"},{"line_number":608,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \""},{"line_number":609,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":610,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":611,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":612,"context_line":"               help\u003d\"Create provider physical with a specific network type.\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_6f104d5a","line":609,"updated":"2017-01-04 20:26:21.000000000","message":"I feel it is nice to describe \"provider:network_type\" directly here to understand the relationship with Neutron.","commit_id":"90458bdf87c291ba79c8877a639f983152747ede"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"59dadaa67c9f12f0cd4c37a27455c265118edc27","unresolved":false,"context_lines":[{"line_number":608,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \""},{"line_number":609,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":610,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":611,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":612,"context_line":"               help\u003d\"Create provider physical with a specific network type.\")"},{"line_number":613,"context_line":"]"},{"line_number":614,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_cf0bf928","line":611,"range":{"start_line":611,"start_character":24,"end_line":611,"end_character":31},"updated":"2017-01-04 20:26:21.000000000","message":"I am not sure why this value is the default.","commit_id":"90458bdf87c291ba79c8877a639f983152747ede"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"59dadaa67c9f12f0cd4c37a27455c265118edc27","unresolved":false,"context_lines":[{"line_number":609,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":610,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":611,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":612,"context_line":"               help\u003d\"Create provider physical with a specific network type.\")"},{"line_number":613,"context_line":"]"},{"line_number":614,"context_line":""},{"line_number":615,"context_line":"network_feature_group \u003d cfg.OptGroup(name\u003d\u0027network-feature-enabled\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_6f812dc3","line":612,"range":{"start_line":612,"start_character":37,"end_line":612,"end_character":46},"updated":"2017-01-04 20:26:21.000000000","message":"s/physical/physical network/\n\nand ditto to describe \"provider:physical_network\"","commit_id":"90458bdf87c291ba79c8877a639f983152747ede"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"02065504d7a81d4ffc6d711b40ba8cba5c24404f","unresolved":false,"context_lines":[{"line_number":607,"context_line":"               default\u003dNone,"},{"line_number":608,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \""},{"line_number":609,"context_line":"                    \"This is used to connect subnets over multiple nodes. \""},{"line_number":610,"context_line":"                     \"For SR-IOV, use flat.\"),"},{"line_number":611,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":612,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":613,"context_line":"               help\u003d\"Which phyiscal network the provider network (using \""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_484d2ac3","line":610,"range":{"start_line":610,"start_character":20,"end_line":610,"end_character":21},"updated":"2017-01-05 11:20:10.000000000","message":"Remove one space here to fix pep8","commit_id":"e776f14954401de25cafc89e3e5d0bd13a4dc119"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"39266b77e9be0a8527330ec3e7b69a141e8f9a84","unresolved":false,"context_lines":[{"line_number":607,"context_line":"               default\u003dNone,"},{"line_number":608,"context_line":"               help\u003d\"Create provider networks with a specific network_type. \""},{"line_number":609,"context_line":"                    \"This is used to connect subnets over multiple nodes. \""},{"line_number":610,"context_line":"                    \"For SR-IOV, use flat.\"),"},{"line_number":611,"context_line":"    cfg.StrOpt(\u0027provider_physical_network\u0027,"},{"line_number":612,"context_line":"               default\u003d\u0027physnet\u0027,"},{"line_number":613,"context_line":"               help\u003d\"Which phyiscal network the provider network (using \""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_f40a2c89","line":610,"updated":"2017-01-30 12:10:34.000000000","message":"I have doubts about you really need to use flat in all SR-IOV case, for ex. most NIC is able to vlan tag the VF traffic, several other might use other fooVTEP things as well.","commit_id":"f75562cc6ae53ffdd302bf47bed80b225a929e08"}],"tempest/scenario/manager.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"ddbaccf23b5f3033f5a1e99b070a01fad84a3078","unresolved":false,"context_lines":[{"line_number":703,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":704,"context_line":"        if CONF.network_feature_enabled.port_security:"},{"line_number":705,"context_line":"            network_kwargs[\u0027port_security_enabled\u0027] \u003d port_security_enabled"},{"line_number":706,"context_line":"        result \u003d networks_client.create_network(**network_kwargs)"},{"line_number":707,"context_line":"        if CONF.network.provider_network_type is not None:"},{"line_number":708,"context_line":"            result \u003d self.admin_manager.networks_client.create_network("},{"line_number":709,"context_line":"                name\u003dname, tenant_id\u003dtenant_id,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_5abd1e67","line":706,"range":{"start_line":706,"start_character":8,"end_line":706,"end_character":65},"updated":"2017-01-04 10:42:32.000000000","message":"This means that, in addition to lines 715-716, you\u0027re creating a new network and never delete it.\n\nThis line should be removed.","commit_id":"c11c7a415afb5947ed46e746a75093a05b570268"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"10873f41c8a158149ea1ad47e58b7f0344b5c63e","unresolved":false,"context_lines":[{"line_number":703,"context_line":"        # config before trying to create the network with port_security_enabled"},{"line_number":704,"context_line":"        if CONF.network_feature_enabled.port_security:"},{"line_number":705,"context_line":"            network_kwargs[\u0027port_security_enabled\u0027] \u003d port_security_enabled"},{"line_number":706,"context_line":"        result \u003d networks_client.create_network(**network_kwargs)"},{"line_number":707,"context_line":"        network \u003d result[\u0027network\u0027]"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        self.assertEqual(network[\u0027name\u0027], name)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_f9041dc1","side":"PARENT","line":706,"range":{"start_line":706,"start_character":47,"end_line":706,"end_character":65},"updated":"2017-01-04 12:22:44.000000000","message":"The network_kwargs (that, among others, also hold the \u0027port_security_enabled\u0027 key) is ignored in your new implementation...","commit_id":"108ace85d38210d214e0413c76106324f82a809a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"59dadaa67c9f12f0cd4c37a27455c265118edc27","unresolved":false,"context_lines":[{"line_number":713,"context_line":"                CONF.network.provider_network_type,"},{"line_number":714,"context_line":"                \u0027provider:physical_network\u0027:"},{"line_number":715,"context_line":"                CONF.network.provider_physical_network})"},{"line_number":716,"context_line":"            if networks_client is None:"},{"line_number":717,"context_line":"                client \u003d self.admin_manager.networks_client"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"        result \u003d client.create_network(**network_kwargs)"},{"line_number":720,"context_line":"        network \u003d result[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba5201f7_6f392df2","line":717,"range":{"start_line":716,"start_character":0,"end_line":717,"end_character":59},"updated":"2017-01-04 20:26:21.000000000","message":"I cannot understand why here should set client again even but line 694-697 sets it already.","commit_id":"90458bdf87c291ba79c8877a639f983152747ede"}],"tempest/scenario/test_network_basic_ops.py":[{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"edd677d7ebf94b5f9a573b6accafa5e7446c2bf0","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        \"\"\""},{"line_number":398,"context_line":"        self._setup_network_and_servers(network_type\u003d\u0027flat\u0027)"},{"line_number":399,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":400,"context_line":"        self._check_network_internal_connectivity(network\u003dself.network)"},{"line_number":401,"context_line":"        self._check_network_external_connectivity()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_bd285187","line":398,"range":{"start_line":398,"start_character":40,"end_line":398,"end_character":59},"updated":"2016-08-30 19:32:12.000000000","message":"It will be better, if you specify it in a commented line i.e. -\n# Creating a basic \u0027flat\u0027 network and server","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"fbe07dd6740384c7c845f8e3eeb655f7993c0b9d","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        \"\"\""},{"line_number":398,"context_line":"        self._setup_network_and_servers(network_type\u003d\u0027flat\u0027)"},{"line_number":399,"context_line":"        self.check_public_network_connectivity(should_connect\u003dTrue)"},{"line_number":400,"context_line":"        self._check_network_internal_connectivity(network\u003dself.network)"},{"line_number":401,"context_line":"        self._check_network_external_connectivity()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0e080828","line":398,"range":{"start_line":398,"start_character":40,"end_line":398,"end_character":59},"in_reply_to":"fa7ab95a_bd285187","updated":"2016-08-31 07:23:38.000000000","message":"I think that adding comment is useless because the name of Def is descriptive  enough.","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"edd677d7ebf94b5f9a573b6accafa5e7446c2bf0","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                      \u0027Baremetal relies on a shared physical network.\u0027)"},{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type in [\u0027flat\u0027],"},{"line_number":417,"context_line":"                      \u0027Network type Flat cannot support 2 diffrent networks \u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_a31aee7a","line":416,"range":{"start_line":416,"start_character":0,"end_line":416,"end_character":69},"updated":"2016-08-30 19:32:12.000000000","message":"As there is only single element, it will be better if direct check is done instead of list.","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"fbe07dd6740384c7c845f8e3eeb655f7993c0b9d","unresolved":false,"context_lines":[{"line_number":413,"context_line":"                      \u0027Baremetal relies on a shared physical network.\u0027)"},{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type in [\u0027flat\u0027],"},{"line_number":417,"context_line":"                      \u0027Network type Flat cannot support 2 diffrent networks \u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_4e6770ea","line":416,"range":{"start_line":416,"start_character":0,"end_line":416,"end_character":69},"in_reply_to":"fa7ab95a_a31aee7a","updated":"2016-08-31 07:23:38.000000000","message":"Done","commit_id":"10f2edf44fadf96300abd3600a6613ca4036f31b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"918b03b05f12ebddf11d1f9d57d2a4c39373452f","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type \u003d\u003d \u0027flat\u0027,"},{"line_number":417,"context_line":"                      \u0027Network type Flat cannot support 2 diffrent networks \u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"},{"line_number":420,"context_line":"        \"\"\"Test connectivity between VMs on different networks"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_9991c155","line":417,"range":{"start_line":417,"start_character":75,"end_line":417,"end_character":76},"updated":"2016-08-31 08:46:15.000000000","message":"nit: remove trailing space.","commit_id":"a7aa8658621a4740a6ab9243fe7fe32013498b24"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"918b03b05f12ebddf11d1f9d57d2a4c39373452f","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type \u003d\u003d \u0027flat\u0027,"},{"line_number":417,"context_line":"                      \u0027Network type Flat cannot support 2 diffrent networks \u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"},{"line_number":420,"context_line":"        \"\"\"Test connectivity between VMs on different networks"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_b9c76563","line":417,"range":{"start_line":417,"start_character":36,"end_line":417,"end_character":40},"updated":"2016-08-31 08:46:15.000000000","message":"nit: s/Flat/flat/","commit_id":"a7aa8658621a4740a6ab9243fe7fe32013498b24"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"563fc1fc7b05a6a1f02271d3a6f8f2c0838f9e5e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type \u003d\u003d \u0027flat\u0027,"},{"line_number":417,"context_line":"                      \u0027Network type Flat cannot support 2 diffrent networks \u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"},{"line_number":420,"context_line":"        \"\"\"Test connectivity between VMs on different networks"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_6b9df858","line":417,"range":{"start_line":417,"start_character":75,"end_line":417,"end_character":76},"in_reply_to":"fa7ab95a_9991c155","updated":"2016-08-31 10:38:03.000000000","message":"Done","commit_id":"a7aa8658621a4740a6ab9243fe7fe32013498b24"},{"author":{"_account_id":19118,"name":"Eran Kuris","email":"ekuris@redhat.com","username":"ekuris"},"change_message_id":"563fc1fc7b05a6a1f02271d3a6f8f2c0838f9e5e","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":415,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":416,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type \u003d\u003d \u0027flat\u0027,"},{"line_number":417,"context_line":"                      \u0027Network type Flat cannot support 2 diffrent networks \u0027)"},{"line_number":418,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":419,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"},{"line_number":420,"context_line":"        \"\"\"Test connectivity between VMs on different networks"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_8ba23c99","line":417,"range":{"start_line":417,"start_character":36,"end_line":417,"end_character":40},"in_reply_to":"fa7ab95a_b9c76563","updated":"2016-08-31 10:38:03.000000000","message":"Done","commit_id":"a7aa8658621a4740a6ab9243fe7fe32013498b24"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"95e2e88b2bbead8649f0f0a37ba98b328c1156bd","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":425,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type \u003d\u003d \u0027flat\u0027,"},{"line_number":426,"context_line":"                      \u0027Network type flat cannot support 2 diffrent networks\u0027)"},{"line_number":427,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":428,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"},{"line_number":429,"context_line":"        \"\"\"Test connectivity between VMs on different networks"},{"line_number":430,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_6872ee4a","line":427,"updated":"2017-01-05 11:16:01.000000000","message":"You have 2 test.services decorator now.","commit_id":"e776f14954401de25cafc89e3e5d0bd13a4dc119"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"39266b77e9be0a8527330ec3e7b69a141e8f9a84","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    @decorators.skip_because(bug\u003d\"1610994\")"},{"line_number":424,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":425,"context_line":"    @testtools.skipIf(CONF.network.provider_network_type \u003d\u003d \u0027flat\u0027,"},{"line_number":426,"context_line":"                      \u0027Network type flat cannot support 2 diffrent networks\u0027)"},{"line_number":427,"context_line":"    @test.services(\u0027compute\u0027, \u0027network\u0027)"},{"line_number":428,"context_line":"    def test_connectivity_between_vms_on_different_networks(self):"},{"line_number":429,"context_line":"        \"\"\"Test connectivity between VMs on different networks"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a461143_0f6c05cf","line":426,"updated":"2017-01-30 12:10:34.000000000","message":"You could have multiple PF on the same node in a different physnet, but it would make the tempest config even more confusing.","commit_id":"f75562cc6ae53ffdd302bf47bed80b225a929e08"}]}