)]}'
{"tempest/api/compute/admin/test_quotas.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"29ac2677bb9433db61661abe7f29d8c1dd90743a","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    @test.idempotent_id(\u0027389d04f0-3a41-405f-9317-e5f86e3c44f0\u0027)"},{"line_number":133,"context_line":"    def test_delete_quota(self):"},{"line_number":134,"context_line":"        # Admin can delete the resource quota set for a project"},{"line_number":135,"context_line":"        # Verify that delete quota set of project"},{"line_number":136,"context_line":"        project_name \u003d data_utils.rand_name(\u0027ram_quota_project\u0027)"},{"line_number":137,"context_line":"        project_desc \u003d project_name + \u0027-desc\u0027"},{"line_number":138,"context_line":"        project \u003d self.identity_utils.create_project(name\u003dproject_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_7a0c843b","line":135,"updated":"2016-09-01 15:40:58.000000000","message":"I can\u0027t figure out what this sentence means. Please rephrase this or don\"t add this line.","commit_id":"0efd6357b7e8c671f5ac5648459f9974ad7baab9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"29ac2677bb9433db61661abe7f29d8c1dd90743a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        quota_set_new \u003d self.adm_client.show_quota_set(project_id)[\u0027quota_set\u0027]"},{"line_number":148,"context_line":"        self.assertEqual(ram_default, quota_set_new[\u0027ram\u0027])"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # Verify delete quota set of user"},{"line_number":151,"context_line":"        user_name \u003d data_utils.rand_name(\u0027ram_quota_user\u0027)"},{"line_number":152,"context_line":"        password \u003d data_utils.rand_password()"},{"line_number":153,"context_line":"        email \u003d user_name + \u0027@testmail.tm\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_7ab724f5","line":150,"updated":"2016-09-01 15:40:58.000000000","message":"This should be a separated test, imo.","commit_id":"0efd6357b7e8c671f5ac5648459f9974ad7baab9"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"29ac2677bb9433db61661abe7f29d8c1dd90743a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                                               password\u003dpassword,"},{"line_number":156,"context_line":"                                               project\u003dproject,"},{"line_number":157,"context_line":"                                               email\u003demail)"},{"line_number":158,"context_line":"        if \u0027user\u0027 in user:"},{"line_number":159,"context_line":"            user \u003d user[\u0027user\u0027]"},{"line_number":160,"context_line":"        user_id \u003d user[\u0027id\u0027]"},{"line_number":161,"context_line":"        self.addCleanup(self.identity_utils.delete_user, user_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_9a95c841","line":158,"updated":"2016-09-01 15:40:58.000000000","message":"This seems to be already done in the create_user method of tempest/common/cred_client.py","commit_id":"0efd6357b7e8c671f5ac5648459f9974ad7baab9"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"226ca1d1c82327b279c8c56d843ab86854d5b9dd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        for quota in new_quota_set:"},{"line_number":89,"context_line":"            self.assertIn(quota, quota_set.keys())"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    # TODO(afazekas): merge these test cases"},{"line_number":92,"context_line":"    @test.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":93,"context_line":"    def test_get_update_delete_quotas(self):"},{"line_number":94,"context_line":"        # Verify that GET shows the updated and deleted quota set of project"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_d63a34e7","line":91,"range":{"start_line":91,"start_character":1,"end_line":91,"end_character":44},"updated":"2016-12-29 07:35:50.000000000","message":"if you have merged these two testcases,then this can be removed.","commit_id":"f19a78603a320d8ce915c5528d3d9b87216fb4d0"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"226ca1d1c82327b279c8c56d843ab86854d5b9dd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @test.idempotent_id(\u0027ce9e0815-8091-4abd-8345-7fe5b85faa1d\u0027)"},{"line_number":93,"context_line":"    def test_get_update_delete_quotas(self):"},{"line_number":94,"context_line":"        # Verify that GET shows the updated and deleted quota set of project"},{"line_number":95,"context_line":"        project_name \u003d data_utils.rand_name(\u0027cpu_quota_project\u0027)"},{"line_number":96,"context_line":"        project_desc \u003d project_name + \u0027-desc\u0027"},{"line_number":97,"context_line":"        project \u003d self.identity_utils.create_project(name\u003dproject_name,"},{"line_number":98,"context_line":"                                                     description\u003dproject_desc)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba5201f7_b903e30c","line":95,"range":{"start_line":95,"start_character":43,"end_line":95,"end_character":64},"updated":"2016-12-29 07:35:50.000000000","message":"such kind of name seems strange, especially the word \u0027cpu\u0027. maybe you can use data_utils.rand_name(self.__class__.__name__ + \u0027-quota\u0027)","commit_id":"f19a78603a320d8ce915c5528d3d9b87216fb4d0"}],"tempest/lib/services/compute/quotas_client.py":[{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"e207d49fbb14d0af8c5a54fb0a424a0fdaf1dd37","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        self.validate_response(schema.update_quota_set, resp, body)"},{"line_number":64,"context_line":"        return rest_client.ResponseBody(resp, body)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def delete_quota_set(self, tenant_id, user_id\u003dNone):"},{"line_number":67,"context_line":"        \"\"\"Delete the tenant\u0027s quota set.\"\"\""},{"line_number":68,"context_line":"        url \u003d \u0027os-quota-sets/%s\u0027 % tenant_id"},{"line_number":69,"context_line":"        if user_id:"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa31d9ce_fe6a10b2","line":66,"updated":"2017-02-14 11:13:34.000000000","message":"Given that user_id is passed as a GET parameter/query string, you should have a **params arg here and use urllib.urlencode(params).\n\nPlease have a look at the list_namespace_tags() method for a good example to follow.","commit_id":"60487bbf4206af502d7bb48560ccb2d23e44f21a"}]}