)]}'
{"tempest/api/compute/admin/test_servers.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"588aa1b4c3b129083288246fedd287d56a6b429d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # contain the other tenants\u0027 server by default"},{"line_number":77,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue)"},{"line_number":78,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":79,"context_line":"        if servers is not []:"},{"line_number":80,"context_line":"            # This case is for the test environments which contain"},{"line_number":81,"context_line":"            # the existing servers before testing"},{"line_number":82,"context_line":"            servers_name \u003d [server[\u0027name\u0027] for server in servers]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_f6424f3d","line":79,"updated":"2016-09-02 06:43:35.000000000","message":"Do we really need this \u0027if\u0027 statement?\nI was actually wondering \"where is the assertEqual([], servers)?\". :-p","commit_id":"e3015447c86121bfbd560e6c267e81330746550c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac8bb7d8901346ce91ebfb301904bd7e4d67c3d9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        # contain the other tenants\u0027 server by default"},{"line_number":77,"context_line":"        body \u003d self.client.list_servers(detail\u003dTrue)"},{"line_number":78,"context_line":"        servers \u003d body[\u0027servers\u0027]"},{"line_number":79,"context_line":"        if servers is not []:"},{"line_number":80,"context_line":"            # This case is for the test environments which contain"},{"line_number":81,"context_line":"            # the existing servers before testing"},{"line_number":82,"context_line":"            servers_name \u003d [server[\u0027name\u0027] for server in servers]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_b0c6a614","line":79,"in_reply_to":"fa7ab95a_f6424f3d","updated":"2016-09-02 16:45:58.000000000","message":"Haha, yeah, I also had the same question when writing the code by myself ;-)\n\nCurrent code seems a kind of magic, and I did misunderstand line 82 raises an exception if removing this \"if\". But we can remove it and that would be readable for us.","commit_id":"e3015447c86121bfbd560e6c267e81330746550c"},{"author":{"_account_id":7350,"name":"Jordan Pittier","email":"jordan.pittier@gmail.com","username":"JordanP"},"change_message_id":"d5493cefd3437eeecf4614f0ae13f4f19581fae9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            # This case is for the test environments which contain"},{"line_number":81,"context_line":"            # the existing servers before testing"},{"line_number":82,"context_line":"            servers_name \u003d [server[\u0027name\u0027] for server in servers]"},{"line_number":83,"context_line":"            self.assertNotIn(self.s1_name, servers_name)"},{"line_number":84,"context_line":"            self.assertNotIn(self.s2_name, servers_name)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @test.idempotent_id(\u00279f5579ae-19b4-4985-a091-2a5d56106580\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_84a45b4b","line":83,"updated":"2016-09-02 12:08:18.000000000","message":"Shouldn\"t this be self.assertIn(...) ?","commit_id":"e3015447c86121bfbd560e6c267e81330746550c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ac8bb7d8901346ce91ebfb301904bd7e4d67c3d9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            # This case is for the test environments which contain"},{"line_number":81,"context_line":"            # the existing servers before testing"},{"line_number":82,"context_line":"            servers_name \u003d [server[\u0027name\u0027] for server in servers]"},{"line_number":83,"context_line":"            self.assertNotIn(self.s1_name, servers_name)"},{"line_number":84,"context_line":"            self.assertNotIn(self.s2_name, servers_name)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @test.idempotent_id(\u00279f5579ae-19b4-4985-a091-2a5d56106580\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_f09e6e06","line":83,"in_reply_to":"fa7ab95a_84a45b4b","updated":"2016-09-02 16:45:58.000000000","message":"No, s1_name and s2_name servers are the other tenant\u0027s servers and the API *without all_tenants* should not contain them even if an admin users. That is this test.","commit_id":"e3015447c86121bfbd560e6c267e81330746550c"}]}