)]}'
{"tempest/config.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d300ddd46b81610c51adbddae15120cab7c3a1ac","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    cfg.StrOpt(\u0027ssh_user\u0027,"},{"line_number":522,"context_line":"               default\u003d\u0027cirros\u0027,"},{"line_number":523,"context_line":"               help\u003d\u0027ssh username for the image file\u0027),"},{"line_number":524,"context_line":"    cfg.IntOpt("},{"line_number":525,"context_line":"        \u0027large_ops_number\u0027,"},{"line_number":526,"context_line":"        default\u003d0,"},{"line_number":527,"context_line":"        help\u003d\"specifies how many resources to request at once. Used \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F0c4%3D","line":524,"updated":"2013-07-10 23:30:45.000000000","message":"Is this LF necessary?\nAnd, I think this option should be in etc/tempest.conf.sample too.","commit_id":"a0bcd3d57c771105a0badbc565248d2cb322f181"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"875ca77fd7e329256254f128318b13026d452ec4","unresolved":false,"context_lines":[{"line_number":521,"context_line":"    cfg.StrOpt(\u0027ssh_user\u0027,"},{"line_number":522,"context_line":"               default\u003d\u0027cirros\u0027,"},{"line_number":523,"context_line":"               help\u003d\u0027ssh username for the image file\u0027),"},{"line_number":524,"context_line":"    cfg.IntOpt("},{"line_number":525,"context_line":"        \u0027large_ops_number\u0027,"},{"line_number":526,"context_line":"        default\u003d0,"},{"line_number":527,"context_line":"        help\u003d\"specifies how many resources to request at once. Used \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2Fy%2BM%3D","line":524,"in_reply_to":"AAAAP3%2F%2F0c4%3D","updated":"2013-07-11 09:28:45.000000000","message":"the reason for this was, attempting to spin up 50 instances at once won\u0027t work in all clouds (depending on size etc).  And Sean recommended using a config option that disables the test by default","commit_id":"a0bcd3d57c771105a0badbc565248d2cb322f181"}],"tempest/scenario/test_large_ops.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d300ddd46b81610c51adbddae15120cab7c3a1ac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 NEC Corporation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F0d8%3D","line":3,"updated":"2013-07-10 23:30:45.000000000","message":"Are you NEC guy? :-)\nI\u0027m not sure a \u0027# Copyright ....\u0027 sentence is needed though.","commit_id":"a0bcd3d57c771105a0badbc565248d2cb322f181"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"875ca77fd7e329256254f128318b13026d452ec4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2013 NEC Corporation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2Fy98%3D","line":3,"in_reply_to":"AAAAP3%2F%2F0d8%3D","updated":"2013-07-11 09:28:45.000000000","message":"I copied this file from the test_minimum_basic and to be safe I just left that.","commit_id":"a0bcd3d57c771105a0badbc565248d2cb322f181"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"9ee50fd4941ecb199bab39a1b9695bbc46eb6c94","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return image.id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def glance_image_create(self):"},{"line_number":66,"context_line":"        aki_img_path \u003d self.config.scenario.img_dir + \"/\" + \\"},{"line_number":67,"context_line":"            self.config.scenario.aki_img_file"},{"line_number":68,"context_line":"        ari_img_path \u003d self.config.scenario.img_dir + \"/\" + \\"},{"line_number":69,"context_line":"            self.config.scenario.ari_img_file"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fxc4%3D","line":66,"updated":"2013-07-11 17:20:33.000000000","message":"In general, string concatenating with the the + sign is avoided. I think use format here would make more sense (\"{0}/{1}\".format(self.config.scenario.img_dir, self.config.scenario.aki_img_file)","commit_id":"b5e10cdb50283297d40f4edda6585fef6293dc9f"},{"author":{"_account_id":97,"name":"Daryl Walleck","email":"daryl.walleck@rackspace.com","username":"dwalleck"},"change_message_id":"501f691113ec939cff1f5c3a74d5cc8479570d13","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return image.id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def glance_image_create(self):"},{"line_number":66,"context_line":"        aki_img_path \u003d self.config.scenario.img_dir + \"/\" + \\"},{"line_number":67,"context_line":"            self.config.scenario.aki_img_file"},{"line_number":68,"context_line":"        ari_img_path \u003d self.config.scenario.img_dir + \"/\" + \\"},{"line_number":69,"context_line":"            self.config.scenario.ari_img_file"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fwz0%3D","line":66,"in_reply_to":"AAAAP3%2F%2Fw2Q%3D","updated":"2013-07-11 20:02:03.000000000","message":"Force of habit. Reverting vote to 0.","commit_id":"b5e10cdb50283297d40f4edda6585fef6293dc9f"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"6774d8a183484d2314851db880de432049907d07","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return image.id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def glance_image_create(self):"},{"line_number":66,"context_line":"        aki_img_path \u003d self.config.scenario.img_dir + \"/\" + \\"},{"line_number":67,"context_line":"            self.config.scenario.aki_img_file"},{"line_number":68,"context_line":"        ari_img_path \u003d self.config.scenario.img_dir + \"/\" + \\"},{"line_number":69,"context_line":"            self.config.scenario.ari_img_file"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fw2Q%3D","line":66,"in_reply_to":"AAAAP3%2F%2Fxc4%3D","updated":"2013-07-11 19:58:25.000000000","message":"IMHO we should try to avoid (-1) a changes just because of a style issue.\nWe should convince the flake8 to do that by flake8 a extensions.\nAnd should extend the HACKING.rst with these kind of guidelines.\n\nIf a style is good for flake8 it is good for me, it checks many many things anyway.\n\nBTW 1:\nThe  string expression in a \u0027( )\u0027  makes the tailing \u0027\\\u0027 unnecessary.\n\nBTT 2.\nFor this kind of join the \u0027/\u0027.join((self.config.scenario.img_dir, self.config.scenario.aki_img_file))\nis faster  (you can try micro benchmark it ) and shorter.","commit_id":"b5e10cdb50283297d40f4edda6585fef6293dc9f"}]}