)]}'
{"tempest/api/network/test_routers.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"4615e04518069bb43057eee555863ce412ea2664","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F11c%3D","line":3,"updated":"2013-07-22 10:43:38.000000000","message":"Please fix the copyright header. If you want to assign copyright (you don\u0027t have to) it should be assigned to the OpenStack Foundation","commit_id":"76f19537c7e2d0aa42b7722ea06f6695a5fded31"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"daa1239747bd8a4a7f2cd95545a6d4ceccbec2d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack, LLC"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fyok%3D","line":3,"in_reply_to":"AAAAQn%2F%2F11c%3D","updated":"2013-07-23 06:50:42.000000000","message":"Done","commit_id":"76f19537c7e2d0aa42b7722ea06f6695a5fded31"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"4615e04518069bb43057eee555863ce412ea2664","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":32,"context_line":"        #Asserting that the router is not found in the list"},{"line_number":33,"context_line":"        #after deletion"},{"line_number":34,"context_line":"        resp, list_body \u003d self.client.list_routers()"},{"line_number":35,"context_line":"        found \u003d any(router for router in list_body[\u0027routers\u0027]"},{"line_number":36,"context_line":"                    if router[\u0027id\u0027] \u003d\u003d router_id)"},{"line_number":37,"context_line":"        self.assertFalse(found)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F10w%3D","line":34,"updated":"2013-07-22 10:43:38.000000000","message":"perhaps should check status code from list_routers otherwise could get a false positive?","commit_id":"76f19537c7e2d0aa42b7722ea06f6695a5fded31"},{"author":{"_account_id":2238,"name":"rajalakshmi-ganesan","email":"rajalakshmi.girish@hpe.com","username":"rajalakshmi-ganesan"},"change_message_id":"daa1239747bd8a4a7f2cd95545a6d4ceccbec2d6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":32,"context_line":"        #Asserting that the router is not found in the list"},{"line_number":33,"context_line":"        #after deletion"},{"line_number":34,"context_line":"        resp, list_body \u003d self.client.list_routers()"},{"line_number":35,"context_line":"        found \u003d any(router for router in list_body[\u0027routers\u0027]"},{"line_number":36,"context_line":"                    if router[\u0027id\u0027] \u003d\u003d router_id)"},{"line_number":37,"context_line":"        self.assertFalse(found)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fyog%3D","line":34,"in_reply_to":"AAAAQn%2F%2F10w%3D","updated":"2013-07-23 06:50:42.000000000","message":"Done","commit_id":"76f19537c7e2d0aa42b7722ea06f6695a5fded31"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"517435c8999338dca56c68e6905732caebd9fce0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def _delete_router(self, router_id):"},{"line_number":30,"context_line":"        resp, _ \u003d self.client.delete_router(router_id)"},{"line_number":31,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":32,"context_line":"        #Asserting that the router is not found in the list"},{"line_number":33,"context_line":"        #after deletion"},{"line_number":34,"context_line":"        resp, list_body \u003d self.client.list_routers()"},{"line_number":35,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FwoY%3D","line":32,"updated":"2013-07-26 11:44:02.000000000","message":"micro nit, space after # please","commit_id":"4dcaa57b811da2254004376d36f07d2e63285a73"},{"author":{"_account_id":1795,"name":"Ravikumar Venkatesan","email":"ravikumar.venkatesan@hpe.com","username":"ravikumar-venkatesan"},"change_message_id":"3aa55f88c550a021151b952b5f333b0985a55e5e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            router_id, port_id)"},{"line_number":48,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":51,"context_line":"    def test_create_and_delete_router_with_optional_params(self):"},{"line_number":52,"context_line":"        name \u003d rand_name(\u0027router-\u0027)"},{"line_number":53,"context_line":"        resp, create_body \u003d self.client.create_router("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FmM0%3D","line":50,"updated":"2013-07-26 20:46:34.000000000","message":"Please remove the test -  test_create_and_delete_router_with_optional_params(self):\nOther test take care of this test","commit_id":"4dcaa57b811da2254004376d36f07d2e63285a73"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"517435c8999338dca56c68e6905732caebd9fce0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.assertEqual(\u0027200\u0027, resp[\u0027status\u0027])"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":51,"context_line":"    def test_create_and_delete_router_with_optional_params(self):"},{"line_number":52,"context_line":"        name \u003d rand_name(\u0027router-\u0027)"},{"line_number":53,"context_line":"        resp, create_body \u003d self.client.create_router("},{"line_number":54,"context_line":"            name, external_gateway_info\u003d{"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Fwn8%3D","line":51,"updated":"2013-07-26 11:44:02.000000000","message":"isn\u0027t this just a subset of the next testing?","commit_id":"4dcaa57b811da2254004376d36f07d2e63285a73"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"517435c8999338dca56c68e6905732caebd9fce0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        resp, list_body \u003d self.client.list_routers()"},{"line_number":66,"context_line":"        found \u003d any(router for router in list_body[\u0027routers\u0027]"},{"line_number":67,"context_line":"                    if router[\u0027id\u0027] \u003d\u003d create_body[\u0027router\u0027][\u0027id\u0027])"},{"line_number":68,"context_line":"        self.assertTrue(found)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @attr(type\u003d\u0027positive\u0027)"},{"line_number":71,"context_line":"    def test_create_show_list_update_delete_router(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FwoM%3D","line":68,"updated":"2013-07-26 11:44:02.000000000","message":"please avoid assertTrue, it\u0027s terrible to debug. can you do an assertIn here?","commit_id":"4dcaa57b811da2254004376d36f07d2e63285a73"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"916a363400d72c78a4834e575664e141f3141740","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FNUY%3D","line":3,"updated":"2013-08-05 13:51:31.000000000","message":"Please fix the copyright date","commit_id":"fcbcf4061d1b1e123d81b25b28a99e84f09c8005"}]}